Re: [meta-fsl-arm][PATCH 1/2] add gpu-viv-bin-mx6q-dev to meta-qt5's packagegroup-qt5-toolchain-target

From: "Andreas Müller" <schnitzeltony@googlemail.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: "meta-freescale@yoctoproject.org" <meta-freescale@yoctoproject.org>
Subject: Re: [meta-fsl-arm][PATCH 1/2] add gpu-viv-bin-mx6q-dev to meta-qt5's packagegroup-qt5-toolchain-target
Date: Tue, 10 Feb 2015 18:44:46 +0100	[thread overview]
Message-ID: <CALbNGRQvyyZK1Dmdib=yM4ZLn5AsDuZGLVmL8awGbPTqx+_XQw@mail.gmail.com> (raw)
In-Reply-To: <CALbNGRTXDuNCxN72v-QHu8e0OxXFxPxdBuQNmCu9mx_c2xfa7g@mail.gmail.com>

On Fri, Feb 6, 2015 at 9:39 AM, Andreas Müller
<schnitzeltony@googlemail.com> wrote:
> On Fri, Feb 6, 2015 at 2:20 AM, Otavio Salvador <otavio@ossystems.com.br> wrote:
>> Hello Andreas,
>>
>> On Tue, Jan 27, 2015 at 1:00 PM, Andreas Müller
>> <schnitzeltony@googlemail.com> wrote:
>>> gpu-viv-bin-mx6q-dev supplies EGL/GL/GLES headers. Without these compiling on
>>> target fails.
>>>
>>> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
>>> ---
>>>  qt5-layer/recipes-qt/qt5/packagegroup-qt5-toolchain-target.bbappend | 1 +
>>>  1 file changed, 1 insertion(+)
>>>  create mode 100644 qt5-layer/recipes-qt/qt5/packagegroup-qt5-toolchain-target.bbappend
>>>
>>> diff --git a/qt5-layer/recipes-qt/qt5/packagegroup-qt5-toolchain-target.bbappend b/qt5-layer/recipes-qt/qt5/packagegroup-qt5-toolchain-target.bbappend
>>> new file mode 100644
>>> index 0000000..9a4dc62
>>> --- /dev/null
>>> +++ b/qt5-layer/recipes-qt/qt5/packagegroup-qt5-toolchain-target.bbappend
>>> @@ -0,0 +1 @@
>>> +RRECOMMENDS_${PN}_append_mx6 += "gpu-viv-bin-mx6q-dev"
>>
>> I have put some thought on this and I'd like to propose another way to
>> fix it. I think it will be work but it'd be nice if you could try and
>> check.
>>
>> The files available on this -dev package are:
>>
>> -rw-r--r-- root/root       822 2015-02-05 19:16
>> ./usr/include/wayland-viv/wayland-viv-server-protocol.h
>> -rw-r--r-- root/root       464 2015-02-05 19:16
>> ./usr/include/wayland-viv/gc_wayland_protocol.h
>> -rw-r--r-- root/root      1226 2015-02-05 19:16
>> ./usr/include/wayland-viv/wayland-viv-client-protocol.h
>> -rw-r--r-- root/root      7224 2015-02-05 19:16 ./usr/include/gc_vdk_hal.h
>> -rw-r--r-- root/root      6122 2015-02-05 19:16 ./usr/include/gc_vdk_types.h
>>
>> So I think:
>>
>> -rw-r--r-- root/root       822 2015-02-05 19:16
>> ./usr/include/wayland-viv/wayland-viv-server-protocol.h
>> -rw-r--r-- root/root       464 2015-02-05 19:16
>> ./usr/include/wayland-viv/gc_wayland_protocol.h
>> -rw-r--r-- root/root      1226 2015-02-05 19:16
>> ./usr/include/wayland-viv/wayland-viv-client-protocol.h
>>
>> Should go to libvivante-mx6-dev package, while:
>>
>> -rw-r--r-- root/root      7224 2015-02-05 19:16 ./usr/include/gc_vdk_hal.h
>> -rw-r--r-- root/root      6122 2015-02-05 19:16 ./usr/include/gc_vdk_types.h
>>
>> Should go to libvdk-mx6-dev.
>>
>> Do you think it works out of box doing this change?
>>
Ok I updated to current meta-fsl-arm and would like to come back to this:

The patch I send appended packagegroup-qt5-toolchain-target so that
GL/GLES headers were installed on the target. I've found this
necessity when testing the qt-creator patches for meta-qt5: To compile
and debug my sample projects, the headers were required.

After building latest imx-gpu-viv I don't understand your suggestion -
maybe it was based on old gpu-viv-bin-mx6q or I misunderstand
something. With current meta-fsl master the -dev packages look good to
me and I would simply append ALL dev-packages to
packagegroup-qt5-toolchain-target. The only contents added to image
are includes and pkg-config so there should be no harm.

What do you think?

Andreas