Re: [oe] [PATCH 2/6] gnome-commander: initial add 1.14.2

["Andreas Müller" <schnitzeltony@gmail.com>]

On Thu, Mar 31, 2022 at 6:09 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> seeing this build failure on arm64 ( I use clang )
>
> | In file included from
> ../../../gnome-commander-1.14.2/src/intviewer/searcher.cc:27:
> | In file included from
> ../../../gnome-commander-1.14.2/src/intviewer/libgviewer.h:40:
> | In file included from
> ../../../gnome-commander-1.14.2/src/intviewer/viewer-window.h:27:
> | In file included from
> ../../../gnome-commander-1.14.2/src/intviewer/../gnome-cmd-includes.h:24:
>
>              | In file included from
> ../../../gnome-commander-1.14.2/libgcmd/libgcmd.h:26:
> | ../../../gnome-commander-1.14.2/libgcmd/libgcmd-widget-factory.h:167:70:
> warning: 'format' attribute argument not supported: gnu_printf
> [-Wignored-attributes]
> |     void create_error_dialog (const gchar *msg, ...) __attribute__
> ((format (gnu_printf, 1, 2)));
> |                                                                      ^
> | ../../../gnome-commander-1.14.2/src/intviewer/searcher.cc:303:5:
> error: cannot initialize a parameter of type 'gint *' (aka 'int *')
> with an rvalue of type 'void *'
> |     g_atomic_int_compare_and_exchange (&src->priv->progress_value,
> oldval, (gint)d);
> |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | /mnt/b/yoe/master/build/tmp/work/cortexa72-yoe-linux/gnome-commander/1.14.2-r0/recipe-sysroot/usr/include/glib-2.0/glib/gatomic.h:160:44:
> note: expanded from macro 'g_atomic_int_co
> mpare_and_exchange'
> |     __atomic_compare_exchange_n ((atomic), (void *)
> (&(gaicae_oldval)), (newval), FALSE, __ATOMIC_SEQ_CST,
> __ATOMIC_SEQ_CST) ? TRUE : FALSE; \
> |                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> | 1 warning and 1 error generated.
> | make[3]: *** [Makefile:521: searcher.o] Error 1
> | make[3]: Leaving directory
> '/mnt/b/yoe/master/build/tmp/work/cortexa72-yoe-linux/gnome-commander/1.14.2-r0/build/src/intviewer'

Looked into this and think the code of gnome-commander is correct.
Looks to me that glib-2 atomic macros do not work properly in your
environment. My clang/gcc-runtime build is still pending so I ask: Was
this with llvm runtime?

Andreas