Re: [meta-raspberrypi][PATCH] rpi-base.inc: Add xf86-input-evdev to XSERVER

From: "Andreas Müller" <schnitzeltony@googlemail.com>
To: Jussi Kukkonen <jussi.kukkonen@intel.com>
Cc: Yocto Project <yocto@yoctoproject.org>, Gary Thomas <gary@mlbassoc.com>
Subject: Re: [meta-raspberrypi][PATCH] rpi-base.inc: Add xf86-input-evdev to XSERVER
Date: Thu, 16 Feb 2017 08:57:05 +0100	[thread overview]
Message-ID: <CALbNGRS_PGGED6=4D2NRZMB+m3XJPR3RvH_XymX==Yf017OKyg@mail.gmail.com> (raw)
In-Reply-To: <CAHiDW_G3e69veAX4ZUxSG6QMCOLJWB_cH6upd0Muwbn7EQqUTg@mail.gmail.com>

On Thu, Feb 16, 2017 at 8:37 AM, Jussi Kukkonen
<jussi.kukkonen@intel.com> wrote:
> On 16 February 2017 at 04:14, Gary Thomas <gary@mlbassoc.com> wrote:
>>
>> On 2017-02-16 02:45, Andrei Gherzan wrote:
>>>
>>> On Mon, Feb 13, 2017 at 12:25:48AM +0900, Yusuke Mitsuki wrote:
>>>>
>>>> In order to fix problem that mouse does not work.
>>>>
>>>> This is removed c40558173ffd96c499d101155f6c4c2be85d9f0f.
>>>> However mouse does not worked from this.
>>>> ---
>>>>  conf/machine/include/rpi-base.inc | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/conf/machine/include/rpi-base.inc
>>>> b/conf/machine/include/rpi-base.inc
>>>> index e069e70..051c717 100644
>>>> --- a/conf/machine/include/rpi-base.inc
>>>> +++ b/conf/machine/include/rpi-base.inc
>>>> @@ -11,6 +11,7 @@ XSERVER = " \
>>>>      xserver-xorg \
>>>>      ${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics",
>>>> "xserver-xorg-extension-glx", "", d)} \
>>>>      ${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics",
>>>> "xf86-video-modesetting", "xf86-video-fbdev", d)} \
>>>> +    xf86-input-evdev \
>>>>      "
>>>>
>>>>  KERNEL_DEVICETREE ?= " \
>>>> --
>>>> 2.7.4
>>>>
>>>> --
>>>> _______________________________________________
>>>> yocto mailing list
>>>> yocto@yoctoproject.org
>>>> https://lists.yoctoproject.org/listinfo/yocto
>>>
>>>
>>> CC-ing schnitzeltony@googlemail.com as he might have an opinion about
>>> this. I personally don't really hold on any of the options.
>>
>>
>> I think it's the right thing to do, in fact, I was preparing a
>> similar patch myself.  The change that removed this argued that
>> it was not the responsibility of the BSP layer, but if you look
>> around at other BSP layers, almost all of them do include this
>> driver as part of their X server setup.  It also lets X work
>> again on the RaspberryPi "out of the box" with the simplest
>> configuration - HDMI display + USB keyboard & mouse.
>>
>> +1
>
>
> Out of interest: Why is xf86-input-libinput not appropriate for these
> setups? I honestly did not know of a use case where -evdev would work but
> -libinput would not...
>
I would have asked the same question. When preferring -libinput it
might be a good idea to remove
recipes-graphics/xorg-xserver/xserver-xf86-config/rpi/xorg.conf.d/10-evdev.conf

Andreas