From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Blunck <jblunck@infradead.org>
Subject: Re: [PATCH v2 12/12] drivers: update PMDs to use
	rte_driver probe and remove
Date: Thu, 15 Dec 2016 22:36:19 +0100
Message-ID: <CALe+Z01W-GP0WiCBMvY60iv0sMd2jZMAuZRt2SvoWw+bJ7ZODw@mail.gmail.com>
References: <1480846288-2517-1-git-send-email-shreyansh.jain@nxp.com>
 <1481636232-2300-1-git-send-email-shreyansh.jain@nxp.com>
 <1481636232-2300-13-git-send-email-shreyansh.jain@nxp.com>
 <e86729f5-074b-3ec0-ef03-6911c30d070a@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: dev@dpdk.org, David Marchand <david.marchand@6wind.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>, jianbo.liu@linaro.org
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wj0-f194.google.com (mail-wj0-f194.google.com
 [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 943DF2C4F
 for <dev@dpdk.org>; Thu, 15 Dec 2016 22:36:20 +0100 (CET)
Received: by mail-wj0-f194.google.com with SMTP id j10so11826263wjb.3
 for <dev@dpdk.org>; Thu, 15 Dec 2016 13:36:20 -0800 (PST)
In-Reply-To: <e86729f5-074b-3ec0-ef03-6911c30d070a@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Dec 14, 2016 at 10:49 AM, Shreyansh Jain <shreyansh.jain@nxp.com> wrote:
> On Tuesday 13 December 2016 07:07 PM, Shreyansh Jain wrote:
>>
>> These callbacks now act as first layer of PCI interfaces from the Bus.
>> Bus probe would enter the PMDs through the rte_driver->probe/remove
>> callbacks, falling to rte_xxx_driver->probe/remove (Currently, all the
>> drivers are rte_pci_driver).
>>
>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>> ---
>>  drivers/net/bnx2x/bnx2x_ethdev.c        | 8 ++++++++
>>  drivers/net/bnxt/bnxt_ethdev.c          | 4 ++++
>>  drivers/net/cxgbe/cxgbe_ethdev.c        | 4 ++++
>>  drivers/net/e1000/em_ethdev.c           | 4 ++++
>>  drivers/net/e1000/igb_ethdev.c          | 8 ++++++++
>>  drivers/net/ena/ena_ethdev.c            | 4 ++++
>>  drivers/net/enic/enic_ethdev.c          | 4 ++++
>>  drivers/net/fm10k/fm10k_ethdev.c        | 4 ++++
>>  drivers/net/i40e/i40e_ethdev.c          | 4 ++++
>>  drivers/net/i40e/i40e_ethdev_vf.c       | 4 ++++
>>  drivers/net/ixgbe/ixgbe_ethdev.c        | 8 ++++++++
>>  drivers/net/mlx4/mlx4.c                 | 4 +++-
>>  drivers/net/mlx5/mlx5.c                 | 1 +
>>  drivers/net/nfp/nfp_net.c               | 4 ++++
>>  drivers/net/qede/qede_ethdev.c          | 8 ++++++++
>>  drivers/net/szedata2/rte_eth_szedata2.c | 4 ++++
>>  drivers/net/thunderx/nicvf_ethdev.c     | 4 ++++
>>  drivers/net/virtio/virtio_ethdev.c      | 2 ++
>>  drivers/net/vmxnet3/vmxnet3_ethdev.c    | 4 ++++
>>  19 files changed, 86 insertions(+), 1 deletion(-)
>>
> <snip>
>
> drivers/crypto/qat/rte_qat_cryptodev.c should also be changed for this. It
> seems to be only PCI registered PMD. All others are VDEV.
>
> I will send a v3 soon to fix this.
>
> @Jan, would you be looking in the VDEV part or should I start with that? [1]
>

Yes, I am doing that. Will send out early next week.

Thx,
Jan

> [1] http://dpdk.org/ml/archives/dev/2016-November/050443.html
>