From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Blunck <jblunck@infradead.org>
Subject: Re: [PATCH v2 1/5] ethdev: introduce device removal event
Date: Tue, 2 May 2017 09:35:38 +0200
Message-ID: <CALe+Z03HZkGh8a41uyJU5BLhc=bjT5Wh2KD=-Nk1b8RyhNqMvA@mail.gmail.com>
References: <cover.1492517222.git.gaetan.rivet@6wind.com>
 <ad86ce93ead0e79acbe65d08038ec0ec1ddbb01e.1492517222.git.gaetan.rivet@6wind.com>
 <923e5a49-6514-4a28-fb89-81e196ae99c9@intel.com>
 <20170425090536.GS14914@bidouze.vm.6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: dev <dev@dpdk.org>, Billy McFall <bmcfall@redhat.com>,
 Olivier MATZ <olivier.matz@6wind.com>, Ferruh Yigit <ferruh.yigit@intel.com>,
 Elad Persiko <eladpe@mellanox.com>, Thomas Monjalon <thomas@monjalon.net>
To: =?UTF-8?Q?Ga=C3=ABtan_Rivet?= <gaetan.rivet@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f178.google.com (mail-wr0-f178.google.com
 [209.85.128.178]) by dpdk.org (Postfix) with ESMTP id C5C55F72
 for <dev@dpdk.org>; Tue,  2 May 2017 09:35:39 +0200 (CEST)
Received: by mail-wr0-f178.google.com with SMTP id w50so73609558wrc.0
 for <dev@dpdk.org>; Tue, 02 May 2017 00:35:39 -0700 (PDT)
In-Reply-To: <20170425090536.GS14914@bidouze.vm.6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Am 25.04.2017 11:06 schrieb "Ga=C3=ABtan Rivet" <gaetan.rivet@6wind.com>:

Hi Ferruh,


On Fri, Apr 21, 2017 at 03:59:24PM +0100, Ferruh Yigit wrote:

> On 4/18/2017 1:17 PM, Gaetan Rivet wrote:
>
>> This new API allows reacting to a device removal.
>> A device removal is the sudden disappearance of a device from its
>> bus.
>>
>
I don't think this belongs into ethdev. If it is bus related we need to
expose this from it so that apps can register for the low level device
being unplugged.

Jan


>> PMDs implementing support for this notification guarantee that the remov=
al
>> of the underlying device does not incur a risk to the application.
>>
>> In particular, Rx/Tx bursts and all other functions can still be called
>> (albeit likely returning errors) without triggering a crash, irrespectiv=
e
>> of an application handling this event.
>>
>> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
>> Signed-off-by: Elad Persiko <eladpe@mellanox.com>
>>
>
> <...>
>
> diff --git a/doc/guides/nics/features/default.ini
>> b/doc/guides/nics/features/default.ini
>> index b1b9114..cafc6c7 100644
>> --- a/doc/guides/nics/features/default.ini
>> +++ b/doc/guides/nics/features/default.ini
>> @@ -10,6 +10,7 @@
>>  Speed capabilities   =3D
>>  Link status          =3D
>>  Link status event    =3D
>> +Removal event        =3D
>>  Queue status event   =3D
>>  Rx interrupt         =3D
>>  Free Tx mbuf on demand =3D
>>
>
> This release a few NIC features added, and it is hard to follow them if
> you are particularly looking for these features.
>
> So do you think does it make sense to put those new PMD features into
> release notes to make it more visible?
>
>
Yes it seems like a good idea to announce this evolution. I will
send the relevant patch for this soon.

Thanks,
> ferruh
>

--=20
Ga=C4=97tan Rivet
6WIND