All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Robinson <pbrobinson@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/2] [for 2018.03] RPi: Drain RX queue on setbrg
Date: Wed, 7 Mar 2018 13:07:43 +0000	[thread overview]
Message-ID: <CALeDE9MXDybcqUVpDpJnktBWxGR9M1TaCw98neH6y8CMFgWsow@mail.gmail.com> (raw)
In-Reply-To: <20180306131327.61174-1-agraf@suse.de>

On Tue, Mar 6, 2018 at 1:13 PM, Alexander Graf <agraf@suse.de> wrote:
> We had a few reports coming in from people that had their autoboot chain
> aborted after pinmuxing support was added for the RPi.
>
> The culprit is easy: The UARTs may have been enabled before, but muxed
> to an incorrect pin. That pin may have pulled the RX line down which again
> lead to lots of zero bytes gathered in the RX buffer.
>
> The easy fix for that is to drain the RX queue every time we set the baud
> rate.
>
> This patch set is the minimally intrusive fix for the RPi. We may want to
> do that generically for all serial devices later.
>
> Alexander Graf (2):
>   serial_bcm283x_mu: Flush RX queue after setting baud rate
>   bcm283x_pl011: Flush RX queue after setting baud rate

This causes mixed effects for me, a regression on the RPi2 using the
pl011, but fixes the issue on the RPi3. Both my RPi2 have serial
console and playing with the enable in config.txt doesn't seem to have
any effect on whether they auto boot or not but with it commented out
I seem to get more random chars.

Peter

  parent reply	other threads:[~2018-03-07 13:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06 13:13 [U-Boot] [PATCH 0/2] [for 2018.03] RPi: Drain RX queue on setbrg Alexander Graf
2018-03-06 13:13 ` [U-Boot] [PATCH 1/2] serial_bcm283x_mu: Flush RX queue after setting baud rate Alexander Graf
2018-03-07 12:57   ` Peter Robinson
2018-03-06 13:13 ` [U-Boot] [PATCH 2/2] bcm283x_pl011: " Alexander Graf
2018-03-07 12:59   ` Peter Robinson
2018-03-07 21:06     ` Alexander Graf
2018-03-07 13:07 ` Peter Robinson [this message]
2018-03-07 13:40   ` [U-Boot] [PATCH 0/2] [for 2018.03] RPi: Drain RX queue on setbrg Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALeDE9MXDybcqUVpDpJnktBWxGR9M1TaCw98neH6y8CMFgWsow@mail.gmail.com \
    --to=pbrobinson@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.