All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Robinson <pbrobinson@gmail.com>
To: Art Nikpal <email2tema@gmail.com>
Cc: Kever Yang <kever.yang@rock-chips.com>,
	Simon Glass <sjg@chromium.org>,
	 Jagan Teki <jagan@amarulasolutions.com>,
	sunil@amarulasolutions.com,  u-boot@lists.denx.de,
	Artem Lapkin <art@khadas.com>,
	nick@khadas.com,  Gouwa Wang <gouwa@khadas.com>
Subject: Re: [PATCH] evb_rk3399: add usb ohci definations
Date: Wed, 2 Jun 2021 08:38:49 +0100	[thread overview]
Message-ID: <CALeDE9NFV6SLMSVy0oY3NsHwDtyoBemH9BbVF5N_ej4b4_iHZw@mail.gmail.com> (raw)
In-Reply-To: <CAKaHn9L+PCPnqpO=V+tgkhaxCEJOj5Z61SO9gCPhkhpFXHTODA@mail.gmail.com>

On Wed, Jun 2, 2021 at 3:33 AM Art Nikpal <email2tema@gmail.com> wrote:
>
> > But , evb_rk3399 board does not enable CONFIG_USB_OHCI_HCD and CONFIG_USB_OHCI_GENERIC.
>
> yes i know it !
>
> for example some other rk3399 boards have it because (usb 1.1 didnt
> work without ohci on usb2.0 port and not possible to use usb kbd for
> this port )
>
> grep CONFIG_USB_OHCI_GENERIC configs/*3399*
> configs/pinebook-pro-rk3399_defconfig:CONFIG_USB_OHCI_GENERIC=y
> configs/rock960-rk3399_defconfig:CONFIG_USB_OHCI_GENERIC=y
> configs/rockpro64-rk3399_defconfig:CONFIG_USB_OHCI_GENERIC=y
>
> many other boards which used TARGET_EVB_RK3399=y must have  same
> problem (with usb1.1)

The 3 boards you mention above define their own target and don't use
TARGET_EVB_RK3399

> and i think other boards must have possibilities to use
> CONFIG_USB_OHCI_HCD and CONFIG_USB_OHCI_GENERIC.

So I think Kever's point was that without defining the following two
options in the appropriate config files your patch has no effect
because the OHCI support isn't actually built for the boards. I
suggest a v2 patch which does that.

CONFIG_USB_OHCI_HCD=y
CONFIG_USB_OHCI_GENERIC=y

Regards,
Peter

      parent reply	other threads:[~2021-06-02  7:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26  9:33 [PATCH] evb_rk3399: add usb ohci definations Artem Lapkin
2021-06-01 12:15 ` Kever Yang
2021-06-02  2:33   ` Art Nikpal
2021-06-02  2:44     ` Art Nikpal
2021-06-02  7:38     ` Peter Robinson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALeDE9NFV6SLMSVy0oY3NsHwDtyoBemH9BbVF5N_ej4b4_iHZw@mail.gmail.com \
    --to=pbrobinson@gmail.com \
    --cc=art@khadas.com \
    --cc=email2tema@gmail.com \
    --cc=gouwa@khadas.com \
    --cc=jagan@amarulasolutions.com \
    --cc=kever.yang@rock-chips.com \
    --cc=nick@khadas.com \
    --cc=sjg@chromium.org \
    --cc=sunil@amarulasolutions.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.