All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Robinson <pbrobinson@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 05/11] arm: dts: imx6qdl-gw*: add dr_mode prop to dt to avoid error
Date: Mon, 5 Apr 2021 22:27:12 +0100	[thread overview]
Message-ID: <CALeDE9NahHnWvgxwZk=3iMF92JHpxWEJQHL3_68PyXd=pG2DSg@mail.gmail.com> (raw)
In-Reply-To: <20210301223337.7763-6-tharvey@gateworks.com>

On Mon, Mar 1, 2021 at 10:34 PM Tim Harvey <tharvey@gateworks.com> wrote:
>
> The fsl-usb dt bindings in Linux default dr_mode to 'host' for
> backward compatibility however U-Boot prints an error if
> this property does not exist. Declare it in the Gateworks
> Ventana device-trees to avoid the error.

Is there any reason not to fix the driver not to error if this
property is missing rather than working around it like this?

> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
>  arch/arm/dts/imx6qdl-gw51xx.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw52xx.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw53xx.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw54xx.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw551x.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw552x.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw553x.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw560x.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw5903.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw5904.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw5907.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw5910.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw5913.dtsi | 1 +
>  13 files changed, 13 insertions(+)
>
> diff --git a/arch/arm/dts/imx6qdl-gw51xx.dtsi b/arch/arm/dts/imx6qdl-gw51xx.dtsi
> index 3c04b5a4f3..2a21c6731e 100644
> --- a/arch/arm/dts/imx6qdl-gw51xx.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw51xx.dtsi
> @@ -450,6 +450,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "otg";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw52xx.dtsi b/arch/arm/dts/imx6qdl-gw52xx.dtsi
> index 959d8ac2e3..de54b7c217 100644
> --- a/arch/arm/dts/imx6qdl-gw52xx.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw52xx.dtsi
> @@ -544,6 +544,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "otg";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw53xx.dtsi b/arch/arm/dts/imx6qdl-gw53xx.dtsi
> index 8072ed47c6..64bb88dc74 100644
> --- a/arch/arm/dts/imx6qdl-gw53xx.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw53xx.dtsi
> @@ -541,6 +541,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "otg";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw54xx.dtsi b/arch/arm/dts/imx6qdl-gw54xx.dtsi
> index 8c9bcdd398..56d090ec0f 100644
> --- a/arch/arm/dts/imx6qdl-gw54xx.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw54xx.dtsi
> @@ -611,6 +611,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "otg";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw551x.dtsi b/arch/arm/dts/imx6qdl-gw551x.dtsi
> index e5d803d023..1bb586cbd5 100644
> --- a/arch/arm/dts/imx6qdl-gw551x.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw551x.dtsi
> @@ -536,6 +536,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "otg";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw552x.dtsi b/arch/arm/dts/imx6qdl-gw552x.dtsi
> index 290a607fed..5462907f12 100644
> --- a/arch/arm/dts/imx6qdl-gw552x.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw552x.dtsi
> @@ -402,6 +402,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "otg";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw553x.dtsi b/arch/arm/dts/imx6qdl-gw553x.dtsi
> index c15b9cc63b..b6965f25da 100644
> --- a/arch/arm/dts/imx6qdl-gw553x.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw553x.dtsi
> @@ -509,6 +509,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "otg";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw560x.dtsi b/arch/arm/dts/imx6qdl-gw560x.dtsi
> index 093a219a77..d5468fb260 100644
> --- a/arch/arm/dts/imx6qdl-gw560x.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw560x.dtsi
> @@ -656,6 +656,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "otg";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw5903.dtsi b/arch/arm/dts/imx6qdl-gw5903.dtsi
> index e1c8dd233c..78f9ec90b7 100644
> --- a/arch/arm/dts/imx6qdl-gw5903.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw5903.dtsi
> @@ -531,6 +531,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "host";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw5904.dtsi b/arch/arm/dts/imx6qdl-gw5904.dtsi
> index 3cd2e717c1..52b255b726 100644
> --- a/arch/arm/dts/imx6qdl-gw5904.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw5904.dtsi
> @@ -583,6 +583,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "otg";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw5907.dtsi b/arch/arm/dts/imx6qdl-gw5907.dtsi
> index 21c68a55bc..c8b29246b7 100644
> --- a/arch/arm/dts/imx6qdl-gw5907.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw5907.dtsi
> @@ -378,6 +378,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "otg";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw5910.dtsi b/arch/arm/dts/imx6qdl-gw5910.dtsi
> index ed4e222599..56d0c4ff6c 100644
> --- a/arch/arm/dts/imx6qdl-gw5910.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw5910.dtsi
> @@ -398,6 +398,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "host";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw5913.dtsi b/arch/arm/dts/imx6qdl-gw5913.dtsi
> index 4cd7d290f5..9fae4cccd7 100644
> --- a/arch/arm/dts/imx6qdl-gw5913.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw5913.dtsi
> @@ -343,6 +343,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "host";
>         status = "okay";
>  };
>
> --
> 2.17.1
>

  reply	other threads:[~2021-04-05 21:27 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-01 22:33 [PATCH 00/11] imx: ventana: convert Gateworks Ventana to dm Tim Harvey
2021-03-01 22:33 ` [PATCH 01/11] spl: fit: nand: skip bad block handling if NAND chip not fully defined Tim Harvey
2021-03-02 13:28   ` Tom Rini
2021-04-08 20:57   ` sbabic at denx.de
2021-03-01 22:33 ` [PATCH 02/11] spl: fit: nand: allow for non-page-aligned elements Tim Harvey
2021-03-02 13:28   ` Tom Rini
2021-04-08 20:58   ` sbabic at denx.de
2021-03-01 22:33 ` [PATCH 03/11] dt-bindings: add tda1997x and bindings Tim Harvey
2021-03-02 13:28   ` Tom Rini
2021-04-08 20:57   ` sbabic at denx.de
2021-03-01 22:33 ` [PATCH 04/11] imx: ventana: add Gateworks Ventana dts Tim Harvey
2021-04-08 20:57   ` sbabic at denx.de
2021-03-01 22:33 ` [PATCH 05/11] arm: dts: imx6qdl-gw*: add dr_mode prop to dt to avoid error Tim Harvey
2021-04-05 21:27   ` Peter Robinson [this message]
2021-04-05 23:46     ` Tim Harvey
2021-04-08 20:57   ` sbabic at denx.de
2021-03-01 22:33 ` [PATCH 06/11] imx: ventana: convert U-Boot to OF_CONTROL using FIT image Tim Harvey
2021-04-08 20:57   ` sbabic at denx.de
     [not found]   ` <606f6e37.1c69fb81.a6d7.559aSMTPIN_ADDED_MISSING@mx.google.com>
2021-04-09 19:52     ` Tim Harvey
2021-04-09 20:00       ` Stefano Babic
2021-04-09 20:08         ` Tim Harvey
2021-04-09 20:14           ` Tim Harvey
2021-04-10  0:32             ` Tim Harvey
2021-03-01 22:33 ` [PATCH 07/11] imx: ventana: add pinctrl and remove unneeded UART init and config Tim Harvey
2021-04-08 20:57   ` sbabic at denx.de
2021-03-01 22:33 ` [PATCH 08/11] imx: ventana: enable dm support for USB Tim Harvey
2021-04-08 20:59   ` sbabic at denx.de
2021-03-01 22:33 ` [PATCH 09/11] imx: ventana: enable dm support for MMC and SATA Tim Harvey
2021-03-01 22:48   ` Peter Robinson
2021-03-02  0:19     ` Fabio Estevam
2021-03-02  1:41       ` Tim Harvey
2021-03-02 13:28         ` Tom Rini
2021-03-03  1:15     ` Kever Yang
2021-04-08 20:58   ` sbabic at denx.de
2021-03-01 22:33 ` [PATCH 10/11] imx: ventana: enable dm for MTD and NAND Tim Harvey
2021-04-08 20:59   ` sbabic at denx.de
2021-03-01 22:33 ` [PATCH 11/11] imx: ventana: enable dm for SPI Tim Harvey
2021-04-08 20:57   ` sbabic at denx.de
2021-03-25 13:59 ` [PATCH 00/11] imx: ventana: convert Gateworks Ventana to dm Tim Harvey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALeDE9NahHnWvgxwZk=3iMF92JHpxWEJQHL3_68PyXd=pG2DSg@mail.gmail.com' \
    --to=pbrobinson@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.