From: Peter Robinson <pbrobinson@gmail.com>
To: Harald Seiler <hws@denx.de>
Cc: "Matwey V. Kornilov" <matwey.kornilov@gmail.com>,
U-Boot Mailing List <u-boot@lists.denx.de>,
paul.barker@sancloud.com, Tom Rini <trini@konsulko.com>
Subject: Re: [BISECTED] arm: dts: Resync BeagleBone device trees
Date: Fri, 6 Aug 2021 12:44:52 +0100 [thread overview]
Message-ID: <CALeDE9ObPuECU3BU4BEF5UWYy_Gq-4a3jMR+jScmjpurq8=Q0Q@mail.gmail.com> (raw)
In-Reply-To: <5739230aa8a33618d50645315c456669c41598d1.camel@denx.de>
On Fri, Aug 6, 2021 at 12:39 PM Harald Seiler <hws@denx.de> wrote:
>
> Hi,
>
> On Fri, 2021-08-06 at 13:54 +0300, Matwey V. Kornilov wrote:
> > Hello,
> >
> > I've found that the following commit breaks USB on BeagleBone Black
> > board (am335x based):
> >
> > commit 942853dd96df5de1c0a2a61c877c1cf1c24f1e91
> > Author: Paul Barker <paul.barker@sancloud.com>
> > Date: Mon Jul 12 21:14:09 2021 +0100
> >
> > arm: dts: Resync BeagleBone device trees
> >
> >
> > When commit is applied then I see the following:
> >
> > starting USB...
> > No working controllers found
> > USB is stopped. Please issue 'usb start' first.
> > starting USB...
> > No working controllers found
> >
> > Before the commit USB was working as expected:
> >
> > starting USB...
> > Bus usb@47401800: scanning bus usb@47401800 for devices... 1 USB Device(s) found
> > scanning usb for storage devices... 1 Storage Device(s) found
> >
> > Device 0: Vendor: Rev: PMAP Prod: USB DISK Pro
> > Type: Removable Hard Disk
> > Capacity: 7381.2 MB = 7.2 GB (15116736 x 512)
> > ... is now current device
>
> It looks the the arch/arm/dts/am33xx.dtsi file is out of sync with
> Linux, leading to this regression. In the current U-Boot version, it
> has
>
> status = "disabled";
>
> lines for e.g. usb0 while in Linux mainline, those are missing. As the
> commit you found by bisecting drops the
>
> status = "okay";
>
> lines from arch/arm/dts/am335x-bone-common.dtsi, the device now are no
> longer enabled. Maybe try syncing am33xx.dtsi as well to check if it
> helps?
It's usual for peripheral devices to be disabled in the SoC .dtsi
file, those that are actively used by devices are supposed to enable
them in the device .dts so I would expect to see the appropriate bit
enabling it in the device .dts.
next prev parent reply other threads:[~2021-08-06 11:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 10:54 [BISECTED] arm: dts: Resync BeagleBone device trees Matwey V. Kornilov
2021-08-06 11:39 ` Harald Seiler
2021-08-06 11:44 ` Peter Robinson [this message]
2021-08-06 11:50 ` Matwey V. Kornilov
2021-08-06 12:21 ` Harald Seiler
2021-08-06 15:25 ` Matwey V. Kornilov
2021-08-07 11:17 ` [PATCH] am33xx: Fix USB for am335x boards Matwey V. Kornilov
2021-08-07 12:48 ` Paul Barker
2021-08-10 10:04 ` Harald Seiler
2021-08-10 13:23 ` Tom Rini
2021-09-11 12:16 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALeDE9ObPuECU3BU4BEF5UWYy_Gq-4a3jMR+jScmjpurq8=Q0Q@mail.gmail.com' \
--to=pbrobinson@gmail.com \
--cc=hws@denx.de \
--cc=matwey.kornilov@gmail.com \
--cc=paul.barker@sancloud.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.