From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 634E5C433EF for ; Wed, 1 Jun 2022 13:20:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241521AbiFANUM (ORCPT ); Wed, 1 Jun 2022 09:20:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351730AbiFANUL (ORCPT ); Wed, 1 Jun 2022 09:20:11 -0400 Received: from mail-vs1-xe2b.google.com (mail-vs1-xe2b.google.com [IPv6:2607:f8b0:4864:20::e2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1FF817AB1 for ; Wed, 1 Jun 2022 06:20:10 -0700 (PDT) Received: by mail-vs1-xe2b.google.com with SMTP id 67so1662771vsh.2 for ; Wed, 01 Jun 2022 06:20:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DgZG2k5iY1QuPAn8pQG0mjtLHqDtKgm2bTT3/22Hr9w=; b=TK/G4g6VZGZfTt+W/STmfWepHfUaE0pPunwMEOfelrqYKqjBFqCaNXNEBNKoKYXjmi 1e1EQuUv+ZRG8GlQxrvadscTBDPW6nVDI1USK2HSDJ+u1oEmiRYCdtktI0Ce0CY7K4i7 9f4aie61EQgEkzuEyDSMEjUOXUHXNqg7ZDLYVwncnBr7XzAvsakwqgKwWILNIC4fW27n ee5/U+d63h/AXhPRKRTdeFY46yGRoo+Y+KWEI+nksIIJ582FUnG01yqzxduxQH73frPd gczUlkDK7xuGtp/aqGZjtAdspvXzYk8bzQFEbtAv5mjWB8jpzm1mq0ppDf9QBpPi1Rh3 YNCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DgZG2k5iY1QuPAn8pQG0mjtLHqDtKgm2bTT3/22Hr9w=; b=a0PMqI+MO0IUz/5G/shhvGHFaxRU83SNEK7rTSYgv3iR0SoYEGbYQUYa4dNoOTIP4O Q8G+/K5BJF3dsISWFtfDmHabr0uv7I+KgClO/1OJABVUTfyMNKvNOcwYSNsEDCsSWO2s EQPZ3f/R2fshBaB+NOcDob6KgxA6QFHwfap7lJzCs2LQnqYr7bKwpyG/vNLnWyqzEauM /w7ZOZA5X0Ukud6rCc2txxAzWbzYx/oRw66du/OX2nAQSEMMMG6WRFp5z0dzBPNTJn5b Go90SnO1DjtjKI+7kBtFFzPx6cCxg5mcJ4PlDN700pCAcn3DEcuruW15kaaRdzaEgpFz SINg== X-Gm-Message-State: AOAM530Fy8kYst1pQAN5OL/KcUjt4qf3AzSaBoJDhK4Wk5Ulau2+e8Vf k6Q9FtqN1m51C/2fgYy3FubazegViTg9aFHUehg= X-Google-Smtp-Source: ABdhPJwXlJ2uSb2hauzCWZHhSZEaaP+75rcco5P113Wytg+sF5xLuBA8ITljvQ5bPChTxCrkL/eP288M7z5EY+vlj4o= X-Received: by 2002:a05:6102:3753:b0:337:8f39:f642 with SMTP id u19-20020a056102375300b003378f39f642mr22740375vst.52.1654089609807; Wed, 01 Jun 2022 06:20:09 -0700 (PDT) MIME-Version: 1.0 References: <20220601125344.60602-1-stefan.wahren@i2se.com> In-Reply-To: <20220601125344.60602-1-stefan.wahren@i2se.com> From: Peter Robinson Date: Wed, 1 Jun 2022 14:19:58 +0100 Message-ID: Subject: Re: [PATCH V2 00/11] soc: bcm2835-power: Prepare BCM2711 V3D support To: Stefan Wahren Cc: Florian Fainelli , Ray Jui , Scott Branden , Nicolas Saenz Julienne , Lee Jones , Melissa Wen , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, Maxime Ripard , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Stefan, So I've done some basic boot testing on a rpi4b, rpi4b 8gb, rpi400, rpi3b+ and rpi zero2w but all headless/remote, overall it looks good. I'm back home tomorrow when I can test the rpi4 series with the GPU patches on top with full desktop/display but overall this looks fab! Peter > This series is a split out of version 4 - Raspberry PI 4 V3D enablement send > by Peter Robinson [1]. It attemps to enable BCM2711 V3D support for the > power management driver. It's a rework of the less controversial changes > (excluding V3D GPU driver changes) so this can be reviewed and applied faster. > > Changes in V2: > - add Peter's Reviewed-by > - simplify schema for rpivid_asb as suggested by Rob > - fix reference and clarify fallback & error handling in patch #7 > - drop unnecessary newline in patch #9 > - improve log messages as noticed by Peter > > Changes since the mention series: > - fix DT schema errors > - make rpivid_asb register optional in DT schema > - avoid code duplication in BCM2835 ASB enable/disable > - rework ASB V3D handling so we don't need the V3D flag > - avoid log errors for optional register > - use a define for expected ASB_AXI_BRDG_ID result > - fix copy & paste issues in bcm2835-pm changes > > [1] - https://patchwork.kernel.org/project/linux-arm-kernel/cover/20220213225646.67761-1-pbrobinson@gmail.com/ > > Nicolas Saenz Julienne (6): > dt-bindings: soc: bcm: bcm2835-pm: Convert bindings to DT schema > dt-bindings: soc: bcm: bcm2835-pm: Introduce reg-names > ARM: dts: bcm2835/bcm2711: Introduce reg-names in watchdog node > ARM: dts: bcm2711: Use proper compatible in PM/Watchdog node > mfd: bcm2835-pm: Use 'reg-names' to get resources > soc: bcm: bcm2835-power: Bypass power_on/off() calls > > Stefan Wahren (5): > dt-bindings: soc: bcm: bcm2835-pm: Add support for bcm2711 > mfd: bcm2835-pm: Add support for BCM2711 > soc: bcm: bcm2835-power: Refactor ASB control > soc: bcm: bcm2835-power: Resolve ASB register macros > soc: bcm: bcm2835-power: Add support for BCM2711's RPiVid ASB > > .../bindings/soc/bcm/brcm,bcm2835-pm.txt | 46 ---------- > .../bindings/soc/bcm/brcm,bcm2835-pm.yaml | 86 +++++++++++++++++++ > arch/arm/boot/dts/bcm2711.dtsi | 3 +- > arch/arm/boot/dts/bcm2835-common.dtsi | 1 + > drivers/mfd/bcm2835-pm.c | 80 +++++++++++++---- > drivers/soc/bcm/bcm2835-power.c | 72 ++++++++++------ > include/linux/mfd/bcm2835-pm.h | 1 + > 7 files changed, 199 insertions(+), 90 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.txt > create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml > > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D82CC433F5 for ; Wed, 1 Jun 2022 13:21:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mCBJo7ki4YOO3bNZvnXH6txg00vyHDQKi2565000/Lc=; b=mvCCV6KwGj2xEM XBfeDuaX1YWYriuLYA2SjmiyECdduGSf8wS/+uY65/wkp9x8LJwc0vFtNCeWFHmajzWclioWOilAt igWgsqWZfgZ2fQxL34Pvo8wEEqRZPigK3UQ2BiXNVBMl1eCNbu/dlBPbf0KtYAxHRe54pAdq4JcsC lcODEdgvI0E3svymgQR8suKnzr+6513HmePJ7p04yYyZBLQjTs2nH7E+WKo8dyeJHV3D7lXT9ya3p mmlj72LGXv0gxckbEPBnW3zzwOLMaOJNoV0bv4S3raBg9ulrPKhUPxDUOIXjwtaWpvwY6XEkRAcm7 b7V525pAVXQoyTg4n3WQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwOGn-00GFEz-Lh; Wed, 01 Jun 2022 13:20:18 +0000 Received: from mail-vs1-xe35.google.com ([2607:f8b0:4864:20::e35]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwOGj-00GFBy-1G; Wed, 01 Jun 2022 13:20:14 +0000 Received: by mail-vs1-xe35.google.com with SMTP id m2so1643295vsr.8; Wed, 01 Jun 2022 06:20:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DgZG2k5iY1QuPAn8pQG0mjtLHqDtKgm2bTT3/22Hr9w=; b=TK/G4g6VZGZfTt+W/STmfWepHfUaE0pPunwMEOfelrqYKqjBFqCaNXNEBNKoKYXjmi 1e1EQuUv+ZRG8GlQxrvadscTBDPW6nVDI1USK2HSDJ+u1oEmiRYCdtktI0Ce0CY7K4i7 9f4aie61EQgEkzuEyDSMEjUOXUHXNqg7ZDLYVwncnBr7XzAvsakwqgKwWILNIC4fW27n ee5/U+d63h/AXhPRKRTdeFY46yGRoo+Y+KWEI+nksIIJ582FUnG01yqzxduxQH73frPd gczUlkDK7xuGtp/aqGZjtAdspvXzYk8bzQFEbtAv5mjWB8jpzm1mq0ppDf9QBpPi1Rh3 YNCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DgZG2k5iY1QuPAn8pQG0mjtLHqDtKgm2bTT3/22Hr9w=; b=vvlhZbhJoqLOkuxGiZyYylEfNxJBxrnEiXe6QRG0tSh3J3++x/rtCf7VO7mgDM/zGb 4RRp7mPZD/APpXcRA4ItkD4pYkDh18DMmUKjLVzDQG7CC/h683Gi5/RLBZtEc6aGuT5c D2LMJgMgwwbqHHGvdiHCPqGbuYyiQLi0MTXQS6vXECUQLwOhvYeJGxsSFkGpgADDkrEV 7i4g8gk2r9vR8tTqT3iJUsmadYuUM/E0MLZJ+aDi/iSE4Qtko6DwHi381JJJrCi+IzfT rCAqQB3N81y0BnxqHtYpRwHCK807tgHQMuP5RF8bIgK3Yshtx/JGIHPJB9JQKlhzWeZj rXGQ== X-Gm-Message-State: AOAM530Pz4i1imvNP2KQUhLaFFv6zIq8AcChL2qXTS7is+y9eLOfCVph tHQZkTccDdVJ6ZE6GYfrEK5F0Kt86TWjdMFxLYA= X-Google-Smtp-Source: ABdhPJwXlJ2uSb2hauzCWZHhSZEaaP+75rcco5P113Wytg+sF5xLuBA8ITljvQ5bPChTxCrkL/eP288M7z5EY+vlj4o= X-Received: by 2002:a05:6102:3753:b0:337:8f39:f642 with SMTP id u19-20020a056102375300b003378f39f642mr22740375vst.52.1654089609807; Wed, 01 Jun 2022 06:20:09 -0700 (PDT) MIME-Version: 1.0 References: <20220601125344.60602-1-stefan.wahren@i2se.com> In-Reply-To: <20220601125344.60602-1-stefan.wahren@i2se.com> From: Peter Robinson Date: Wed, 1 Jun 2022 14:19:58 +0100 Message-ID: Subject: Re: [PATCH V2 00/11] soc: bcm2835-power: Prepare BCM2711 V3D support To: Stefan Wahren Cc: Florian Fainelli , Ray Jui , Scott Branden , Nicolas Saenz Julienne , Lee Jones , Melissa Wen , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, Maxime Ripard , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_062013_183060_6FE47FE5 X-CRM114-Status: GOOD ( 19.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stefan, So I've done some basic boot testing on a rpi4b, rpi4b 8gb, rpi400, rpi3b+ and rpi zero2w but all headless/remote, overall it looks good. I'm back home tomorrow when I can test the rpi4 series with the GPU patches on top with full desktop/display but overall this looks fab! Peter > This series is a split out of version 4 - Raspberry PI 4 V3D enablement send > by Peter Robinson [1]. It attemps to enable BCM2711 V3D support for the > power management driver. It's a rework of the less controversial changes > (excluding V3D GPU driver changes) so this can be reviewed and applied faster. > > Changes in V2: > - add Peter's Reviewed-by > - simplify schema for rpivid_asb as suggested by Rob > - fix reference and clarify fallback & error handling in patch #7 > - drop unnecessary newline in patch #9 > - improve log messages as noticed by Peter > > Changes since the mention series: > - fix DT schema errors > - make rpivid_asb register optional in DT schema > - avoid code duplication in BCM2835 ASB enable/disable > - rework ASB V3D handling so we don't need the V3D flag > - avoid log errors for optional register > - use a define for expected ASB_AXI_BRDG_ID result > - fix copy & paste issues in bcm2835-pm changes > > [1] - https://patchwork.kernel.org/project/linux-arm-kernel/cover/20220213225646.67761-1-pbrobinson@gmail.com/ > > Nicolas Saenz Julienne (6): > dt-bindings: soc: bcm: bcm2835-pm: Convert bindings to DT schema > dt-bindings: soc: bcm: bcm2835-pm: Introduce reg-names > ARM: dts: bcm2835/bcm2711: Introduce reg-names in watchdog node > ARM: dts: bcm2711: Use proper compatible in PM/Watchdog node > mfd: bcm2835-pm: Use 'reg-names' to get resources > soc: bcm: bcm2835-power: Bypass power_on/off() calls > > Stefan Wahren (5): > dt-bindings: soc: bcm: bcm2835-pm: Add support for bcm2711 > mfd: bcm2835-pm: Add support for BCM2711 > soc: bcm: bcm2835-power: Refactor ASB control > soc: bcm: bcm2835-power: Resolve ASB register macros > soc: bcm: bcm2835-power: Add support for BCM2711's RPiVid ASB > > .../bindings/soc/bcm/brcm,bcm2835-pm.txt | 46 ---------- > .../bindings/soc/bcm/brcm,bcm2835-pm.yaml | 86 +++++++++++++++++++ > arch/arm/boot/dts/bcm2711.dtsi | 3 +- > arch/arm/boot/dts/bcm2835-common.dtsi | 1 + > drivers/mfd/bcm2835-pm.c | 80 +++++++++++++---- > drivers/soc/bcm/bcm2835-power.c | 72 ++++++++++------ > include/linux/mfd/bcm2835-pm.h | 1 + > 7 files changed, 199 insertions(+), 90 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.txt > create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml > > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel