From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45E64C433EF for ; Tue, 31 May 2022 16:04:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245517AbiEaQEC (ORCPT ); Tue, 31 May 2022 12:04:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242921AbiEaQEB (ORCPT ); Tue, 31 May 2022 12:04:01 -0400 Received: from mail-vk1-xa2e.google.com (mail-vk1-xa2e.google.com [IPv6:2607:f8b0:4864:20::a2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6912BB7CC for ; Tue, 31 May 2022 09:04:00 -0700 (PDT) Received: by mail-vk1-xa2e.google.com with SMTP id e7so6418646vkh.2 for ; Tue, 31 May 2022 09:04:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gOWGZ54Al2hYu3BS8nrZ/b/4ZfhEYozFQpu4yx8zHv8=; b=l/Q/jEiIJfXqLNDJeAhVKrBzUIj+Dcl+edW30x1gpxS38VH/lAFYdpy6xgnwzMX82B jdUaN+pIq3tI8zxInWwlvOYEl3nSYMsFr2z8kMvXa3OcEsjaZyesSZYLM+CZDt4UZIp9 D4INyKhQilDmnE5U1JBXRzjUNr7ByZaF7kuQ1QQqio/uHcO4M9Y0CGirdVjxVQY6gS7i nlZjMskY38kxUjBNCBR8/HMMqbQ/ATvgSDAsQm6eXexrzU8LDpGclqKiYuSJTLhLdv8p vyvnXmTzRwtG0c684NrzqYj4qS0U+VAkThxryLBsuiqfxiOKK2rwfd16gmr2GbBDlv9g cBLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gOWGZ54Al2hYu3BS8nrZ/b/4ZfhEYozFQpu4yx8zHv8=; b=Est3P3rBc/cAE1nOpul3lqJNxzH15lu1WhR9BD1l12QpuDCvqKDgQs1fidsxQifgde VWocqMy9h1fe+81v8mTT+X8MUU8vvNR+ge2jXwQ7XEKtbvXUsMkRj0jCZJVmlRj2yzK1 4jZkc7uhkZcWRgkYXUNYlHbhXHwV44i3KKAI4hXMhg/6tj+OuZR5mPDLpxZ6VCGZbSMu zCkFPlWVf/Gh7dHpYSxMg/KI8KkF+AZbZWPi4CtVDUjOs5bOZyJAy0paBSD3Wwnddn+f WxNSF0iOOL2hKgRA4grLroH68pd4dAETXt6oEfoxvgrtQZ3ctxTpbQ3HZRiCTJvCC9T4 1JSw== X-Gm-Message-State: AOAM532teNn30PV3oSCLsw2abUwqvaBgtFo6jSf0wX4rtmuvAYiwmbeM BaaYbuO4ybV8bJRh0O8TitOTy+DH0TS9hDlGG0w= X-Google-Smtp-Source: ABdhPJz1KmtMV/3yeWAM20xo0vyxz9unJebLtHSGSm0TnfqfR+jEEyzU75jhFBvyLlEZsmrnRSTKKMCmBj/lnUpMRjg= X-Received: by 2002:a1f:a8c4:0:b0:357:7163:60ac with SMTP id r187-20020a1fa8c4000000b00357716360acmr18493801vke.18.1654013039533; Tue, 31 May 2022 09:03:59 -0700 (PDT) MIME-Version: 1.0 References: <20220515202032.3046-1-stefan.wahren@i2se.com> <20220515202032.3046-12-stefan.wahren@i2se.com> In-Reply-To: <20220515202032.3046-12-stefan.wahren@i2se.com> From: Peter Robinson Date: Tue, 31 May 2022 17:03:47 +0100 Message-ID: Subject: Re: [PATCH 11/11] soc: bcm: bcm2835-power: Bypass power_on/off() calls To: Stefan Wahren Cc: Florian Fainelli , Ray Jui , Scott Branden , Nicolas Saenz Julienne , Lee Jones , Melissa Wen , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, Maxime Ripard , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Nicolas Saenz Julienne Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, May 15, 2022 at 9:21 PM Stefan Wahren wrote: > > From: Nicolas Saenz Julienne > > Bypass power_on/power_off() when running on BCM2711 as they are not > needed. > > Signed-off-by: Nicolas Saenz Julienne > Signed-off-by: Stefan Wahren Reviewed-by: Peter Robinson > --- > drivers/soc/bcm/bcm2835-power.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/soc/bcm/bcm2835-power.c b/drivers/soc/bcm/bcm2835-power.c > index 1e06d91c0739..5bcd047768b6 100644 > --- a/drivers/soc/bcm/bcm2835-power.c > +++ b/drivers/soc/bcm/bcm2835-power.c > @@ -198,6 +198,10 @@ static int bcm2835_power_power_off(struct bcm2835_power_domain *pd, u32 pm_reg) > { > struct bcm2835_power *power = pd->power; > > + /* We don't run this on BCM2711 */ > + if (power->rpivid_asb) > + return 0; > + > /* Enable functional isolation */ > PM_WRITE(pm_reg, PM_READ(pm_reg) & ~PM_ISFUNC); > > @@ -219,6 +223,10 @@ static int bcm2835_power_power_on(struct bcm2835_power_domain *pd, u32 pm_reg) > int inrush; > bool powok; > > + /* We don't run this on BCM2711 */ > + if (power->rpivid_asb) > + return 0; > + > /* If it was already powered on by the fw, leave it that way. */ > if (PM_READ(pm_reg) & PM_POWUP) > return 0; > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D79D1C433F5 for ; Tue, 31 May 2022 16:05:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kUshsUcu12Qvaf2BRPOQPl6WJjZSwVe9LZ/ducnBH40=; b=QIn9tPpIiYCsy+ Gli20i6Io/p2ZNwOLuQ+IlfkaXgM+FhzUqa2Bi4NRhIEF3/k6btZuT35nzbG5+TDhEQRM7gFrbJ+w 9PX24zmoTTtKCsS+ZLpfp4LAQTSqfV2uCO4Ce3wFhsSCAUH2LGDdcYeDBOs7+22AywYhba3U7s6Xc VipXQQrGbLlPRSyosE7tRAp4dGawl7ZRq/McvbsTfP0qYnhD9Y3Uxq/ULjpSRiTx8ztM15nQYjqGX SEsDI0grSBvMLaFMyXz4CImHTq9wjVY44ldUEECvzQljMlhbaWe6EDap3HG8kVxAkvaMnbejHJE0f 6ULEh9OQ7MRLDxDqGxKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw4Ll-00BhiA-HN; Tue, 31 May 2022 16:04:05 +0000 Received: from mail-vk1-xa2f.google.com ([2607:f8b0:4864:20::a2f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw4Li-00BhZE-JA; Tue, 31 May 2022 16:04:03 +0000 Received: by mail-vk1-xa2f.google.com with SMTP id x11so6400819vkn.11; Tue, 31 May 2022 09:04:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gOWGZ54Al2hYu3BS8nrZ/b/4ZfhEYozFQpu4yx8zHv8=; b=l/Q/jEiIJfXqLNDJeAhVKrBzUIj+Dcl+edW30x1gpxS38VH/lAFYdpy6xgnwzMX82B jdUaN+pIq3tI8zxInWwlvOYEl3nSYMsFr2z8kMvXa3OcEsjaZyesSZYLM+CZDt4UZIp9 D4INyKhQilDmnE5U1JBXRzjUNr7ByZaF7kuQ1QQqio/uHcO4M9Y0CGirdVjxVQY6gS7i nlZjMskY38kxUjBNCBR8/HMMqbQ/ATvgSDAsQm6eXexrzU8LDpGclqKiYuSJTLhLdv8p vyvnXmTzRwtG0c684NrzqYj4qS0U+VAkThxryLBsuiqfxiOKK2rwfd16gmr2GbBDlv9g cBLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gOWGZ54Al2hYu3BS8nrZ/b/4ZfhEYozFQpu4yx8zHv8=; b=Yqnp1RwONo61n/fwkEEP05ztaWuAoz+5tti0JeFvThM8rGFYI20MYs9kBnfpWx/+Cf PoDoBhwsQjz6SQHYGiyYYMLTeAb97qlLRw+riEI/CfkOVN5WAwIrIH6/PgXrEXzGMD0M qI3tSiam7gOCq6qJAfLTYYoZTWTVa0ybI2UaQC8o8aybbo3uke9eCVAC0fw9o4XClAT1 y1kdwWF0Qhea40S2UxrAPUolhHtKe0UG0CUwqTxfJDrYp5qKSwHuQlFXjUc2ivfjUfuk qZijROK+KVoUAiTCr0GI+JV7Zm75+7AHzKyeRxZeflE6XWAsPUKEV5pxQHs0I3E2ZE41 0xxw== X-Gm-Message-State: AOAM531R1WhgYNFRho4/yaM1jxcilW0l/LS6Aez/odCbTggSpbt/mJHb wc6YHmBxJhxfqsq+UxCp+97RiNQcvj2hOY3aQoU= X-Google-Smtp-Source: ABdhPJz1KmtMV/3yeWAM20xo0vyxz9unJebLtHSGSm0TnfqfR+jEEyzU75jhFBvyLlEZsmrnRSTKKMCmBj/lnUpMRjg= X-Received: by 2002:a1f:a8c4:0:b0:357:7163:60ac with SMTP id r187-20020a1fa8c4000000b00357716360acmr18493801vke.18.1654013039533; Tue, 31 May 2022 09:03:59 -0700 (PDT) MIME-Version: 1.0 References: <20220515202032.3046-1-stefan.wahren@i2se.com> <20220515202032.3046-12-stefan.wahren@i2se.com> In-Reply-To: <20220515202032.3046-12-stefan.wahren@i2se.com> From: Peter Robinson Date: Tue, 31 May 2022 17:03:47 +0100 Message-ID: Subject: Re: [PATCH 11/11] soc: bcm: bcm2835-power: Bypass power_on/off() calls To: Stefan Wahren Cc: Florian Fainelli , Ray Jui , Scott Branden , Nicolas Saenz Julienne , Lee Jones , Melissa Wen , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, Maxime Ripard , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Nicolas Saenz Julienne X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220531_090402_669693_DD2662EA X-CRM114-Status: GOOD ( 19.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, May 15, 2022 at 9:21 PM Stefan Wahren wrote: > > From: Nicolas Saenz Julienne > > Bypass power_on/power_off() when running on BCM2711 as they are not > needed. > > Signed-off-by: Nicolas Saenz Julienne > Signed-off-by: Stefan Wahren Reviewed-by: Peter Robinson > --- > drivers/soc/bcm/bcm2835-power.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/soc/bcm/bcm2835-power.c b/drivers/soc/bcm/bcm2835-power.c > index 1e06d91c0739..5bcd047768b6 100644 > --- a/drivers/soc/bcm/bcm2835-power.c > +++ b/drivers/soc/bcm/bcm2835-power.c > @@ -198,6 +198,10 @@ static int bcm2835_power_power_off(struct bcm2835_power_domain *pd, u32 pm_reg) > { > struct bcm2835_power *power = pd->power; > > + /* We don't run this on BCM2711 */ > + if (power->rpivid_asb) > + return 0; > + > /* Enable functional isolation */ > PM_WRITE(pm_reg, PM_READ(pm_reg) & ~PM_ISFUNC); > > @@ -219,6 +223,10 @@ static int bcm2835_power_power_on(struct bcm2835_power_domain *pd, u32 pm_reg) > int inrush; > bool powok; > > + /* We don't run this on BCM2711 */ > + if (power->rpivid_asb) > + return 0; > + > /* If it was already powered on by the fw, leave it that way. */ > if (PM_READ(pm_reg) & PM_POWUP) > return 0; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel