From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02B7BC2B9F7 for ; Tue, 25 May 2021 02:21:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4FCD61005 for ; Tue, 25 May 2021 02:21:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4FCD61005 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llMhN-0001eM-Qf for qemu-devel@archiver.kernel.org; Mon, 24 May 2021 22:21:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llMaL-0004mw-RB for qemu-devel@nongnu.org; Mon, 24 May 2021 22:14:21 -0400 Received: from mail-ot1-x32c.google.com ([2607:f8b0:4864:20::32c]:40758) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llMaK-0007ww-1O for qemu-devel@nongnu.org; Mon, 24 May 2021 22:14:21 -0400 Received: by mail-ot1-x32c.google.com with SMTP id 80-20020a9d08560000b0290333e9d2b247so16602320oty.7 for ; Mon, 24 May 2021 19:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tRdupmYsQzIeY2HHVoYX0T08hhLSzqt3U9JZdyCWf7o=; b=N3x7+R42XBywKU+XErEnIPTZppYiFMPj7kYBVIWyMxSRQYrheePVFqDV5PPmJI1UOx gQNyiLteWkvkps07CXjHW6kf5qvT5WN6Bb8Tc9DXry4YgJV0lXgy0gT+uegXqrtywqcr QaYLtYdGAQJFMkZ+NewUHiLIB1W43cXYDt91ig7ZUDxH8LUleureBA0FBQpJD2SMcAgb UNHrXjck4Z31Vhs/wXET3c6iFig1Ye/7L4gnnY6EOMnQbZVhfrbhwSsjt4KrgsnokZBp A1p6Q7OmxMou3guqNoPgxoR8ozWTLD8a4osGPPz0/K7s54GT57TjMcJOIbmll3ms7sRB J0NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tRdupmYsQzIeY2HHVoYX0T08hhLSzqt3U9JZdyCWf7o=; b=gmnfcVwOm2cwSBStOcwW7XAQREwYKWWJLjYo3mmLjPudOcKddotPk0ywOQheEk+yJY Sr8QXEsFlfZb3UBCFZENIJ4yVs7M5Dyk1F1h/qXnwq3pK9fKk9r2v65fxO3nRIGIqd9P wWRSimzyPGsnlZ8oLoYm2LelM7VX893Vw55gtX7v4J+0C5Q7E0PgleR6idN5VHRojVA8 YtPpDrWhmsCjYFW4s76kSRjrqTChsopNl8O1fFPQg1UlAhZk5CjLjNfssBxYLmV6zQqa wTokKNda8qq7EeUdw5tm93AxjFK57yWZRelPIjmBZh9IOW0IYaid6rRQtdU7DI9nRDl1 emyg== X-Gm-Message-State: AOAM532Te8ExAXANGolUcEvrspbWiI1A52LCZn83nvWBPBz1dX2nhfgh 8QI03W+HDoHmEp+02dLcOv4jaTsuWYAkZao+XT0= X-Google-Smtp-Source: ABdhPJz7laZ3EdRYcbNw5gGyMw+CRakubNxo7A1Az5jF5Saln+F6PlRBYYPjxCKHQESFNMYzK4y1EoCpgrkRk3c9iQQ= X-Received: by 2002:a05:6830:2684:: with SMTP id l4mr20026451otu.294.1621908858486; Mon, 24 May 2021 19:14:18 -0700 (PDT) MIME-Version: 1.0 References: <20210524225608.3191809-1-swethajoshi139@gmail.com> <8fbdab13-ed0e-047a-7a67-2e30471a46b1@linaro.org> In-Reply-To: <8fbdab13-ed0e-047a-7a67-2e30471a46b1@linaro.org> From: Swetha Joshi Date: Mon, 24 May 2021 19:14:08 -0700 Message-ID: Subject: Re: [PATCH] Adding ifdefs to call the respective routines only when their configs are enabled To: Richard Henderson Content-Type: multipart/alternative; boundary="0000000000005e439205c31e15a7" Received-SPF: pass client-ip=2607:f8b0:4864:20::32c; envelope-from=swethajoshi139@gmail.com; helo=mail-ot1-x32c.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Swetha , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000005e439205c31e15a7 Content-Type: text/plain; charset="UTF-8" Hey Richard, I think I submitted the wrong patch, sorry about that. I will go ahead and submit the correct commit id now. What I was trying to do was, when kvm is enabled and if we don't want to include CONFIG_ARM_VIRT or CONFIG_ACPI_APEI, compilation fails as virt_is_acpi_enabled() routine is defined in virt.h and acpi_ghes_record_errors() is defined in ghes.h. ~ Swetha On Mon, May 24, 2021 at 6:53 PM Richard Henderson < richard.henderson@linaro.org> wrote: > On 5/24/21 3:56 PM, Swetha Joshi wrote: > > From: Swetha > > > > Signed-off-by: Swetha > > What are you trying to accomplish? > That's what belongs in the commit message that you omitted. > > > + bool acpi_enabled = false; > > +#ifdef CONFIG_ARM_VIRT > > bool acpi_enabled = virt_is_acpi_enabled(vms); > > Of course this doesn't compile, having declared acpi_enabled twice. So > you > have clearly not tested this patch sufficiently. > > The cc to qemu-trivial is unwarranted. > > > r~ > -- Regards Swetha Joshi. --0000000000005e439205c31e15a7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hey Richard,=C2=A0

I think I submitted= =C2=A0the wrong patch, sorry about that. I will go ahead and submit the cor= rect commit id now. What I was trying to do was, when kvm is enabled=C2=A0a= nd if we don't want to include=C2=A0= CONFIG_ARM_VIRT or CONFIG_ACPI_APEI, compilation fails as virt_is_acpi_enab= led() routine is defined in virt.h and acpi_ghes_record_errors() is defined= in ghes.h.

=
~ Swetha
On Mon, = May 24, 2021 at 6:53 PM Richard Henderson <richard.henderson@linaro.org> wrote:
On 5/24/21 3:56 PM, Swetha J= oshi wrote:
> From: Swetha <swjoshi@microsoft.com>
>
> Signed-off-by: Swetha <swjoshi@microsoft.com>

What are you trying to accomplish?
That's what belongs in the commit message that you omitted.

> +=C2=A0 =C2=A0 bool acpi_enabled =3D false;
> +#ifdef CONFIG_ARM_VIRT
>=C2=A0 =C2=A0 =C2=A0 =C2=A0bool acpi_enabled =3D virt_is_acpi_enabled(v= ms);

Of course this doesn't compile, having declared acpi_enabled twice.=C2= =A0 So you
have clearly not tested this patch sufficiently.

The cc to qemu-trivial is unwarranted.


r~


--
Regards

Swet= ha Joshi.
--0000000000005e439205c31e15a7--