From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: ** X-Spam-Status: No, score=2.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9601C47082 for ; Wed, 26 May 2021 17:58:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57BD5613D2 for ; Wed, 26 May 2021 17:58:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57BD5613D2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llxnZ-000251-FU for qemu-devel@archiver.kernel.org; Wed, 26 May 2021 13:58:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49878) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llxOs-00009z-RX; Wed, 26 May 2021 13:33:03 -0400 Received: from mail-oi1-x235.google.com ([2607:f8b0:4864:20::235]:33618) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llxOo-0001OB-FX; Wed, 26 May 2021 13:32:58 -0400 Received: by mail-oi1-x235.google.com with SMTP id b25so2306647oic.0; Wed, 26 May 2021 10:32:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MHDjWt30kfTo7P1kTFosF2FYBb6vy0T0nTwkFqadCB4=; b=Jp2dEGrSNiQittVBMJs8fuZcufSgLqhcq+/OfxcFjogovBvNwDNOB3V+XTrhc1vkmt jXwJot96YWXSmV+xlEvePk1M/0hxuHaaEBepVfFZxy//5vqKpktSzb7rKvT7qo2IxQ5H enYlIAuuNnkoOAyKhrIlrILUd7KSZKLZBJsDQ3DbOTqzpWbUbqxaekm34mIKec0yJert q1AiyW6aILrmWDctFM4ZSiCDSnPCf+xHRLn8KUb7qAw8Exrys/b5VtQoytKbFz/cU+0S eYGdwagH2CsQmIYnCQJn18FNG4EqAJwBjxM9H0d1+k2BqyvmegbsFdtcAA5QgTqNG+sn taRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MHDjWt30kfTo7P1kTFosF2FYBb6vy0T0nTwkFqadCB4=; b=lVFIJyaL/cN1tASwr5sShsVUPfe38ODyz2e0EWx/EFFK/8kH7YH2Aq8mz10sRZ5iWg 2XIVolQwEEJ4YyRYnaAlGI4mBCgZNbJtmr2+XZ6bD46/hh1+5jQ6nCMuERbN8/1Zp4zh zLWrX82ILJSgeqXHkhLwFQPkgJ2tSAbg0foqAA7Op0Kr/WTTO8mr4RDN0d57LQZqidfU 9S8j8uGDUzSPWjEMiB6ITt+HniGUiVtdMkL8SyTyCtZgdWU/Rd5yDE4svyZg5R184JcC CBUuX6fMT4kYywRfzX5A+Gx/C0i14uh2g2GM9TaZfMpsOdR49l4jdzPZOXqdQGovUN3L owsg== X-Gm-Message-State: AOAM530IrMpWh/GU/dNScUX2YIpEmIcSL/e3ey+S3z4/FDJ3kmnpqD4b MwHYyas74dKugobbxx2vGSWnlvk26YId8vG9JpE= X-Google-Smtp-Source: ABdhPJzKRsJR/mbMGkiCtopfOQf9W/gqe95X0l7q2y4f1K8w4LpmcIi9jeONDTc2WEgyXi/2sprZ+mDG3bndMbm08cM= X-Received: by 2002:aca:2417:: with SMTP id n23mr2682344oic.111.1622050366786; Wed, 26 May 2021 10:32:46 -0700 (PDT) MIME-Version: 1.0 References: <20210525025823.3208218-1-swethajoshi139@gmail.com> <331a819e-1745-4d4b-cc4a-82521a58186a@linaro.org> In-Reply-To: From: Swetha Joshi Date: Wed, 26 May 2021 10:32:36 -0700 Message-ID: Subject: Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled To: Peter Maydell Content-Type: multipart/alternative; boundary="000000000000eb8f7d05c33f07f7" Received-SPF: pass client-ip=2607:f8b0:4864:20::235; envelope-from=swethajoshi139@gmail.com; helo=mail-oi1-x235.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , Dongjiu Geng , Richard Henderson , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000eb8f7d05c33f07f7 Content-Type: text/plain; charset="UTF-8" Hello, One of the qemu machines we use has KVM enabled, but we don't want the CONFIG_ARM_VIRT enabled as it pulls in emulation of a variety of physical hardware that we don't need. The compilation errors I mentioned are not in the qemu mainline per say but we see them in one of the qemu derived machines we use. Thanks, Swetha. On Tue, May 25, 2021 at 10:16 AM Peter Maydell wrote: > On Tue, 25 May 2021 at 17:28, Swetha Joshi > wrote: > > > > Hey Peter, Phil, > > > > Yeah like Peter mentioned, when KVM is enabled and we don't want VIRT > enabled, there are a couple of routines that are being called from virt.h > and ghes.h, which is resulting in errors. I came up with this simple fix > but if you think there is a better solution to it I'll let you/ other > developers who own it decide and fix it because I don't have much > experience or visibility into what happens internally, my knowledge is > restricted to just using the configs. > > Well, QEMU builds fine for me as-is, because the default config > always enables the virt board. Do you have repro instructions for > reproducing the build failure ? > > thanks > -- PMM > -- Regards Swetha Joshi. --000000000000eb8f7d05c33f07f7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

One of the qemu machines we use = has KVM enabled, but we don't want the CONFIG_ARM_VIRT enabled as it pu= lls in emulation of a variety of physical hardware that we don't need. = The compilation errors I mentioned are not in the qemu mainline per say but= we see them in one of the qemu derived machines we use.=C2=A0

Thanks,
Swetha.

On Tue, May 25, 2021 at 10:16 A= M Peter Maydell <peter.mayde= ll@linaro.org> wrote:
On Tue, 25 May 2021 at 17:28, Swetha Joshi <swethajoshi139@gmail.com= > wrote:
>
> Hey Peter, Phil,
>
> Yeah like Peter mentioned, when KVM is enabled and we don't want V= IRT enabled, there are a couple of routines that are being called from virt= .h and ghes.h, which is resulting in errors. I came up with this simple fix= but if you think there is a better solution to it I'll let you/ other = developers who own it decide and fix it because I don't have much exper= ience or visibility into what happens internally, my knowledge is restricte= d to just using the configs.

Well, QEMU builds fine for me as-is, because the default config
always enables the virt board. Do you have repro instructions for
reproducing the build failure ?

thanks
-- PMM


--
Regards

Swet= ha Joshi.
--000000000000eb8f7d05c33f07f7--