From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: ** X-Spam-Status: No, score=2.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8695BC47083 for ; Fri, 4 Jun 2021 05:26:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1E4761413 for ; Fri, 4 Jun 2021 05:26:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1E4761413 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57586 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lp2M1-0004iN-Tn for qemu-devel@archiver.kernel.org; Fri, 04 Jun 2021 01:26:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59192) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lp2LQ-0003mN-Jm; Fri, 04 Jun 2021 01:26:08 -0400 Received: from mail-ot1-x32f.google.com ([2607:f8b0:4864:20::32f]:45880) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lp2LO-0000W8-NE; Fri, 04 Jun 2021 01:26:08 -0400 Received: by mail-ot1-x32f.google.com with SMTP id t10-20020a05683022eab0290304ed8bc759so7993787otc.12; Thu, 03 Jun 2021 22:26:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y7hs2ThLCcd4EXAQewgtqhiDgTLsjP/tp3SDQW/lQQA=; b=egaioL8n4oRhwvu4OQmstqy/u8mgm2IB9K2QN6UntckxP+4Rltc37QNfbBCuWgdkL/ z1QOgNbo3JDVGvmSZgxaBWJ+RFSbzmwqLcyNIZZcac9+522yew+qocQII5UanvNPge7G uSKVU+4oUnz7mbNMrtzMDMazfjF5x9le0xhCWYdBHMfY7LgSYjHKj+sg/XABRhdS/XP+ TePUl4i/RDvDS9A9Sj5qY83zcvLAwiR7X/qzBOCYy5lhEIWA+oLHIgqIr6co58SjD/3g YE4yzjRuNxt1gmzRmlP1MHojb2MDwzicLGN3tL93p6gs2yLJJt7U84pEdHwQBzPaGFJN FaCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y7hs2ThLCcd4EXAQewgtqhiDgTLsjP/tp3SDQW/lQQA=; b=TD1A3EJXL5BDQWqpTC0wRyr+Wtc7chKMBNVAnEx0dZICaDuy1x0VBx7/BWAVA9gN/B wNUKx3/R7JBAKA2xTpIxf9XX08fsY6zOedaCKFx35X7BbeHb4BB0pXBYXMkDjHh2AxVT 4NDZ4THv7ysIrFWbUcrl114r/2Uaq39Yig08UFBo+CuDbSGzltJEl9mzeo5GGfPkRLiA ieB/TRClGRM4jRUNzPxMYG8dT+ETCOg9lF4vcXIoURwDcgggR80LQ00MWvrL+A79uIMk EOtE6zO4qtTC9867PtO56MDrEQWZCxToQ7hAvoDFXcBh75Su07cg53wJ3QYVMOmto/wJ Tsgg== X-Gm-Message-State: AOAM533buznDxdb6JaJ75UE2siqRQrL7cUfya/sUy/cVh+xZVHvZm+OY 3uma08vEr7HeDx5iMO/C9a4SrT0gCflK294EXO8= X-Google-Smtp-Source: ABdhPJwVpIRTzGWVubOKbFFzOWFPbb7Zb4XP9+a7R5IsbpYMV7x2wyEdUw6qMMQ4ICrZD6zjiwguTtXlYYNIybgO1k0= X-Received: by 2002:a9d:554b:: with SMTP id h11mr2347232oti.4.1622784364724; Thu, 03 Jun 2021 22:26:04 -0700 (PDT) MIME-Version: 1.0 References: <20210525025823.3208218-1-swethajoshi139@gmail.com> <331a819e-1745-4d4b-cc4a-82521a58186a@linaro.org> In-Reply-To: From: Swetha Joshi Date: Thu, 3 Jun 2021 22:25:53 -0700 Message-ID: Subject: Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled To: Peter Maydell Content-Type: multipart/alternative; boundary="0000000000009b438505c3e9ed69" Received-SPF: pass client-ip=2607:f8b0:4864:20::32f; envelope-from=swethajoshi139@gmail.com; helo=mail-ot1-x32f.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , Dongjiu Geng , Richard Henderson , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000009b438505c3e9ed69 Content-Type: text/plain; charset="UTF-8" Hello, I have tested this patch with our qemu and it works, thank you. What are the next steps for this patch? So is it approved and ready to go in mainline? Thanks, Swetha. On Thu, Jun 3, 2021 at 10:30 AM Swetha Joshi wrote: > > Oh okay, thank you. I will test this by eod today! > > > On Thu, Jun 3, 2021 at 10:22 AM Peter Maydell > wrote: > >> On Fri, 28 May 2021 at 20:41, Swetha Joshi >> wrote: >> > >> > I apologize for the delay, here are the repro steps: >> > 1. Remove CONFIG_ARM_VIRT=y from arm-softmmu.mak >> > 2. In .gitlab-ci.yml, crossbuild.yml and in tests/vm/Makefile.include, >> in all the places where we disable kvm using -disable-kvm, replace this >> with -enable-kvm >> > 3. Build >> >> Thanks; I reproduced the link errors and have sent a patchset >> that I hope fixes this: >> https://patchew.org/QEMU/20210603171259.27962-1-peter.maydell@linaro.org/ >> >> If you could test that it works for you that would be great. >> >> -- PMM >> > -- > Regards > > Swetha Joshi. > -- Regards Swetha Joshi. --0000000000009b438505c3e9ed69 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello, I have tested this patch with our qemu and it work= s, thank you.

What are t= he next steps for this patch? So is it approved and ready to go in mainline= ?

Thanks,
Swetha.=C2=A0

On Thu, Jun 3, 2021 at 10:30 AM Swetha Joshi = <swethajoshi139@gmail.com> wrote:



<= div dir=3D"ltr" class=3D"gmail_attr">On Thu, Jun 3, 2021 at 10:22 AM Peter = Maydell <p= eter.maydell@linaro.org> wrote:
On Fri, 28= May 2021 at 20:41, Swetha Joshi <swethajoshi139@gmail.com> wrote:
>
> I apologize for the delay, here are the repro steps:
> 1. Remove CONFIG_ARM_VIRT=3Dy from arm-softmmu.mak
> 2. In .gitlab-ci.yml, crossbuild.yml and in tests/vm/Makefile.include,= in all the places where we disable kvm using -disable-kvm, replace this wi= th -enable-kvm
> 3. Build

Thanks; I reproduced the link errors and have sent a patchset
that I hope fixes this:
https://patchew.org/QEMU/20= 210603171259.27962-1-peter.maydell@linaro.org/

If you could test that it works for you that would be great.

-- PMM
--
Regards

Swetha Joshi.
--
Regards

<= div>Swetha Joshi.
--0000000000009b438505c3e9ed69--