From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E113C2B9F7 for ; Tue, 25 May 2021 03:14:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D6636109F for ; Tue, 25 May 2021 03:14:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230202AbhEYDQF (ORCPT ); Mon, 24 May 2021 23:16:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229575AbhEYDQD (ORCPT ); Mon, 24 May 2021 23:16:03 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EDEBC061574 for ; Mon, 24 May 2021 20:14:33 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id f22so14116349pfn.0 for ; Mon, 24 May 2021 20:14:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VHDFyefEfXv2T1h/kXDPOn5vVw8tSm/6FW05x+E2j40=; b=merHIeKNi5Uu6C9TAUujDNIN9FxrI34YUx7aW4WyFELIyYppIt99C4UwGvzWaArcmu 9EaYZFbnrmtDjrMZ7c8349ke6DKJjWiZDCUD5epOu2PqMIr5kYM1CoXZ0XNE1vQ3QFiu bvf2bDyHaIMES3MNNrHcengJbyjgwpDl3VY20= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VHDFyefEfXv2T1h/kXDPOn5vVw8tSm/6FW05x+E2j40=; b=OIUM560ny21fq3bz5DWNWzQSeemTE0E6CC1OsaMe1xKqfwFWaqBFwYqZTxY84+iukh JZV2UR5TKueLpe0lKRNbhL7md0oXzQ0avjLdx4M/L9zDg5pxwOLqQovUBdedpQfqTZBx Ot0gUXsmY8Lyth3SSUoFuJcEh/OZUbp5NHn8lKJ52jti+BlRheMy+zr7ZvDDNwuyJKiJ C/yVu6qMi3dqURBq00sunjkFIJrKju9JVLYu1TrsCwSkqs6Jo2SkftDn0yONyrVAf2bE IOW7jhbbRIMNLvqkCpNDubr4riYSDnDNWE7GIoi5gaHvYzAFPBXPwhYmTowzaY4gcO4O +rYA== X-Gm-Message-State: AOAM531Ba8GoNOMslyF0kgMWaH6R9RgcT/ewQsbWwI1p9DNRBybBK/N0 cTzAjiy01atoAw/03T7K124F4NFf0AZi4g== X-Google-Smtp-Source: ABdhPJzuhKdvJqUXCOuHlCsXM4G4Sm+eqP3OarxJhBAKiQ8DAECPx6Zr1RE6gFiurEyPwzyvJJurGg== X-Received: by 2002:a63:d213:: with SMTP id a19mr16945969pgg.28.1621912472413; Mon, 24 May 2021 20:14:32 -0700 (PDT) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com. [209.85.210.174]) by smtp.gmail.com with ESMTPSA id 71sm2645610pfw.113.2021.05.24.20.14.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 20:14:32 -0700 (PDT) Received: by mail-pf1-f174.google.com with SMTP id q67so5439230pfb.4 for ; Mon, 24 May 2021 20:14:31 -0700 (PDT) X-Received: by 2002:a6b:7b08:: with SMTP id l8mr16990516iop.50.1621912094090; Mon, 24 May 2021 20:08:14 -0700 (PDT) MIME-Version: 1.0 References: <20210518064215.2856977-1-tientzu@chromium.org> <20210518064215.2856977-2-tientzu@chromium.org> <170a54f2-be20-ec29-1d7f-3388e5f928c6@gmail.com> In-Reply-To: From: Claire Chang Date: Tue, 25 May 2021 11:08:03 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 01/15] swiotlb: Refactor swiotlb init functions To: Konrad Rzeszutek Wilk Cc: Florian Fainelli , Rob Herring , mpe@ellerman.id.au, Joerg Roedel , Will Deacon , Frank Rowand , boris.ostrovsky@oracle.com, jgross@suse.com, Christoph Hellwig , Marek Szyprowski , benh@kernel.crashing.org, paulus@samba.org, "list@263.net:IOMMU DRIVERS" , sstabellini@kernel.org, Robin Murphy , grant.likely@arm.com, xypron.glpk@gmx.de, Thierry Reding , mingo@kernel.org, bauerman@linux.ibm.com, peterz@infradead.org, Greg KH , Saravana Kannan , "Rafael J . Wysocki" , heikki.krogerus@linux.intel.com, Andy Shevchenko , Randy Dunlap , Dan Williams , Bartosz Golaszewski , linux-devicetree , lkml , linuxppc-dev@lists.ozlabs.org, xen-devel@lists.xenproject.org, Nicolas Boichat , Jim Quinlan , Tomasz Figa , bskeggs@redhat.com, Bjorn Helgaas , chris@chris-wilson.co.uk, Daniel Vetter , airlied@linux.ie, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com, Jianxiong Gao , joonas.lahtinen@linux.intel.com, linux-pci@vger.kernel.org, maarten.lankhorst@linux.intel.com, matthew.auld@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 24, 2021 at 11:53 PM Konrad Rzeszutek Wilk wrote: > > > > do the set_memory_decrypted()+memset(). Is this okay or should > > > swiotlb_init_io_tlb_mem() add an additional argument to do this > > > conditionally? > > > > I'm actually not sure if this it okay. If not, will add an additional > > argument for it. > > Any observations discovered? (Want to make sure my memory-cache has the > correct semantics for set_memory_decrypted in mind). It works fine on my arm64 device. > > > > > -- > > > Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 663A8C2B9F8 for ; Tue, 25 May 2021 03:09:10 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A9BD261404 for ; Tue, 25 May 2021 03:09:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9BD261404 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FpzZC5xSxz3073 for ; Tue, 25 May 2021 13:09:07 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=merHIeKN; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=chromium.org (client-ip=2607:f8b0:4864:20::102a; helo=mail-pj1-x102a.google.com; envelope-from=tientzu@chromium.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=merHIeKN; dkim-atps=neutral Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FpzYc0wWgz2yXT for ; Tue, 25 May 2021 13:08:33 +1000 (AEST) Received: by mail-pj1-x102a.google.com with SMTP id n6-20020a17090ac686b029015d2f7aeea8so12418613pjt.1 for ; Mon, 24 May 2021 20:08:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VHDFyefEfXv2T1h/kXDPOn5vVw8tSm/6FW05x+E2j40=; b=merHIeKNi5Uu6C9TAUujDNIN9FxrI34YUx7aW4WyFELIyYppIt99C4UwGvzWaArcmu 9EaYZFbnrmtDjrMZ7c8349ke6DKJjWiZDCUD5epOu2PqMIr5kYM1CoXZ0XNE1vQ3QFiu bvf2bDyHaIMES3MNNrHcengJbyjgwpDl3VY20= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VHDFyefEfXv2T1h/kXDPOn5vVw8tSm/6FW05x+E2j40=; b=ZPCPKAfnX6ffhzkU8aH41jlRBBBuhVUgShVjr9+RlyW/O+mVeE7IQfG9VIOk91kzKA 8r/r64A4aLFmN9vlewK5PxXFKKpK/AJRXJY2lyzAyymn8MumL0Mv3RF2M4+1FmiEelhv rryzY3srt3OR+Chr6JvXUpI6UJ/uoWSU3H9AqHQc/PVcDPDO20H9kgRSyhjKfjMsZPrr fSls4+db8+5tGlERGL8KApO4ROcoHiqNPdRfOsfWwkjVGw6aX0caiU/w0TTFJNWSsPJC 673cO5VlyRv3mRrh/olWrIiNKpzTxXatLIT75A3+3TfUNFwq1/j+gY3nsyWq/foy8TiB bI0Q== X-Gm-Message-State: AOAM532qicsjz4gQm8QDvY2UkqW1dIbNxbA8aKu/9KohVDVlYx7fweKB KcfVZo71F+fzOQPdEm+BqApFnkAelBWYfg== X-Google-Smtp-Source: ABdhPJzoKfQFHTJeJ6Y2WJEMwWCjqFZSecLg3os56HNovFPzmgsYtkLWor4YhdRW+hfFqYFOZzp7bQ== X-Received: by 2002:a17:902:934a:b029:fb:424b:7262 with SMTP id g10-20020a170902934ab02900fb424b7262mr4675461plp.17.1621912105309; Mon, 24 May 2021 20:08:25 -0700 (PDT) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com. [209.85.210.170]) by smtp.gmail.com with ESMTPSA id u12sm11043129pfm.2.2021.05.24.20.08.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 20:08:25 -0700 (PDT) Received: by mail-pf1-f170.google.com with SMTP id q25so4435151pfn.1 for ; Mon, 24 May 2021 20:08:24 -0700 (PDT) X-Received: by 2002:a6b:7b08:: with SMTP id l8mr16990516iop.50.1621912094090; Mon, 24 May 2021 20:08:14 -0700 (PDT) MIME-Version: 1.0 References: <20210518064215.2856977-1-tientzu@chromium.org> <20210518064215.2856977-2-tientzu@chromium.org> <170a54f2-be20-ec29-1d7f-3388e5f928c6@gmail.com> In-Reply-To: From: Claire Chang Date: Tue, 25 May 2021 11:08:03 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 01/15] swiotlb: Refactor swiotlb init functions To: Konrad Rzeszutek Wilk Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: heikki.krogerus@linux.intel.com, thomas.hellstrom@linux.intel.com, peterz@infradead.org, joonas.lahtinen@linux.intel.com, dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk, grant.likely@arm.com, paulus@samba.org, Frank Rowand , mingo@kernel.org, Marek Szyprowski , Florian Fainelli , Saravana Kannan , Joerg Roedel , "Rafael J . Wysocki" , Christoph Hellwig , Bartosz Golaszewski , bskeggs@redhat.com, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Thierry Reding , intel-gfx@lists.freedesktop.org, matthew.auld@intel.com, linux-devicetree , Jianxiong Gao , Daniel Vetter , Will Deacon , maarten.lankhorst@linux.intel.com, airlied@linux.ie, Dan Williams , linuxppc-dev@lists.ozlabs.org, jani.nikula@linux.intel.com, Rob Herring , rodrigo.vivi@intel.com, Bjorn Helgaas , boris.ostrovsky@oracle.com, Andy Shevchenko , jgross@suse.com, Nicolas Boichat , Greg KH , Randy Dunlap , lkml , Tomasz Figa , "list@263.net:IOMMU DRIVERS" , sstabellini@kernel.org, Jim Quinlan , xypron.glpk@gmx.de, Robin Murphy , bauerman@linux.ibm.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, May 24, 2021 at 11:53 PM Konrad Rzeszutek Wilk wrote: > > > > do the set_memory_decrypted()+memset(). Is this okay or should > > > swiotlb_init_io_tlb_mem() add an additional argument to do this > > > conditionally? > > > > I'm actually not sure if this it okay. If not, will add an additional > > argument for it. > > Any observations discovered? (Want to make sure my memory-cache has the > correct semantics for set_memory_decrypted in mind). It works fine on my arm64 device. > > > > > -- > > > Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 703E8C2B9F7 for ; Tue, 25 May 2021 03:08:22 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 002C461415 for ; Tue, 25 May 2021 03:08:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 002C461415 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id B5EAF606EC; Tue, 25 May 2021 03:08:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zDRTYFH2nCgK; Tue, 25 May 2021 03:08:20 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTP id BE21360762; Tue, 25 May 2021 03:08:19 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 93232C000D; Tue, 25 May 2021 03:08:19 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 38A84C0001 for ; Tue, 25 May 2021 03:08:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 19D6C83C2A for ; Tue, 25 May 2021 03:08:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=chromium.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZN9FegSgjwbl for ; Tue, 25 May 2021 03:08:17 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by smtp1.osuosl.org (Postfix) with ESMTPS id 747DE83C25 for ; Tue, 25 May 2021 03:08:17 +0000 (UTC) Received: by mail-il1-x12a.google.com with SMTP id m1so25161406ilg.10 for ; Mon, 24 May 2021 20:08:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VHDFyefEfXv2T1h/kXDPOn5vVw8tSm/6FW05x+E2j40=; b=merHIeKNi5Uu6C9TAUujDNIN9FxrI34YUx7aW4WyFELIyYppIt99C4UwGvzWaArcmu 9EaYZFbnrmtDjrMZ7c8349ke6DKJjWiZDCUD5epOu2PqMIr5kYM1CoXZ0XNE1vQ3QFiu bvf2bDyHaIMES3MNNrHcengJbyjgwpDl3VY20= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VHDFyefEfXv2T1h/kXDPOn5vVw8tSm/6FW05x+E2j40=; b=CRecBvPfOlM0cu2BNzFl+vH36AokFRbUUVeGQVIJWTPIUAcNeGn1n4wWsm08/f6mLr VKjtfEdY0UUae5zR58y5K0pu7aFttMdd7odbmJATttOMeeFGK5Jusqc/jTxfHoRCtB7i SS7lll8+eBhxtM51/F04Ri4Tb8erphdWLFZyO6bhcpib23q8NhXFCy+QLhz19C6EPmR8 GtMMxx81qUSQIn4+ucYw5H+9fVNDaxbMBC94oHvdIVpRMvKF1pM2c64LPwxwUeeMhsM8 YwJSSsLTiQq88qOglaHlhycx9g9lEEZSkDM1SdigTEa52QJP9mr1BsYV180cWapu3YPy jj8w== X-Gm-Message-State: AOAM5308o7Pb6v/voCxLQplDBtGTMGUU1nmOTeURpjrnz/Kdi5RP0x6e Fo2qevKVfKApLrEs1/VaDzFN4LTxWmZZVg== X-Google-Smtp-Source: ABdhPJy4TU3PM51f3K3kmgDMEOVi+nUBPrsBPSe9V+5xSFJBVaSwx5+EJW0gAsE4mqLxagwwDFsypw== X-Received: by 2002:a92:cc43:: with SMTP id t3mr21821810ilq.250.1621912096031; Mon, 24 May 2021 20:08:16 -0700 (PDT) Received: from mail-io1-f53.google.com (mail-io1-f53.google.com. [209.85.166.53]) by smtp.gmail.com with ESMTPSA id d15sm12177284ila.86.2021.05.24.20.08.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 20:08:15 -0700 (PDT) Received: by mail-io1-f53.google.com with SMTP id a6so2780924ioe.0 for ; Mon, 24 May 2021 20:08:14 -0700 (PDT) X-Received: by 2002:a6b:7b08:: with SMTP id l8mr16990516iop.50.1621912094090; Mon, 24 May 2021 20:08:14 -0700 (PDT) MIME-Version: 1.0 References: <20210518064215.2856977-1-tientzu@chromium.org> <20210518064215.2856977-2-tientzu@chromium.org> <170a54f2-be20-ec29-1d7f-3388e5f928c6@gmail.com> In-Reply-To: From: Claire Chang Date: Tue, 25 May 2021 11:08:03 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 01/15] swiotlb: Refactor swiotlb init functions To: Konrad Rzeszutek Wilk Cc: heikki.krogerus@linux.intel.com, thomas.hellstrom@linux.intel.com, peterz@infradead.org, benh@kernel.crashing.org, joonas.lahtinen@linux.intel.com, dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk, grant.likely@arm.com, paulus@samba.org, Frank Rowand , mingo@kernel.org, Florian Fainelli , Saravana Kannan , mpe@ellerman.id.au, "Rafael J . Wysocki" , Christoph Hellwig , Bartosz Golaszewski , bskeggs@redhat.com, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Thierry Reding , intel-gfx@lists.freedesktop.org, matthew.auld@intel.com, linux-devicetree , Jianxiong Gao , Daniel Vetter , Will Deacon , maarten.lankhorst@linux.intel.com, airlied@linux.ie, Dan Williams , linuxppc-dev@lists.ozlabs.org, jani.nikula@linux.intel.com, Rob Herring , rodrigo.vivi@intel.com, Bjorn Helgaas , boris.ostrovsky@oracle.com, Andy Shevchenko , jgross@suse.com, Nicolas Boichat , Greg KH , Randy Dunlap , lkml , "list@263.net:IOMMU DRIVERS" , sstabellini@kernel.org, Jim Quinlan , xypron.glpk@gmx.de, Robin Murphy , bauerman@linux.ibm.com X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, May 24, 2021 at 11:53 PM Konrad Rzeszutek Wilk wrote: > > > > do the set_memory_decrypted()+memset(). Is this okay or should > > > swiotlb_init_io_tlb_mem() add an additional argument to do this > > > conditionally? > > > > I'm actually not sure if this it okay. If not, will add an additional > > argument for it. > > Any observations discovered? (Want to make sure my memory-cache has the > correct semantics for set_memory_decrypted in mind). It works fine on my arm64 device. > > > > > -- > > > Florian _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76683C47085 for ; Tue, 25 May 2021 03:09:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C04B611CD for ; Tue, 25 May 2021 03:09:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C04B611CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 528F28938F; Tue, 25 May 2021 03:09:09 +0000 (UTC) Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7F79789395 for ; Tue, 25 May 2021 03:08:27 +0000 (UTC) Received: by mail-pj1-x102e.google.com with SMTP id kr9so7934681pjb.5 for ; Mon, 24 May 2021 20:08:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VHDFyefEfXv2T1h/kXDPOn5vVw8tSm/6FW05x+E2j40=; b=merHIeKNi5Uu6C9TAUujDNIN9FxrI34YUx7aW4WyFELIyYppIt99C4UwGvzWaArcmu 9EaYZFbnrmtDjrMZ7c8349ke6DKJjWiZDCUD5epOu2PqMIr5kYM1CoXZ0XNE1vQ3QFiu bvf2bDyHaIMES3MNNrHcengJbyjgwpDl3VY20= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VHDFyefEfXv2T1h/kXDPOn5vVw8tSm/6FW05x+E2j40=; b=XoWG6QNBAn+skahFNBnUlAuxbrR8ap0St2Q3yeAWv/JUiqNgmkutT/GwRRa7tv3CTQ 2xvECbO28kSt5YSMK3WNNlrzBMrgHzqs5/+48qNn/vwN22Bdtz/DjA3W4BFqyS6pK9oe OvLgWaNADLfSdJw2bFqhcuV5Et7tEOv1+ahTkbZrEWu9IKZTrvC3ijyX/zTcSbQcQehW DjTQ2afQMET80x7RZNJM+US8rryv3hNUFlz/ZGEj+eN+kTcPeyKk3+jndQsEHQOjURT5 xul2SzhB0+Q51YlMCo0B/UiTZbC2qObQCC5HVjAVaaxFmcsUgViS3UVl16et3RUyC468 1q6w== X-Gm-Message-State: AOAM530E/lVnCdY/mOti5zJMkdTjtK9Ul1jQAgkOwoQDjwFdBbqgzZfY PgJN6qCZpwlKM1Mixmuld2af4j3DV/xneQ== X-Google-Smtp-Source: ABdhPJzup5fr6XDh88epa0Kd0XmeVjICC0d7yxrk2/WAf1SQ4Bp6gGwC/m/0A8hjh5lpwhO9E9xHmA== X-Received: by 2002:a17:902:7e02:b029:f1:62ce:6674 with SMTP id b2-20020a1709027e02b02900f162ce6674mr28811513plm.39.1621912106807; Mon, 24 May 2021 20:08:26 -0700 (PDT) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com. [209.85.210.179]) by smtp.gmail.com with ESMTPSA id x21sm12340609pfr.124.2021.05.24.20.08.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 20:08:26 -0700 (PDT) Received: by mail-pf1-f179.google.com with SMTP id d16so22462609pfn.12 for ; Mon, 24 May 2021 20:08:25 -0700 (PDT) X-Received: by 2002:a6b:7b08:: with SMTP id l8mr16990516iop.50.1621912094090; Mon, 24 May 2021 20:08:14 -0700 (PDT) MIME-Version: 1.0 References: <20210518064215.2856977-1-tientzu@chromium.org> <20210518064215.2856977-2-tientzu@chromium.org> <170a54f2-be20-ec29-1d7f-3388e5f928c6@gmail.com> In-Reply-To: From: Claire Chang Date: Tue, 25 May 2021 11:08:03 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 01/15] swiotlb: Refactor swiotlb init functions To: Konrad Rzeszutek Wilk Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: heikki.krogerus@linux.intel.com, thomas.hellstrom@linux.intel.com, peterz@infradead.org, dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk, grant.likely@arm.com, paulus@samba.org, Frank Rowand , mingo@kernel.org, Marek Szyprowski , Florian Fainelli , Saravana Kannan , mpe@ellerman.id.au, Joerg Roedel , "Rafael J . Wysocki" , Christoph Hellwig , Bartosz Golaszewski , bskeggs@redhat.com, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Thierry Reding , intel-gfx@lists.freedesktop.org, matthew.auld@intel.com, linux-devicetree , Jianxiong Gao , Will Deacon , airlied@linux.ie, Dan Williams , linuxppc-dev@lists.ozlabs.org, Rob Herring , rodrigo.vivi@intel.com, Bjorn Helgaas , boris.ostrovsky@oracle.com, Andy Shevchenko , jgross@suse.com, Nicolas Boichat , Greg KH , Randy Dunlap , lkml , Tomasz Figa , "list@263.net:IOMMU DRIVERS" , sstabellini@kernel.org, Jim Quinlan , xypron.glpk@gmx.de, Robin Murphy , bauerman@linux.ibm.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, May 24, 2021 at 11:53 PM Konrad Rzeszutek Wilk wrote: > > > > do the set_memory_decrypted()+memset(). Is this okay or should > > > swiotlb_init_io_tlb_mem() add an additional argument to do this > > > conditionally? > > > > I'm actually not sure if this it okay. If not, will add an additional > > argument for it. > > Any observations discovered? (Want to make sure my memory-cache has the > correct semantics for set_memory_decrypted in mind). It works fine on my arm64 device. > > > > > -- > > > Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B5A9C2B9F7 for ; Tue, 25 May 2021 03:09:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA22361404 for ; Tue, 25 May 2021 03:09:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA22361404 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C86696E5C5; Tue, 25 May 2021 03:09:09 +0000 (UTC) Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5B51C8938F for ; Tue, 25 May 2021 03:08:26 +0000 (UTC) Received: by mail-pg1-x533.google.com with SMTP id i5so21627113pgm.0 for ; Mon, 24 May 2021 20:08:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VHDFyefEfXv2T1h/kXDPOn5vVw8tSm/6FW05x+E2j40=; b=merHIeKNi5Uu6C9TAUujDNIN9FxrI34YUx7aW4WyFELIyYppIt99C4UwGvzWaArcmu 9EaYZFbnrmtDjrMZ7c8349ke6DKJjWiZDCUD5epOu2PqMIr5kYM1CoXZ0XNE1vQ3QFiu bvf2bDyHaIMES3MNNrHcengJbyjgwpDl3VY20= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VHDFyefEfXv2T1h/kXDPOn5vVw8tSm/6FW05x+E2j40=; b=mWlrvCCoRlGqKysSxDT+VtX+JfaXaLah0LrfRwu8MKoYvsr3A8QoTjIEsvH7XY5r8A 2/WkmKlWmQjxXO8eBBnOIPDgvX5FqszEScZrDCOp7ziYD9w4WH+elXhcaSokahZuN6JZ NpTw9wh5Y1h3gcZ1wxJmPGnrsPC2suucjaWruTtNAMmA0ukXN83/I8Urt7aHxRHOrl3j 68amnnd5NMflF3QaN7n9XYQ+fNZodAo+ZgVZYxCFSHCdkvZWOFF/s7qDTyAXP12xP3MG 7/QQhMoyA0M7Gdqv91c07uG85JDRp8YSYkgy7I7xdSOo4O58zrlB0covpFkzqmekPAxo Fbtw== X-Gm-Message-State: AOAM533kDZIBRd55HGKhyoC5BqIKP91zqityf6ALrlldITScybrz/VEJ dF+VZYlPx3fnvomWFrrzqf81/D/RiGymHA== X-Google-Smtp-Source: ABdhPJxZamRKcuiisQf8PLZPaG1s8/K7Q9uH5W0lkSfqyQDbHMEKYubMlMy9CRxQjam1XX1RqilhGw== X-Received: by 2002:a63:79c3:: with SMTP id u186mr16820884pgc.203.1621912106021; Mon, 24 May 2021 20:08:26 -0700 (PDT) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com. [209.85.210.180]) by smtp.gmail.com with ESMTPSA id w197sm11902336pfc.5.2021.05.24.20.08.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 20:08:25 -0700 (PDT) Received: by mail-pf1-f180.google.com with SMTP id d78so21603758pfd.10 for ; Mon, 24 May 2021 20:08:25 -0700 (PDT) X-Received: by 2002:a6b:7b08:: with SMTP id l8mr16990516iop.50.1621912094090; Mon, 24 May 2021 20:08:14 -0700 (PDT) MIME-Version: 1.0 References: <20210518064215.2856977-1-tientzu@chromium.org> <20210518064215.2856977-2-tientzu@chromium.org> <170a54f2-be20-ec29-1d7f-3388e5f928c6@gmail.com> In-Reply-To: From: Claire Chang Date: Tue, 25 May 2021 11:08:03 +0800 X-Gmail-Original-Message-ID: Message-ID: To: Konrad Rzeszutek Wilk Subject: Re: [Intel-gfx] [PATCH v7 01/15] swiotlb: Refactor swiotlb init functions X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: heikki.krogerus@linux.intel.com, thomas.hellstrom@linux.intel.com, peterz@infradead.org, benh@kernel.crashing.org, dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk, grant.likely@arm.com, paulus@samba.org, Frank Rowand , mingo@kernel.org, Marek Szyprowski , Florian Fainelli , Saravana Kannan , mpe@ellerman.id.au, Joerg Roedel , "Rafael J . Wysocki" , Christoph Hellwig , Bartosz Golaszewski , bskeggs@redhat.com, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Thierry Reding , intel-gfx@lists.freedesktop.org, matthew.auld@intel.com, linux-devicetree , Jianxiong Gao , Will Deacon , airlied@linux.ie, Dan Williams , linuxppc-dev@lists.ozlabs.org, Rob Herring , Bjorn Helgaas , boris.ostrovsky@oracle.com, Andy Shevchenko , jgross@suse.com, Nicolas Boichat , Greg KH , Randy Dunlap , lkml , Tomasz Figa , "list@263.net:IOMMU DRIVERS" , sstabellini@kernel.org, Jim Quinlan , xypron.glpk@gmx.de, Robin Murphy , bauerman@linux.ibm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, May 24, 2021 at 11:53 PM Konrad Rzeszutek Wilk wrote: > > > > do the set_memory_decrypted()+memset(). Is this okay or should > > > swiotlb_init_io_tlb_mem() add an additional argument to do this > > > conditionally? > > > > I'm actually not sure if this it okay. If not, will add an additional > > argument for it. > > Any observations discovered? (Want to make sure my memory-cache has the > correct semantics for set_memory_decrypted in mind). It works fine on my arm64 device. > > > > > -- > > > Florian _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0D32C2B9F7 for ; Tue, 25 May 2021 03:15:06 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B8E361042 for ; Tue, 25 May 2021 03:15:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B8E361042 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.132047.246456 (Exim 4.92) (envelope-from ) id 1llNWy-0002Gl-8X; Tue, 25 May 2021 03:14:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 132047.246456; Tue, 25 May 2021 03:14:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1llNWy-0002Ge-5U; Tue, 25 May 2021 03:14:56 +0000 Received: by outflank-mailman (input) for mailman id 132047; Tue, 25 May 2021 03:14:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1llNWw-0002GY-K1 for xen-devel@lists.xenproject.org; Tue, 25 May 2021 03:14:54 +0000 Received: from mail-pl1-x62f.google.com (unknown [2607:f8b0:4864:20::62f]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8c824c4e-0b7c-43d2-83ad-dc7a48f52b35; Tue, 25 May 2021 03:14:53 +0000 (UTC) Received: by mail-pl1-x62f.google.com with SMTP id v12so15632176plo.10 for ; Mon, 24 May 2021 20:14:53 -0700 (PDT) Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com. [209.85.215.180]) by smtp.gmail.com with ESMTPSA id s48sm11769117pfw.205.2021.05.24.20.14.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 20:14:52 -0700 (PDT) Received: by mail-pg1-f180.google.com with SMTP id f22so20665987pgb.9 for ; Mon, 24 May 2021 20:14:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c824c4e-0b7c-43d2-83ad-dc7a48f52b35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VHDFyefEfXv2T1h/kXDPOn5vVw8tSm/6FW05x+E2j40=; b=merHIeKNi5Uu6C9TAUujDNIN9FxrI34YUx7aW4WyFELIyYppIt99C4UwGvzWaArcmu 9EaYZFbnrmtDjrMZ7c8349ke6DKJjWiZDCUD5epOu2PqMIr5kYM1CoXZ0XNE1vQ3QFiu bvf2bDyHaIMES3MNNrHcengJbyjgwpDl3VY20= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VHDFyefEfXv2T1h/kXDPOn5vVw8tSm/6FW05x+E2j40=; b=Js231dBlhRiGjOhCB0xtNDckY6CR4/sSb50FwrGm+vD/Zalcm67TcSZ2mfr7AWpV3I UnmN2DwMIqcc/R6XYlnaLBBKZZmkIj0uJoHAu3zWjM00ao3/nG5k8OkhG8TWUC591ISM px2Q/vfk35yx+tshIBD1talopiyBigAP1GInUrkdCEPKqAE81+5eu+kNrG6wwWsamZi2 hYLdTLl+eatoGILhJSqRN2DsKPvDcOXrTaOD67IcfNYvLFhINwtp9LfYpKWjZ4deTUag JLtFxJ+0BEEplQohcG1/lwr4rpYuXLF0OmlxZrghDX/3//xN/RbFmCm7DlVqtJaSx/qI kVAA== X-Gm-Message-State: AOAM531B7+nQ4M66lWuG7CJl+DtGVPQrZLr8aJVNMtc70cPI8dCNvgOj WnrGymOuEOraLkVnsksZYLPKbVyt+5AMpw== X-Google-Smtp-Source: ABdhPJyVB6HbPdbfwPGUg++s80co/GUFVU14nQLwF+soWxwWrwoFgdh3VEcI/qlLhdNXNxT3jRZ5Yw== X-Received: by 2002:a17:90a:6f06:: with SMTP id d6mr28281937pjk.216.1621912492879; Mon, 24 May 2021 20:14:52 -0700 (PDT) X-Received: by 2002:a6b:7b08:: with SMTP id l8mr16990516iop.50.1621912094090; Mon, 24 May 2021 20:08:14 -0700 (PDT) MIME-Version: 1.0 References: <20210518064215.2856977-1-tientzu@chromium.org> <20210518064215.2856977-2-tientzu@chromium.org> <170a54f2-be20-ec29-1d7f-3388e5f928c6@gmail.com> In-Reply-To: From: Claire Chang Date: Tue, 25 May 2021 11:08:03 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 01/15] swiotlb: Refactor swiotlb init functions To: Konrad Rzeszutek Wilk Cc: Florian Fainelli , Rob Herring , mpe@ellerman.id.au, Joerg Roedel , Will Deacon , Frank Rowand , boris.ostrovsky@oracle.com, jgross@suse.com, Christoph Hellwig , Marek Szyprowski , benh@kernel.crashing.org, paulus@samba.org, "list@263.net:IOMMU DRIVERS" , sstabellini@kernel.org, Robin Murphy , grant.likely@arm.com, xypron.glpk@gmx.de, Thierry Reding , mingo@kernel.org, bauerman@linux.ibm.com, peterz@infradead.org, Greg KH , Saravana Kannan , "Rafael J . Wysocki" , heikki.krogerus@linux.intel.com, Andy Shevchenko , Randy Dunlap , Dan Williams , Bartosz Golaszewski , linux-devicetree , lkml , linuxppc-dev@lists.ozlabs.org, xen-devel@lists.xenproject.org, Nicolas Boichat , Jim Quinlan , Tomasz Figa , bskeggs@redhat.com, Bjorn Helgaas , chris@chris-wilson.co.uk, Daniel Vetter , airlied@linux.ie, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com, Jianxiong Gao , joonas.lahtinen@linux.intel.com, linux-pci@vger.kernel.org, maarten.lankhorst@linux.intel.com, matthew.auld@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com Content-Type: text/plain; charset="UTF-8" On Mon, May 24, 2021 at 11:53 PM Konrad Rzeszutek Wilk wrote: > > > > do the set_memory_decrypted()+memset(). Is this okay or should > > > swiotlb_init_io_tlb_mem() add an additional argument to do this > > > conditionally? > > > > I'm actually not sure if this it okay. If not, will add an additional > > argument for it. > > Any observations discovered? (Want to make sure my memory-cache has the > correct semantics for set_memory_decrypted in mind). It works fine on my arm64 device. > > > > > -- > > > Florian