From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bycN2-0006An-Qf for qemu-devel@nongnu.org; Mon, 24 Oct 2016 06:20:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bycN1-0005gd-Of for qemu-devel@nongnu.org; Mon, 24 Oct 2016 06:20:44 -0400 MIME-Version: 1.0 In-Reply-To: <20161024093943.GC2190@work-vm> References: <1477288523-10819-1-git-send-email-vijay.kilari@gmail.com> <1477288523-10819-3-git-send-email-vijay.kilari@gmail.com> <20161024093943.GC2190@work-vm> From: Vijay Kilari Date: Mon, 24 Oct 2016 15:50:39 +0530 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v3 2/3] utils: Add helper to read arm MIDR_EL1 register List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: qemu-arm , Peter Maydell , Paolo Bonzini , Richard Henderson , QEMU Developers , Vijaya Kumar K On Mon, Oct 24, 2016 at 3:09 PM, Dr. David Alan Gilbert wrote: > * vijay.kilari@gmail.com (vijay.kilari@gmail.com) wrote: >> From: Vijaya Kumar K >> >> Add helper API to read MIDR_EL1 registers to fetch >> cpu identification information. This helps in >> adding errata's and architecture specific features. >> >> This is implemented only for arm architecture. >> >> Signed-off-by: Vijaya Kumar K >> --- >> include/qemu/aarch64-cpuid.h | 9 +++++ >> util/Makefile.objs | 1 + >> util/aarch64-cpuid.c | 87 ++++++++++++++++++++++++++++++++++++++++++++ > > It feels like there should be somewhere else to put this very ARM specific thing > that in util/ - not sure where though. IRC, I tried it. But libutil is built before arch code compilation. So cannot put outside of util folder