Re: [PATCH v2 13/15] xen/arm: Add support for GIC v3

[Vijay Kilari <vijay.kilari@gmail.com>]

On Thu, Apr 10, 2014 at 4:04 PM, Julien Grall <julien.grall@linaro.org> wrote:
> On 04/10/2014 11:00 AM, Ian Campbell wrote:
>> On Fri, 2014-04-04 at 17:26 +0530, vijay.kilari@gmail.com wrote:
>>
>>> +#define gic_data_rdist_rd_base()        (this_cpu(rbase))
>>> +#define gic_data_rdist_sgi_base()       (gic_data_rdist_rd_base() + SZ_64K)
>>
>> Macros should be SHOUTY and ideally a lot shorter.
>>
>> Since we have GICD[...] etc how about GICR[...]? And for the SGI bit
>> just use GICR[GICR_SGI_...] (where GICR_SGI_ is 64K).
>>
>>> +
>>> +static inline u64 read_cpuid_mpidr(void)
>>> +{
>>> +   return READ_SYSREG(MPIDR_EL1);
>>> +}
>>
>> No need for this trivial wrapper.
>
> As said on V1:
> MPDIR_EL1 is already replicated in current_cpu_data.mpidr.bits
>
  I find only MIDR register contents in current_cpu_data.midr.bits
but not MPIDR