From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vijay Kilari <vijay.kilari@gmail.com>
Subject: Re: [PATCH v2 01/15] xen/arm: register mmio handler at
	runtime
Date: Tue, 8 Apr 2014 10:17:24 +0530
Message-ID: <CALicx6vT+U=u2N6Hjdq26aTXHmct5PdHJkpmoOSYFQM0QNoyjw@mail.gmail.com>
References: <1396612593-443-1-git-send-email-vijay.kilari@gmail.com>
	<1396612593-443-2-git-send-email-vijay.kilari@gmail.com>
	<533EA307.4000900@linaro.org>
	<CALicx6u-6Gz=LcsDjH+Pb_FG2GzXxMHJOqHCZrfDdwBtqR8dQQ@mail.gmail.com>
	<533EACB0.6070604@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <533EACB0.6070604@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Prasun Kapoor <Prasun.Kapoor@caviumnetworks.com>, Vijaya Kumar K <vijaya.kumar@caviumnetworks.com>, Andrii Anisov <andrii.anisov@globallogic.com>, xen-devel@lists.xen.org, Stefano Stabellini <stefano.stabellini@citrix.com>
List-Id: xen-devel@lists.xenproject.org

>>>
>>>>
>>>> -const struct mmio_handler vgic_distr_mmio_handler = {
>>>> +static struct mmio_handler vgic_distr_mmio_handler = {
>>>
>>> Why did you remove the const?
>>
>> I think, compiler is allowing forward declaration with const
>
> You meant doesn't allow? If so, please move the whole structure. I'd
> prefer code movement rather than removing a const because of compiler issue.
>
Yes, compiler does not allow. I will move the code
>>
>>>
>>> [..]
>>>
>>>> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
>>>> index 50b9b54..23dac85 100644
>>>> --- a/xen/include/asm-arm/domain.h
>>>> +++ b/xen/include/asm-arm/domain.h
>>>> @@ -116,6 +116,7 @@ struct arch_domain
>>>>      struct hvm_domain hvm_domain;
>>>>      xen_pfn_t *grant_table_gpfn;
>>>>
>>>> +    struct io_handler *io_handlers;
>>>
>>> Why do you need a pointer here? I think can can directly use
>>> struct io_handler iohandlers.
>>>
>>   I just adds to increase the size of this arch_domain struct.
>> so allocated memory at runtime.
>
> Do you hit the page size?
Yes, I have faced page size exhausted issue which I have reported earlier

>
> Regards,
>
> --
> Julien Grall