Re: [PATCH]

[Sitsofe Wheeler <sitsofe@gmail.com>]

On 19 May 2017 at 11:39, Andreas Herrmann <aherrmann@suse.com> wrote:
>
> Starting with 9e4438f ("stat: don't trust per_unit_log() if log is
> NULL") fio no longer provides basic bw information (e.g. min, max,
> p_agg, mean, stdev) when write_bw_log is not used. Thus you have to
> write a bw_log to obtain these values. (But in this case you can
> compute those values yourself.) I think this doesn't make sense.  Not
> writing entire bw log shouldn't prevent general sampling and
> calculation of bw stats.
>
> This patch reactivates sampling for bw and iops to be able to
> calculate basic stats for both independend of writing of entire
> {bw,iops}_logs.
>
> Also check for log that is really of interest in __add_samples() it
> doesn't make sense to check for bw_log if iops information needs to be
> written.
>
> Signed-off-by: Andreas Herrmann <aherrmann@suse.com>
> ---
>  stat.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> I don't know the background why the original fix was required in its
> form and at which exact point the sigbus error happened on sparc. Was
> it in per_unit_log(td->bw_log) or somewhere in add_bw_samples or
> add_iops_samples? Maybe the original code version (just using
> !per_unit_log(td->bw_log)) was fine and the sigbus happened due to the
> bug in __add_samples (checking for the wrong log file)?

The sparc sigbus report seems to come from here:
https://lists.debian.org/debian-sparc/2016/08/msg00028.html
("[sparc64] fio bus error").

-- 
Sitsofe | http://sucs.org/~sits/