All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trevor Woerner <trevor.woerner@linaro.org>
To: Martin Jansa <martin.jansa@gmail.com>, marek.belisko@gmail.com
Cc: "yocto@yoctoproject.org" <yocto@yoctoproject.org>
Subject: Re: [DYLAN] RPATH issue with qt5's qtwebkit
Date: Mon, 16 Sep 2013 21:34:18 -0400	[thread overview]
Message-ID: <CALmOhgn0tvpdSPs4RnJGy0HnRz2i_87Woww=B=bfoyWMNLxCQQ@mail.gmail.com> (raw)
In-Reply-To: <20130824141107.GG3544@jama>

Hi Martin,

On 24 August 2013 10:11, Martin Jansa <martin.jansa@gmail.com> wrote:
> You can see do_configure_append in qtwebkit.inc which is removing bad
> rpath from qmake generated Makefile, this sometimes doesn't work

Yes, I've been seeing the exact same thing. Although this _append
claims to be fixing the rpath issue, I'm still seeing QA issues (which
lead to errors) build packaging qtwebkit.

Interestingly enough, the _append you mention is only trying to fix
QtWebProcess but I'm seeing this rpath error occur on both it and
QtWebPluginProcess.

> Of course the real fix for both issues would be to fix .pri/.prf files
> to prevent incorrect Makefile to be generated at all.

As you, Richard, and everyone else has mentioned it would be nice to
have a "proper" fix instead of things which patch up files afterward.
This is why I like Marek's proposal since it fixes the *.prf file
before the build. Looking through that patch, however, I'm wondering
if it couldn't be a little cleaner? Marek's patch simply comments out
a couple lines. I think it would be cleaner to just remove the lines
that are causing problems and/or investigate whether or not that *.prf
file is actually needed at all in this build environment.

Are there any comments on what Marek has targetted? Would others
consider this a "proper" fix (if the patch were cleaned up)?

Best regards,
    Trevor


  reply	other threads:[~2013-09-17  1:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-24  1:36 [DYLAN] RPATH issue with qt5's qtwebkit Trevor Woerner
2013-08-24  8:48 ` Richard Purdie
2013-08-24 13:06 ` Erik Botö
2013-08-24 14:11   ` Martin Jansa
2013-09-17  1:34     ` Trevor Woerner [this message]
2013-08-24 16:03   ` Richard Purdie
2013-08-26 10:51     ` Belisko Marek
2013-08-26 11:11 ` Fathi Boudra
2013-09-17  1:23   ` Trevor Woerner
2013-09-18 21:52     ` Fathi Boudra
2013-09-19  1:36       ` Trevor Woerner
2013-09-24 16:04         ` Trevor Woerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALmOhgn0tvpdSPs4RnJGy0HnRz2i_87Woww=B=bfoyWMNLxCQQ@mail.gmail.com' \
    --to=trevor.woerner@linaro.org \
    --cc=marek.belisko@gmail.com \
    --cc=martin.jansa@gmail.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.