From: Pravin Shelar <pshelar@nicira.com>
To: Joe Stringer <joestringer@nicira.com>
Cc: netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"dev@openvswitch.org" <dev@openvswitch.org>
Subject: Re: [PATCH net-next v14 5/5] openvswitch: Add support for unique flow IDs.
Date: Wed, 21 Jan 2015 17:16:36 -0800 [thread overview]
Message-ID: <CALnjE+ovJvdnW+PQFKqs4aRMApO=o=th6CGjM_DJdNLWrUVJPg@mail.gmail.com> (raw)
In-Reply-To: <1421887372-56414-6-git-send-email-joestringer@nicira.com>
On Wed, Jan 21, 2015 at 4:42 PM, Joe Stringer <joestringer@nicira.com> wrote:
> Previously, flows were manipulated by userspace specifying a full,
> unmasked flow key. This adds significant burden onto flow
> serialization/deserialization, particularly when dumping flows.
>
> This patch adds an alternative way to refer to flows using a
> variable-length "unique flow identifier" (UFID). At flow setup time,
> userspace may specify a UFID for a flow, which is stored with the flow
> and inserted into a separate table for lookup, in addition to the
> standard flow table. Flows created using a UFID must be fetched or
> deleted using the UFID.
>
> All flow dump operations may now be made more terse with OVS_UFID_F_*
> flags. For example, the OVS_UFID_F_OMIT_KEY flag allows responses to
> omit the flow key from a datapath operation if the flow has a
> corresponding UFID. This significantly reduces the time spent assembling
> and transacting netlink messages. With all OVS_UFID_F_OMIT_* flags
> enabled, the datapath only returns the UFID and statistics for each flow
> during flow dump, increasing ovs-vswitchd revalidator performance by 40%
> or more.
>
> Signed-off-by: Joe Stringer <joestringer@nicira.com>
Looks good.
Acked-by: Pravin B Shelar <pshelar@nicira.com>
Thanks.
next prev parent reply other threads:[~2015-01-22 1:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 0:42 [PATCH net-next v14 0/5] openvswitch: Introduce 128-bit unique flow identifiers Joe Stringer
2015-01-22 0:42 ` Joe Stringer
2015-01-22 0:42 ` [PATCH net-next v14 1/5] openvswitch: Refactor ovs_nla_fill_match() Joe Stringer
2015-01-22 0:42 ` Joe Stringer
2015-01-22 1:16 ` Pravin Shelar
2015-01-22 0:42 ` [PATCH net-next v14 2/5] openvswitch: Refactor ovs_flow_tbl_insert() Joe Stringer
2015-01-22 0:42 ` Joe Stringer
2015-01-22 1:16 ` Pravin Shelar
2015-01-22 1:16 ` Pravin Shelar
2015-01-22 0:42 ` [PATCH net-next v14 3/5] openvswitch: Use sw_flow_key_range for key ranges Joe Stringer
2015-01-22 1:16 ` Pravin Shelar
2015-01-22 0:42 ` [PATCH net-next v14 4/5] genetlink: Add genlmsg_parse() helper function Joe Stringer
2015-01-22 1:16 ` Pravin Shelar
2015-01-22 0:42 ` [PATCH net-next v14 5/5] openvswitch: Add support for unique flow IDs Joe Stringer
2015-01-22 1:16 ` Pravin Shelar [this message]
2015-01-26 23:46 ` [PATCH net-next v14 0/5] openvswitch: Introduce 128-bit unique flow identifiers David Miller
2015-01-26 23:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALnjE+ovJvdnW+PQFKqs4aRMApO=o=th6CGjM_DJdNLWrUVJPg@mail.gmail.com' \
--to=pshelar@nicira.com \
--cc=dev@openvswitch.org \
--cc=joestringer@nicira.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.