From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757329AbbIURqA (ORCPT ); Mon, 21 Sep 2015 13:46:00 -0400 Received: from mail-io0-f174.google.com ([209.85.223.174]:34789 "EHLO mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757228AbbIURp6 (ORCPT ); Mon, 21 Sep 2015 13:45:58 -0400 MIME-Version: 1.0 In-Reply-To: <1442842450-29769-9-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> <1442842450-29769-9-git-send-email-a.hajda@samsung.com> Date: Mon, 21 Sep 2015 10:45:57 -0700 Message-ID: Subject: Re: [PATCH 08/38] openvswitch: fix handling result of ipv6_skip_exthdr From: Pravin Shelar To: Andrzej Hajda Cc: LKML , Bartlomiej Zolnierkiewicz , Marek Szyprowski , "David S. Miller" , netdev , "dev@openvswitch.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2015 at 6:33 AM, Andrzej Hajda wrote: > The function can return negative value. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 > > Signed-off-by: Andrzej Hajda > --- > net/openvswitch/conntrack.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c > index 002a755..fde3391 100644 > --- a/net/openvswitch/conntrack.c > +++ b/net/openvswitch/conntrack.c > @@ -253,7 +253,7 @@ static int ovs_ct_helper(struct sk_buff *skb, u16 proto) > const struct nf_conntrack_helper *helper; > const struct nf_conn_help *help; > enum ip_conntrack_info ctinfo; > - unsigned int protoff; > + int protoff; > struct nf_conn *ct; > A patch is already pushed to the net tree to fix this issue.