From: Pravin Shelar <pshelar@nicira.com>
To: roy.qing.li@gmail.com
Cc: netdev <netdev@vger.kernel.org>, Thomas Graf <tgraf@noironetworks.com>
Subject: Re: [PATCH v2] openvswitch: distinguish between the dropped and consumed skb
Date: Wed, 3 Sep 2014 13:36:26 -0700 [thread overview]
Message-ID: <CALnjE+qTNTAH=XaPh86BvRntLzSNnRXYLSJpkdpGJJgVNbVODA@mail.gmail.com> (raw)
In-Reply-To: <1409737426-22245-1-git-send-email-roy.qing.li@gmail.com>
On Wed, Sep 3, 2014 at 2:43 AM, <roy.qing.li@gmail.com> wrote:
> From: Li RongQing <roy.qing.li@gmail.com>
>
> distinguish between the dropped and consumed skb, not assume the skb
> is consumed always
>
> Cc: Thomas Graf <tgraf@noironetworks.com>
> Cc: Pravin Shelar <pshelar@nicira.com>
> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
Acked-by: Pravin B Shelar <pshelar@nicira.com>
Thanks.
> ---
> net/openvswitch/datapath.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
> index 35d866f..91d66b7 100644
> --- a/net/openvswitch/datapath.c
> +++ b/net/openvswitch/datapath.c
> @@ -265,8 +265,11 @@ void ovs_dp_process_received_packet(struct vport *p, struct sk_buff *skb)
> upcall.key = &key;
> upcall.userdata = NULL;
> upcall.portid = ovs_vport_find_upcall_portid(p, skb);
> - ovs_dp_upcall(dp, skb, &upcall);
> - consume_skb(skb);
> + error = ovs_dp_upcall(dp, skb, &upcall);
> + if (unlikely(error))
> + kfree_skb(skb);
> + else
> + consume_skb(skb);
> stats_counter = &stats->n_missed;
> goto out;
> }
> --
> 1.7.10.4
>
next prev parent reply other threads:[~2014-09-03 20:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 9:43 [PATCH v2] openvswitch: distinguish between the dropped and consumed skb roy.qing.li
2014-09-03 20:36 ` Pravin Shelar [this message]
2014-09-04 3:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALnjE+qTNTAH=XaPh86BvRntLzSNnRXYLSJpkdpGJJgVNbVODA@mail.gmail.com' \
--to=pshelar@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=roy.qing.li@gmail.com \
--cc=tgraf@noironetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.