From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pravin Shelar Subject: Re: [PATCH net 1/2] vxlan: unregister on namespace exit Date: Thu, 18 Jul 2013 09:40:07 -0700 Message-ID: References: <20130718083826.58ae2b77@nehalam.linuxnetplumber.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: David Miller , netdev@vger.kernel.org To: Stephen Hemminger Return-path: Received: from na3sys009aog114.obsmtp.com ([74.125.149.211]:58589 "HELO na3sys009aog114.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752128Ab3GRQkO (ORCPT ); Thu, 18 Jul 2013 12:40:14 -0400 Received: by mail-qe0-f44.google.com with SMTP id 5so1929450qeb.3 for ; Thu, 18 Jul 2013 09:40:07 -0700 (PDT) In-Reply-To: <20130718083826.58ae2b77@nehalam.linuxnetplumber.net> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Jul 18, 2013 at 8:38 AM, Stephen Hemminger wrote: > Fix memory leaks and other badness from VXLAN network namespace > teardown. When network namespace is removed, all the vxlan devices should > be unregistered (not closed). > > Signed-off-by: Stephen Hemminger > > > --- a/drivers/net/vxlan.c 2013-07-17 16:32:10.826955800 -0700 > +++ b/drivers/net/vxlan.c 2013-07-17 16:47:35.275690741 -0700 > @@ -1878,10 +1878,12 @@ static __net_exit void vxlan_exit_net(st > { > struct vxlan_net *vn = net_generic(net, vxlan_net_id); > struct vxlan_dev *vxlan; > + LIST_HEAD(list); > > rtnl_lock(); > - list_for_each_entry(vxlan, &vn->vxlan_list, next) > - dev_close(vxlan->dev); > + list_for_each_entry(vxlan, &vn->vxlan_list, next) > + unregister_netdevice_queue(vxlan->dev, &list); > + unregister_netdevice_many(&list); > rtnl_unlock(); > } > Looks good. Reviewed-by: Pravin B Shelar