From mboxrd@z Thu Jan 1 00:00:00 1970 From: Minkyu Kang Date: Mon, 23 Apr 2012 19:56:12 +0900 Subject: [U-Boot] [PATCH 2/2] EXYNOS: draw 32bpp bitmap TIZEN logo In-Reply-To: <4F952C13.6020508@samsung.com> References: <4F94B49E.5020802@samsung.com> <4F952C13.6020508@samsung.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 23 April 2012 19:16, Donghwa Lee wrote: > Thank you for your comment. > > On 23 April 2012 18:00, Minkyu Kang wrote: > >> On 23 April 2012 10:47, Donghwa Lee wrote: >>> This patches support drawing 32bpp bitmap TIZEN logo in exynos fb. >>> asm/arch/trats_logo.h data is compressed by zip and decomressed at >>> the exynos fb driver. >>> >>> And vl_bpix of vidinfo_t is changed proper value for u-boot. >>> >>> Signed-off-by: Donghwa Lee >>> Signed-off-by: Kyungmin park >>> --- >>> ?arch/arm/include/asm/arch-exynos/trats_logo.h | 5070 +++++++++++++++++++++++++ >>> ?board/samsung/trats/trats.c ? ? ? ? ? ? ? ? ? | ? ?2 +- >>> ?drivers/video/exynos_fb.c ? ? ? ? ? ? ? ? ? ? | ? 40 +- >>> ?drivers/video/exynos_fimd.c ? ? ? ? ? ? ? ? ? | ? ?6 +- >>> ?include/configs/trats.h ? ? ? ? ? ? ? ? ? ? ? | ? ?4 +- >>> ?5 files changed, 5116 insertions(+), 6 deletions(-) >>> ?create mode 100644 arch/arm/include/asm/arch-exynos/trats_logo.h >>> >>> ?static void lcd_panel_on(vidinfo_t *vid) >>> ?{ >>> ? ? ? ?udelay(vid->init_delay); >>> @@ -113,6 +147,10 @@ void lcd_ctrl_init(void *lcdbase) >>> >>> ? ? ? ?exynos_lcd_init_mem(lcdbase, &panel_info); >>> >>> + ? ? ? memset(lcdbase, 0, panel_width * panel_height * >>> + ? ? ? ? ? ? ? ? ? ? ? (NBITS(panel_info.vl_bpix) >> 3)); >>> + ? ? ? draw_logo(lcdbase); >> >> Always draw the logo? >> > > umh... How about your opinion? When board start, I think boot logo has to turn on. > For example, some boards doesn't have logo. but want to enable the FB. then how it work? Maybe, you will get errors. >>> + >>> ? ? ? ?exynos_lcd_init(&panel_info); >>> ?} >>> >>> diff --git a/drivers/video/exynos_fimd.c b/drivers/video/exynos_fimd.c >>> index cd2b1b6..8f2d667 100644 >>> --- a/drivers/video/exynos_fimd.c >>> +++ b/drivers/video/exynos_fimd.c >>> @@ -110,7 +110,7 @@ static void exynos_fimd_set_buffer_address(unsigned int win_id) >>> ? ? ? ? ? ? ? ?(struct exynos4_fb *)samsung_get_base_fimd(); >>> >>> ? ? ? ?start_addr = (unsigned long)lcd_base_addr; >>> - ? ? ? end_addr = start_addr + ((pvid->vl_col * (pvid->vl_bpix / 8)) * >>> + ? ? ? end_addr = start_addr + ((pvid->vl_col * (NBITS(pvid->vl_bpix) / 8)) * >> >> Is it related change? >> I think this is another bug fix. >> If so, please fix them to another patch. >> > > in u-boot mainline vl_bpix is usually used like this, so I had changed. Before sending > this patch, exynos framebuffer didn't drawing logo. At that time I didn't know above macro. > But if it is not used like above, drawing logo feature is not worked. Yes it's a bug. > > If you want to separate another patch, I will do that. Yes please. Thanks. Minkyu Kang. -- from. prom. www.promsoft.net