From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v5 10/15] serial: stm32-usart: Add STM32 USART Driver Date: Tue, 7 Apr 2015 09:56:42 +0200 Message-ID: References: <1428080481-18591-1-git-send-email-mcoquelin.stm32@gmail.com> <1428080481-18591-11-git-send-email-mcoquelin.stm32@gmail.com> <1428083006.13180.35.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-wg0-f51.google.com ([74.125.82.51]:36001 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751242AbbDGH4o (ORCPT ); Tue, 7 Apr 2015 03:56:44 -0400 In-Reply-To: <1428083006.13180.35.camel@perches.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Joe Perches Cc: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Geert Uytterhoeven , Rob Herring , Philipp Zabel , Linus Walleij , Arnd Bergmann , Stefan Agner , Peter Meerwald , Paul Bolle , Peter Hurley , Andy Shevchenko , Chanwoo Choi , Russell King , Daniel Lezcano , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Thomas Gleixner , Greg Kroah-Hartman 2015-04-03 19:43 GMT+02:00 Joe Perches : > On Fri, 2015-04-03 at 19:01 +0200, Maxime Coquelin wrote: >> This drivers adds support to the STM32 USART controller, which is a >> standard serial driver. > > trivia: > >> diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c > [] >> +static struct uart_ops stm32_uart_ops = { > > could be const i would even say, should be const. > > and it could be updated in a separate patch later too. > Nope, I will send another version anyway, so it will be part of the v6. Thanks for the review, Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753261AbbDGH4z (ORCPT ); Tue, 7 Apr 2015 03:56:55 -0400 Received: from mail-wg0-f51.google.com ([74.125.82.51]:36001 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751242AbbDGH4o (ORCPT ); Tue, 7 Apr 2015 03:56:44 -0400 MIME-Version: 1.0 In-Reply-To: <1428083006.13180.35.camel@perches.com> References: <1428080481-18591-1-git-send-email-mcoquelin.stm32@gmail.com> <1428080481-18591-11-git-send-email-mcoquelin.stm32@gmail.com> <1428083006.13180.35.camel@perches.com> Date: Tue, 7 Apr 2015 09:56:42 +0200 Message-ID: Subject: Re: [PATCH v5 10/15] serial: stm32-usart: Add STM32 USART Driver From: Maxime Coquelin To: Joe Perches Cc: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Geert Uytterhoeven , Rob Herring , Philipp Zabel , Linus Walleij , Arnd Bergmann , Stefan Agner , Peter Meerwald , Paul Bolle , Peter Hurley , Andy Shevchenko , Chanwoo Choi , Russell King , Daniel Lezcano , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Antti Palosaari , Tejun Heo , Will Deacon , Nikolay Borisov , Rusty Russell , Kees Cook , Michal Marek , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-serial@vger.kernel.org" , Linux-Arch , "linux-api@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2015-04-03 19:43 GMT+02:00 Joe Perches : > On Fri, 2015-04-03 at 19:01 +0200, Maxime Coquelin wrote: >> This drivers adds support to the STM32 USART controller, which is a >> standard serial driver. > > trivia: > >> diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c > [] >> +static struct uart_ops stm32_uart_ops = { > > could be const i would even say, should be const. > > and it could be updated in a separate patch later too. > Nope, I will send another version anyway, so it will be part of the v6. Thanks for the review, Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 From: mcoquelin.stm32@gmail.com (Maxime Coquelin) Date: Tue, 7 Apr 2015 09:56:42 +0200 Subject: [PATCH v5 10/15] serial: stm32-usart: Add STM32 USART Driver In-Reply-To: <1428083006.13180.35.camel@perches.com> References: <1428080481-18591-1-git-send-email-mcoquelin.stm32@gmail.com> <1428080481-18591-11-git-send-email-mcoquelin.stm32@gmail.com> <1428083006.13180.35.camel@perches.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 2015-04-03 19:43 GMT+02:00 Joe Perches : > On Fri, 2015-04-03 at 19:01 +0200, Maxime Coquelin wrote: >> This drivers adds support to the STM32 USART controller, which is a >> standard serial driver. > > trivia: > >> diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c > [] >> +static struct uart_ops stm32_uart_ops = { > > could be const i would even say, should be const. > > and it could be updated in a separate patch later too. > Nope, I will send another version anyway, so it will be part of the v6. Thanks for the review, Maxime