From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v8 14/16] ARM: dts: Introduce STM32F429 MCU Date: Wed, 20 May 2015 18:17:34 +0200 Message-ID: References: <1431158038-3813-1-git-send-email-mcoquelin.stm32@gmail.com> <2282066.NWoIT9ZyLc@wuerfel> <13641152.Yt4ZI3oT6L@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-wi0-f182.google.com ([209.85.212.182]:33302 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752268AbbETQRg (ORCPT ); Wed, 20 May 2015 12:17:36 -0400 In-Reply-To: <13641152.Yt4ZI3oT6L@wuerfel> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Arnd Bergmann , Philipp Zabel , Daniel Thompson , Maxime Ripard Cc: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Geert Uytterhoeven , Rob Herring , Linus Walleij , Stefan Agner , Peter Meerwald , Paul Bolle , Peter Hurley , Andy Shevchenko , Chanwoo Choi , Russell King , Daniel Lezcano , Joe Perches , Vladimir Zapolskiy , Lee Jones , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Thomas Gleixner Hi Arnd, Philipp, 2015-05-13 21:11 GMT+02:00 Arnd Bergmann : > Ideally the binding should follow closely what is documented > in the data sheet. > Daniel and myself would like your opinion about this binding: rcc: rcc@40023800 { #reset-cells = <1>; #clock-cells = <2>; compatible = "st,stm32-rcc"; reg = <0x40023800 0x10>, <0x40023810 0x20>, <0x40023830 0x20>; reg-names = "clock-cfg", "reset", "clock-gates"; }; It would solve a problem Daniel is facing due to conflicting mem region when clock and reset drivers are enabled, as both would reserve the same region. Also, it would make the reset driver very generic. Doing that, we could even create a generic-reset.c driver that would be used by STM32 and Sunxi (at least). In the probe function, it would check the number of reg resources. If a single resource is passed, it would take it, else it would look the one named "reset". The driver and bindings would be the same for the two families, and the bindings would be backward compatible with sunxi ones. Philip, Arnd, what do you think? Kind regards, Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755247AbbETQRm (ORCPT ); Wed, 20 May 2015 12:17:42 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:33302 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752268AbbETQRg (ORCPT ); Wed, 20 May 2015 12:17:36 -0400 MIME-Version: 1.0 In-Reply-To: <13641152.Yt4ZI3oT6L@wuerfel> References: <1431158038-3813-1-git-send-email-mcoquelin.stm32@gmail.com> <2282066.NWoIT9ZyLc@wuerfel> <13641152.Yt4ZI3oT6L@wuerfel> Date: Wed, 20 May 2015 18:17:34 +0200 Message-ID: Subject: Re: [PATCH v8 14/16] ARM: dts: Introduce STM32F429 MCU From: Maxime Coquelin To: Arnd Bergmann , Philipp Zabel , Daniel Thompson , Maxime Ripard Cc: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Geert Uytterhoeven , Rob Herring , Linus Walleij , Stefan Agner , Peter Meerwald , Paul Bolle , Peter Hurley , Andy Shevchenko , Chanwoo Choi , Russell King , Daniel Lezcano , Joe Perches , Vladimir Zapolskiy , Lee Jones , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Antti Palosaari , Tejun Heo , Will Deacon , Nikolay Borisov , Rusty Russell , Kees Cook , Michal Marek , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-serial@vger.kernel.org" , Linux-Arch , "linux-api@vger.kernel.org" , Nicolae Rosia , Kamil Lulko Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, Philipp, 2015-05-13 21:11 GMT+02:00 Arnd Bergmann : > Ideally the binding should follow closely what is documented > in the data sheet. > Daniel and myself would like your opinion about this binding: rcc: rcc@40023800 { #reset-cells = <1>; #clock-cells = <2>; compatible = "st,stm32-rcc"; reg = <0x40023800 0x10>, <0x40023810 0x20>, <0x40023830 0x20>; reg-names = "clock-cfg", "reset", "clock-gates"; }; It would solve a problem Daniel is facing due to conflicting mem region when clock and reset drivers are enabled, as both would reserve the same region. Also, it would make the reset driver very generic. Doing that, we could even create a generic-reset.c driver that would be used by STM32 and Sunxi (at least). In the probe function, it would check the number of reg resources. If a single resource is passed, it would take it, else it would look the one named "reset". The driver and bindings would be the same for the two families, and the bindings would be backward compatible with sunxi ones. Philip, Arnd, what do you think? Kind regards, Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 From: mcoquelin.stm32@gmail.com (Maxime Coquelin) Date: Wed, 20 May 2015 18:17:34 +0200 Subject: [PATCH v8 14/16] ARM: dts: Introduce STM32F429 MCU In-Reply-To: <13641152.Yt4ZI3oT6L@wuerfel> References: <1431158038-3813-1-git-send-email-mcoquelin.stm32@gmail.com> <2282066.NWoIT9ZyLc@wuerfel> <13641152.Yt4ZI3oT6L@wuerfel> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Arnd, Philipp, 2015-05-13 21:11 GMT+02:00 Arnd Bergmann : > Ideally the binding should follow closely what is documented > in the data sheet. > Daniel and myself would like your opinion about this binding: rcc: rcc at 40023800 { #reset-cells = <1>; #clock-cells = <2>; compatible = "st,stm32-rcc"; reg = <0x40023800 0x10>, <0x40023810 0x20>, <0x40023830 0x20>; reg-names = "clock-cfg", "reset", "clock-gates"; }; It would solve a problem Daniel is facing due to conflicting mem region when clock and reset drivers are enabled, as both would reserve the same region. Also, it would make the reset driver very generic. Doing that, we could even create a generic-reset.c driver that would be used by STM32 and Sunxi (at least). In the probe function, it would check the number of reg resources. If a single resource is passed, it would take it, else it would look the one named "reset". The driver and bindings would be the same for the two families, and the bindings would be backward compatible with sunxi ones. Philip, Arnd, what do you think? Kind regards, Maxime