From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v8 07/16] drivers: reset: Add STM32 reset driver Date: Thu, 21 May 2015 09:46:34 +0200 Message-ID: References: <1431158038-3813-1-git-send-email-mcoquelin.stm32@gmail.com> <1431158038-3813-8-git-send-email-mcoquelin.stm32@gmail.com> <555D1C7D.1060205@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wg0-f48.google.com ([74.125.82.48]:33203 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751569AbbEUHqg convert rfc822-to-8bit (ORCPT ); Thu, 21 May 2015 03:46:36 -0400 In-Reply-To: <555D1C7D.1060205@suse.de> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: =?UTF-8?Q?Andreas_F=C3=A4rber?= Cc: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Geert Uytterhoeven , Rob Herring , Philipp Zabel , Linus Walleij , Arnd Bergmann , Stefan Agner , Peter Meerwald , Paul Bolle , Peter Hurley , Andy Shevchenko , Chanwoo Choi , Russell King , Daniel Lezcano , Joe Perches , Vladimir Zapolskiy , Lee Jones , Daniel Thompson , Mark Rutland , "linux-doc@vger.kernel.org" , Will Deacon , Nikolay 2015-05-21 1:45 GMT+02:00 Andreas F=C3=A4rber : > Am 09.05.2015 um 09:53 schrieb Maxime Coquelin: >> +static const struct of_device_id stm32_reset_dt_ids[] =3D { >> + { .compatible =3D "st,stm32-rcc", }, >> + { /* sentinel */ }, >> +}; >> +MODULE_DEVICE_TABLE(of, sstm32_reset_dt_ids); > > Typo. Indeed, thanks for pointing this out. > > IIUC the timer depends on the reset controller, so it must be built i= n > anyway, and that's what's enforced in the Makefile above. Drop the li= ne? > Agree it must be built-in. I will fix that in next version. Thanks for the review, Maxime -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754716AbbEUHqn (ORCPT ); Thu, 21 May 2015 03:46:43 -0400 Received: from mail-wg0-f48.google.com ([74.125.82.48]:33203 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751569AbbEUHqg convert rfc822-to-8bit (ORCPT ); Thu, 21 May 2015 03:46:36 -0400 MIME-Version: 1.0 In-Reply-To: <555D1C7D.1060205@suse.de> References: <1431158038-3813-1-git-send-email-mcoquelin.stm32@gmail.com> <1431158038-3813-8-git-send-email-mcoquelin.stm32@gmail.com> <555D1C7D.1060205@suse.de> Date: Thu, 21 May 2015 09:46:34 +0200 Message-ID: Subject: Re: [PATCH v8 07/16] drivers: reset: Add STM32 reset driver From: Maxime Coquelin To: =?UTF-8?Q?Andreas_F=C3=A4rber?= Cc: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Geert Uytterhoeven , Rob Herring , Philipp Zabel , Linus Walleij , Arnd Bergmann , Stefan Agner , Peter Meerwald , Paul Bolle , Peter Hurley , Andy Shevchenko , Chanwoo Choi , Russell King , Daniel Lezcano , Joe Perches , Vladimir Zapolskiy , Lee Jones , Daniel Thompson , Mark Rutland , "linux-doc@vger.kernel.org" , Will Deacon , Nikolay Borisov , "linux-api@vger.kernel.org" , Jiri Slaby , Linux-Arch , Jonathan Corbet , Mauro Carvalho Chehab , Kamil Lulko , Antti Palosaari , "linux-serial@vger.kernel.org" , "devicetree@vger.kernel.org" , Kees Cook , Pawel Moll , Ian Campbell , Rusty Russell , "linux-gpio@vger.kernel.org" , Thomas Gleixner , Nicolae Rosia , "linux-arm-kernel@lists.infradead.org" , Michal Marek , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Kumar Gala , Tejun Heo , Andrew Morton , "David S. Miller" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2015-05-21 1:45 GMT+02:00 Andreas Färber : > Am 09.05.2015 um 09:53 schrieb Maxime Coquelin: >> +static const struct of_device_id stm32_reset_dt_ids[] = { >> + { .compatible = "st,stm32-rcc", }, >> + { /* sentinel */ }, >> +}; >> +MODULE_DEVICE_TABLE(of, sstm32_reset_dt_ids); > > Typo. Indeed, thanks for pointing this out. > > IIUC the timer depends on the reset controller, so it must be built in > anyway, and that's what's enforced in the Makefile above. Drop the line? > Agree it must be built-in. I will fix that in next version. Thanks for the review, Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 From: mcoquelin.stm32@gmail.com (Maxime Coquelin) Date: Thu, 21 May 2015 09:46:34 +0200 Subject: [PATCH v8 07/16] drivers: reset: Add STM32 reset driver In-Reply-To: <555D1C7D.1060205@suse.de> References: <1431158038-3813-1-git-send-email-mcoquelin.stm32@gmail.com> <1431158038-3813-8-git-send-email-mcoquelin.stm32@gmail.com> <555D1C7D.1060205@suse.de> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 2015-05-21 1:45 GMT+02:00 Andreas F?rber : > Am 09.05.2015 um 09:53 schrieb Maxime Coquelin: >> +static const struct of_device_id stm32_reset_dt_ids[] = { >> + { .compatible = "st,stm32-rcc", }, >> + { /* sentinel */ }, >> +}; >> +MODULE_DEVICE_TABLE(of, sstm32_reset_dt_ids); > > Typo. Indeed, thanks for pointing this out. > > IIUC the timer depends on the reset controller, so it must be built in > anyway, and that's what's enforced in the Makefile above. Drop the line? > Agree it must be built-in. I will fix that in next version. Thanks for the review, Maxime