All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jheng-Jhong Wu <goodwater.wu@gmail.com>
To: dan.carpenter@oracle.com
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: mt29f_spinand: fix memory leak while programming pages
Date: Thu, 2 Aug 2018 11:42:30 +0800	[thread overview]
Message-ID: <CALtPoQA7EdUDmN26Z406J6gFFx4XLUy1zTb65x8MgTVpoG57tg@mail.gmail.com> (raw)
In-Reply-To: <CALtPoQCyoe5V0m5=3K1XeZm41aDCaJ0rmYU-a=qkm=Yb8jgMxg@mail.gmail.com>

Dear Dan,

I know what you wrote, but before the spinand device is removed and
freed memory automatically, programming pages may do many many times.
Assume we erase and rewrite a large part of the flash, then
spinand_program_page() might exhaust memory if memory is not large
enough.
In fact, OOM indeed occured when I tested programming multi-pages by
mtd_debug tool.
If OOM was not caused by devm_kzalloc() in spinand_program_page(),
what may exhaust memory?

Best Regards,
─────────────────────────
Jheng-Jhong Wu (Victor Wu)
E-mail: goodwater.wu@gmail.com
─────────────────────────

  parent reply	other threads:[~2018-08-02  3:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01  9:44 [PATCH] staging: mt29f_spinand: fix memory leak while programming pages Jheng-Jhong Wu
2018-08-01 11:45 ` Dan Carpenter
     [not found]   ` <CALtPoQCyoe5V0m5=3K1XeZm41aDCaJ0rmYU-a=qkm=Yb8jgMxg@mail.gmail.com>
2018-08-02  3:42     ` Jheng-Jhong Wu [this message]
2018-08-02  6:12       ` Dan Carpenter
2018-08-02  7:51 ` [PATCH v2] " Jheng-Jhong Wu
2018-08-02  8:02   ` Greg Kroah-Hartman
2018-08-02  8:31     ` Jheng-Jhong Wu
2018-08-02  8:41       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALtPoQA7EdUDmN26Z406J6gFFx4XLUy1zTb65x8MgTVpoG57tg@mail.gmail.com \
    --to=goodwater.wu@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.