Re: [Outreachy kernel] [PATCH v2 02/10] Staging: media: atomisp: Remove useless 'out of memory' messages

From: Georgiana Chelu <georgiana.chelu93@gmail.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 outreachy-kernel <outreachy-kernel@googlegroups.com>,
	 Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [Outreachy kernel] [PATCH v2 02/10] Staging: media: atomisp: Remove useless 'out of memory' messages
Date: Sun, 1 Oct 2017 14:56:13 +0300	[thread overview]
Message-ID: <CALta04xHah1KVgOBfQBPXzvAqhf4pkESi1-Q060Hf2tHS-RLyg@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1710011346330.2031@hadrien>

On 1 October 2017 at 14:47, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Sun, 1 Oct 2017, Georgiana Chelu wrote:
>
>> On 29 September 2017 at 16:34, Greg Kroah-Hartman
>> <gregkh@linuxfoundation.org> wrote:
>> > On Tue, Sep 26, 2017 at 09:01:30AM -0700, Georgiana Chelu wrote:
>> >> OOM (Out Of Memory Manager) reports memory allocation fails,
>> >> so there is no need for the error messages.
>> >>
>> >> Signed-off-by: Georgiana Chelu <georgiana.chelu93@gmail.com>
>> >> ---
>> >>
>> >> Changes in v2:
>> >> * this is a new patch added to the patchset
>> >>
>> >>  drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c | 4 ----
>> >>  1 file changed, 4 deletions(-)
>> >>
>> >> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
>> >> index 5232327..8667466 100644
>> >> --- a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
>> >> +++ b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
>> >> @@ -728,7 +728,6 @@ static int alloc_private_pages(struct hmm_buffer_object *bo,
>> >>       bo->page_obj = kmalloc_array(pgnr, sizeof(struct hmm_page_object),
>> >>                               GFP_KERNEL);
>> >>       if (unlikely(!bo->page_obj)) {
>> >> -             dev_err(atomisp_dev, "out of memory for bo->page_obj\n");
>> >>               return -ENOMEM;
>> >>       }
>> >
>> > The { } should also be removed when you do this.  Please fix that up
>> > here.
>> >
>>
>> This fix is done in
>> [PATCH v2 07/10] Staging: media: atomisp:
>>     Remove braces {} for single statement blocks
>>
>> Do you say that is better to remove the {} in 02/10?
>
> Yes.  When you make a change, you should clean immediately up any
> checkpatch warnings that you introduce.
>

I see .. Thank you very much! I will resend the patchset.

Georgiana

> julia
>
>>
>> Thank you,
>> Georgiana
>>
>> > thanks,
>> >
>> > greg k-h
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CALta04wMbvf3BDh9%2B_7TT_VbnApMt3HfqwD%2B_4qSNBpY2xaUQQ%40mail.gmail.com.
>> For more options, visit https://groups.google.com/d/optout.
>>