From mboxrd@z Thu Jan  1 00:00:00 1970
From: Oscar Gomez Fuente <oscargomezf@gmail.com>
Date: Mon, 17 Oct 2016 17:33:36 +0200
Subject: [U-Boot] [PATCH] ARM: zynq: Extend picozed board support
In-Reply-To: <16c3b024-d883-2251-4fbf-3ecdea0e818a@xilinx.com>
References: <1476703132-31975-1-git-send-email-oscargomezf@gmail.com>
 <3b0080c5-2511-dd4d-f19f-e5ccbb7bbe89@xilinx.com>
 <CALtfCQa6bOBJv1XTY53C+mX1dcnMAyTHQuRGNFXO208ynkT+nA@mail.gmail.com>
 <16c3b024-d883-2251-4fbf-3ecdea0e818a@xilinx.com>
Message-ID: <CALtfCQYdahnHHHbYueVnoAmJY80MZY8eXwj53RLK5P6dNh+VPQ@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Ok Michal,

Then you're suggesting change the zynq-picozed.dts file to:

diff --git a/arch/arm/dts/zynq-picozed.dts b/arch/arm/dts/zynq-picozed.dts
index 3408df8..d8ed298 100644
--- a/arch/arm/dts/zynq-picozed.dts
+++ b/arch/arm/dts/zynq-picozed.dts
@@ -14,6 +14,8 @@

        aliases {
                serial0 = &uart1;
+               spi0 = &qspi;
+               ethernet0 = &gem0;
        };

        memory {
@@ -26,3 +28,18 @@
        u-boot,dm-pre-reloc;
        status = "okay";
 };
+
+&qspi {
+       u-boot,dm-pre-reloc;
+       status = "okay";
+};
+
+&gem0 {
+       status = "okay";
+       phy-mode = "rgmii-id";
+       phy-handle = <&ethernet_phy>;
+
+       ethernet_phy: ethernet-phy at 0 {
+               reg = <0>;
+       };
+};

And add a new dts file with the configuration of the PizoZed FMC Carrier V2
(in this case V2. Avnet has two PicoZed FMC carriers V1 and V2). For
example: zynq-picozed-fmc-v2.dts

*
 * Avnet PicoZed FMC carrier V2 DTS
 *
 * Copyright (C) 2015 Xilinx, Inc.
 *
 * SPDX-License-Identifier: GPL-2.0+
 */
/dts-v1/;
#include "zynq-picozed.dts"

/ {
compatible = "xlnx,zynq-picozed", "xlnx,zynq-7000";

aliases {
mmc0 = &sdhci0;
};
};

&sdhci0 {
u-boot,dm-pre-reloc;
status = "okay";
};

Do you think the is the best way?


Best regards.

Oscar Gomez Fuente

On 17 October 2016 at 16:36, Michal Simek <michal.simek@xilinx.com> wrote:

> On 17.10.2016 16:03, Oscar Gomez Fuente wrote:
> > Hi everyone,
> >
> > Sorry for the errors, I know is a very simple patch but it's my first
> time.
> >
> > ------------------------------------------------------------
> ------------------------------
> >> Add missing DT nodes.
> >>
> >> Signed-off-by: Oscar Gomez Fuente <oscargomezf@gmail.com>
> >> ---
> >>  arch/arm/dts/zynq-picozed.dts | 20 ++++++++++++++++++++
> >>  1 file changed, 20 insertions(+)
> >>
> >> diff --git a/arch/arm/dts/zynq-picozed.dts
> b/arch/arm/dts/zynq-picozed.dts
> >> index 3408df8..5f703a2 100644
> >> --- a/arch/arm/dts/zynq-picozed.dts
> >> +++ b/arch/arm/dts/zynq-picozed.dts
> >> @@ -26,3 +26,23 @@
> >>       u-boot,dm-pre-reloc;
> >>       status = "okay";
> >>  };
> >> +
> >
> > please also extended aliases list.
> > ------------------------------------------------------------
> ------------------------------
> > -> Ok, Understood.
> >
> > ------------------------------------------------------------
> ------------------------------
> >> +&gem0 {
> >> +     status = "okay";
> >> +     phy-mode = "rgmii-id";
> >> +     phy-handle = <&ethernet_phy>;
> >> +
> >> +     ethernet_phy: ethernet-phy at 0 {
> >> +             reg = <0>;
> >
> > I expect that this is on board 88e1512
> > ------------------------------------------------------------
> ------------------------------
> > -> Yes, this is on board 88e1512. Do I have to modify anything? I think
> > that's good, isn't it?
>
> nope.
>
> >
> > ------------------------------------------------------------
> ------------------------------
> >> +     };
> >> +};
> >> +
> >> +&qspi {
> >> +     u-boot,dm-pre-reloc;
> >> +     status = "okay";
> >> +     };
> >
> > wrong indentation here.
> > ------------------------------------------------------------
> ------------------------------
> > -> Ok, sorry.
> >
> > ------------------------------------------------------------
> ------------------------------
> >> +
> >> +&sdhci0 {
> >
> > is this sd0 or sd1 hard IP? I expect that this is emmc right?
> > ------------------------------------------------------------
> ------------------------------
> > -> sdhci0 is sd0 IP, the Sd Card on the PicoZed FMC Carrier.
>
>
> Then this shouldn't be the part of this file. picozed is SOM and you
> should describe all stuff which are just on this module.
> If you want to support Picozed with any carrier board you should
> describe it separately. The best carrier and include picozed dts.
>
>
> >
> >> +     u-boot,dm-pre-reloc;
> >> +     status = "okay";
> >> +};
> >>
> >
> > If everything is ok now, I'll send the patch to mainline mailing list
> > instead of xilinx one.
>
> I have changed emails.
>
> >
> >
> > Another question: Do you know if there is any perl script to check dts
> > files before sending it? I've run the ./scripts/checkpatch.pl to check
> the
> > arch/arm/dts/zynq-picozed.dts file and I didn't get any error.
>
> checkpatch is not designed to parse DTS files and I am not sure if there
> is any parser.
>
> Thanks,
> Michal
>