From mboxrd@z Thu Jan  1 00:00:00 1970
From: Oscar Gomez Fuente <oscargomezf@gmail.com>
Date: Tue, 18 Oct 2016 09:28:06 +0200
Subject: [U-Boot] [PATCH] ARM: zynq: Extend picozed board support
In-Reply-To: <4f25fc27-6606-354f-6232-a7958af92929@xilinx.com>
References: <1476703132-31975-1-git-send-email-oscargomezf@gmail.com>
 <3b0080c5-2511-dd4d-f19f-e5ccbb7bbe89@xilinx.com>
 <CALtfCQa6bOBJv1XTY53C+mX1dcnMAyTHQuRGNFXO208ynkT+nA@mail.gmail.com>
 <16c3b024-d883-2251-4fbf-3ecdea0e818a@xilinx.com>
 <CALtfCQYdahnHHHbYueVnoAmJY80MZY8eXwj53RLK5P6dNh+VPQ@mail.gmail.com>
 <4f25fc27-6606-354f-6232-a7958af92929@xilinx.com>
Message-ID: <CALtfCQbPWEN11wbGXcJvHWuLeXOP9w55bxKVd+dKO+s92qfR9w@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi everyone,

In my opinion, use the picozed without a carrier board it doesn't make
 sense. You always are going to need a carrier board. Avnet has two models
the PicoZed FMC Carrier V2 and the PicoZed FMC Carrier V1. And the company
I'm working, it is going to desing a custom carrier board according to our
necessity.

So maybe, it's better to have only two .dts files. zynq-picozed-fmc-v2.dts
and zynq-picozed-fmc-v1.dts.

If we decide to have the zynq-picozed.dtsi and zynq-picozed-fmc-v2.dts,
we'll have to decide what hardware description is going to be in the
zynq-picozed-fmc-v2.dts and what hardware description is going to be
in zynq-picozed.dtsi.

for example the spi0 hw is in the picozed  board, but the SD (mmc0), eth0
(gem0) and serial0 (uart1) the HW is in the picoZed but the connectors are
in the PicoZed FMC Carrier V2, so It's a little bit confused if this HW
description has to be on the zynq-picozed.dtsi file or in the
zynq-picozed-fmc-v2.dts file. Do you know what I mean?

Please let me see you opinions about that.

Best regards.

[image: photo] ?scar G?mez Fuente
Electronic Engineer & Degree in Physical Sciences
Mobile: 659.28.97.90
Email: oscargomezf at gmail.com
Website: www.oscargomezf.com
<http://facebook.com/oscargomezf>  <http://plus.google.com/oscargomezf>
<http://us.linkedin.com/in/oscargomezf>
<http://twitter.com/oscargomezf_com>

On 18 October 2016 at 09:00, Michal Simek <michal.simek@xilinx.com> wrote:

> On 17.10.2016 17:33, Oscar Gomez Fuente wrote:
> > Ok Michal,
> >
> > Then you're suggesting change the zynq-picozed.dts file to:
>
> dtsi.
>
> >
> > diff --git a/arch/arm/dts/zynq-picozed.dts b/arch/arm/dts/zynq-picozed.
> dts
> > index 3408df8..d8ed298 100644
> > --- a/arch/arm/dts/zynq-picozed.dts
> > +++ b/arch/arm/dts/zynq-picozed.dts
> > @@ -14,6 +14,8 @@
> >
> >         aliases {
> >                 serial0 = &uart1;
> > +               spi0 = &qspi;
> > +               ethernet0 = &gem0;
> >         };
> >
> >         memory {
> > @@ -26,3 +28,18 @@
> >         u-boot,dm-pre-reloc;
> >         status = "okay";
> >  };
> > +
> > +&qspi {
> > +       u-boot,dm-pre-reloc;
> > +       status = "okay";
> > +};
>
> keep node names sorted.
>
> > +
> > +&gem0 {
> > +       status = "okay";
> > +       phy-mode = "rgmii-id";
> > +       phy-handle = <&ethernet_phy>;
> > +
> > +       ethernet_phy: ethernet-phy at 0 {
> > +               reg = <0>;
> > +       };
> > +};
> >
> > And add a new dts file with the configuration of the PizoZed FMC Carrier
> V2
> > (in this case V2. Avnet has two PicoZed FMC carriers V1 and V2). For
> > example: zynq-picozed-fmc-v2.dts
> >
> > *
> >  * Avnet PicoZed FMC carrier V2 DTS
> >  *
> >  * Copyright (C) 2015 Xilinx, Inc.
> >  *
> >  * SPDX-License-Identifier: GPL-2.0+
> >  */
> > /dts-v1/;
>
> Depends how zynq-picozed.dtsi will look but this line above can be
> already there.
>
> > #include "zynq-picozed.dts"
> >
> > / {
> > compatible = "xlnx,zynq-picozed", "xlnx,zynq-7000";
>
> here
> "xlnx,zynq-picozed-fmc-v2", "xlnx,zynq-picozed", "xlnx,zynq-7000";
>
>
> >
> > aliases {
> > mmc0 = &sdhci0;
> > };
> > };
> >
> > &sdhci0 {
> > u-boot,dm-pre-reloc;
> > status = "okay";
> > };
> >
> > Do you think the is the best way?
>
> with changes above it looks reasonable.
>
> Thanks,
> Michal
>
>