From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCD9EC54E71 for ; Fri, 22 Mar 2024 05:20:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E06aULEtnHA7fYwZqq2Pi2jcMMw46hzOmVMwA/orZ7U=; b=j0eQXfDBLO4Cwt wR3YuIqtPAg5Ew+ZOONC6vpfwSUKLhLzdprzCRO160vOD4EbP3qw7/noPL9je7ObwXd515gGsud3v AzEUInKvpl+t/DKsf+15VW5fxUbaC37iArtgcIz1uuP8OB2reZ7tSXLVWDawClcLbDaO/ngaqBeXK 0B35XFJfaArudZsjjk7rPmz7skxzyfb84FSQOeEVIwkHcLaBdwKl7usPa0/Nox+zToH5UzpuCyEDs 1m7CjD6q1lca++XZ791KvY45Czi8XmFvCljgFTbWK1g5S5RJhqHVSAXn59KSZ4ldx87hAtfAQZVMh Kc5QTojUqAHC8uYG51nA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnXKY-00000005osD-03zB; Fri, 22 Mar 2024 05:20:38 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnXKV-00000005orU-0MBE for kexec@lists.infradead.org; Fri, 22 Mar 2024 05:20:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711084833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QPWt/vpen20Uq0Su+r5r4SqWWuc1vun1fgMIbeuBdwM=; b=aLovmRxDhZLT2EsIjp2Bj6rgix+wr4TuaofIIuh1eSPY1rGsu+nxVfB3e3TP4U/iU5WYbJ oB9D0Y9Q/atxlcKJcihcNogojna0mf5bN1T83D5ktXz7blolB4ioGoZJyOJ1R33ZC1evuw y9iaZzGnTnIzahlw62T0DuzdWD59y88= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-364-A90LMcigOXOQYjriyg37uw-1; Fri, 22 Mar 2024 01:20:30 -0400 X-MC-Unique: A90LMcigOXOQYjriyg37uw-1 Received: by mail-il1-f198.google.com with SMTP id e9e14a558f8ab-366b2ee3b5bso6112935ab.1 for ; Thu, 21 Mar 2024 22:20:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711084829; x=1711689629; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QPWt/vpen20Uq0Su+r5r4SqWWuc1vun1fgMIbeuBdwM=; b=aydxE0sJkPi3swb6SpjheoOdkMX/kKrcvzqGw+5YWut2bC/w6W9JinO2w+gP7ToBfU vdH4Sz0wIOrfRU076a/cpSi8lMNr5J3i0yzZVDD8vWJM6e6/vDFmWjZe+z4c2x8pNcnS zW8C4QuVoqLXGVRDASF4JDWfAMN11SHLNTf2DSNOCS5Kmc7z/ceAatxMDpoyMZma4aSS krlmWT5MoPHqSJsEBmo2C0wqgRIDWZ863FDUv1pswDIE0TZkPWuLNOfWfD12dLvREK2v 4Czbs8LvksfcV1I+kFjwMkTqmkfjqmWpz148brDlaFtYN7QKLe1ydaxdn5TY6jLjbAs8 4Aag== X-Forwarded-Encrypted: i=1; AJvYcCVE1T7a5+mIEQTDenaP4vozLvjNNSQquGDrLr3iENM98CfjgJfNqf2KeWu0Uyv7O5JGQWGl7p8SJHhZeZPXJ94gtf62P6ZHrUzU X-Gm-Message-State: AOJu0YxIqOohJZnhXkYYGomzrz92Ytcl9Ds0N0DGAphzDDp8s59H+QgZ bbZoU2fA6y+zML+8LBqWHFtaucaXO7iMdSag18bL3lO00+snjDbpRO5dH8shS6rjFewyFl9C5fC ZSLiuxeZGzCgH9W+lOdbU7OIPcA3NjCKX69s+iZNkggVpIXgH40l15RjMESPtbohido4kLYlkRt J5euxc12PakWI2B5efpTipfVasTFBAy5BxJ1uu16nV X-Received: by 2002:a92:ca06:0:b0:365:2bd4:2f74 with SMTP id j6-20020a92ca06000000b003652bd42f74mr1414327ils.0.1711084829658; Thu, 21 Mar 2024 22:20:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHcqpN7yjbXB0akaKxrIaGNwP9eSMrNe1nhA0u4mzAyyJPP5E6Gj96qz1F7MFLE+aoAY3qt4Hni+gmE6ZFGN44= X-Received: by 2002:a92:ca06:0:b0:365:2bd4:2f74 with SMTP id j6-20020a92ca06000000b003652bd42f74mr1414309ils.0.1711084829375; Thu, 21 Mar 2024 22:20:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Young Date: Fri, 22 Mar 2024 13:20:40 +0800 Message-ID: Subject: Re: [PATCH V2] x86/kexec: do not update E820 kexec table for setup_data To: Jiri Bohac Cc: x86@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-kernel@vger.kernel.org, kexec@lists.infradead.org, Baoquan He , Eric Biederman , "Huang, Kai" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240321_222035_233609_85EC8697 X-CRM114-Status: GOOD ( 16.77 ) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org > > Your tree is missing this recent commit: > > 7fd817c906503b6813ea3b41f5fdf4192449a707 ("x86/e820: Don't > > reserve SETUP_RNG_SEED in e820"). > > > > Wouldn't this fix [/paper over] your problem as well? I.e., isn't > > SETUP_RNG_SEED the setup_data item that's causing your problem? > > Thanks for catching this, I will rebase and repost. > > But it does not "fix" the problem as my problem is related to the > other setup_data > range, I think it is SETUP_PCI (not 100% sure, but it is certainly not RNG_SEED) > The webmail reply broke the lines randomly, sorry for that. I have resent a rebased version. And I also confirmed that in my case it was SETUP_PCI caused the issue. Note, this SETUP_PCI is from previous physical bootup, the old kernel reserved it in kexec e820, it is not the RNG_SEED which was passed in by kexec. I believe the RND_SEED region could cause issues only on the 3rd+ boot with a kernel without the commit you mentioned. It is a little tricky, I suppose not obvious to understand.. Thanks Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81CA51A38FE for ; Fri, 22 Mar 2024 05:20:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711084836; cv=none; b=PF94zDSISB4H5LDDxvvF+Shrh1ZzQ2lUy+JxatV/E64BxwYBPgh1h3iz1h6I/ATnYekXGWmQKS8EOnSFRJUK9nsEVW5r+jCqhvBNtEYB+BuQIVm11yZ5kjsT3AubSrpaLyeWDTAMdVgUpIY19AaHDXX7wILhXXmJdFL0Mvl92ls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711084836; c=relaxed/simple; bh=wkY3XvA11A+L3pQyNlA/k6s9pQsd08SfFaSttqTgBUg=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=iFHt9o+1mQSUEphLVcKaxCh+XAn4crwk2OqwUn43d00IIXTqG6s8WX65g6CrQyD2wQjv2b9OcTPS/9FaCCoykJhCSIMR+zxDZysUf5yA1N2gihsR69bVV749iohQ3H39uoj7g+KZf6BoMK/udvPt9pFcmOpzkjvib+3Upy6Dg4Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=aLovmRxD; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aLovmRxD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711084833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QPWt/vpen20Uq0Su+r5r4SqWWuc1vun1fgMIbeuBdwM=; b=aLovmRxDhZLT2EsIjp2Bj6rgix+wr4TuaofIIuh1eSPY1rGsu+nxVfB3e3TP4U/iU5WYbJ oB9D0Y9Q/atxlcKJcihcNogojna0mf5bN1T83D5ktXz7blolB4ioGoZJyOJ1R33ZC1evuw y9iaZzGnTnIzahlw62T0DuzdWD59y88= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-94-PgW4q8yvOeaNFANrd3M0LQ-1; Fri, 22 Mar 2024 01:20:30 -0400 X-MC-Unique: PgW4q8yvOeaNFANrd3M0LQ-1 Received: by mail-il1-f198.google.com with SMTP id e9e14a558f8ab-366b311d172so5190955ab.0 for ; Thu, 21 Mar 2024 22:20:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711084829; x=1711689629; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QPWt/vpen20Uq0Su+r5r4SqWWuc1vun1fgMIbeuBdwM=; b=g9mbiqL5QQrrcC+JyZ1v/PezURCIi5K1Vr+CD6N8AA29Vna0qlMN3KA0mvXFrUGak9 ZoYDNt3o9mojRq+QENKnXzLACSzqwi/YwiSilymGbzwnLmxmbzyzdM/XvHonVJZgNS3P rYUumKaDelnUHkQfSpHjsZS874sURML728YemzTLo5F9JQUYd25G76nEfW7RId+9gGig 8Rcs0i9akTb6qnveEkUy3H9sE5TsRXThosKgd5G9TN+K1wkfc5OFw1ASDDVnXR79DwEo CAjaGtxxnwFx0IbOPIb086AUjJFsiQDTEUMBSq3F/5xpbMc4TyC4j1d1DgMN+87WZPwH rchg== X-Forwarded-Encrypted: i=1; AJvYcCXkV6Gx/MtTiHPMHus9qKr4Wvx32tgCvoFa5vmEQwtUfxXyjyDH0479NDl6421mrrfds2g73BuVx7K+0gmhSE7vJ5MqOmbWfV8m1lZA X-Gm-Message-State: AOJu0YyfzIR2wLTl85VPlvR2Jpx2OPjIbdVPxefj+82XbhOZt/pQYeqI tjNmkjZIRDuI/86ukEYRZImtF53Xr6EB3NKryJVriZIW+5kYYRPGOO9Y9bVwJMH5QFoGpbkfsx0 bi32e2YzXCMrz7Tf784puoP2UdnX7fewgtRraEYEfVW9x801AYLtdTlsX0+ikkVg2Tjei6jMyfL /MKNyuQsmeedARBlP9ksnVanj2JX3d1BM1yvDH X-Received: by 2002:a92:ca06:0:b0:365:2bd4:2f74 with SMTP id j6-20020a92ca06000000b003652bd42f74mr1414328ils.0.1711084829660; Thu, 21 Mar 2024 22:20:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHcqpN7yjbXB0akaKxrIaGNwP9eSMrNe1nhA0u4mzAyyJPP5E6Gj96qz1F7MFLE+aoAY3qt4Hni+gmE6ZFGN44= X-Received: by 2002:a92:ca06:0:b0:365:2bd4:2f74 with SMTP id j6-20020a92ca06000000b003652bd42f74mr1414309ils.0.1711084829375; Thu, 21 Mar 2024 22:20:29 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: In-Reply-To: From: Dave Young Date: Fri, 22 Mar 2024 13:20:40 +0800 Message-ID: Subject: Re: [PATCH V2] x86/kexec: do not update E820 kexec table for setup_data To: Jiri Bohac Cc: x86@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-kernel@vger.kernel.org, kexec@lists.infradead.org, Baoquan He , Eric Biederman , "Huang, Kai" Content-Type: text/plain; charset="UTF-8" > > Your tree is missing this recent commit: > > 7fd817c906503b6813ea3b41f5fdf4192449a707 ("x86/e820: Don't > > reserve SETUP_RNG_SEED in e820"). > > > > Wouldn't this fix [/paper over] your problem as well? I.e., isn't > > SETUP_RNG_SEED the setup_data item that's causing your problem? > > Thanks for catching this, I will rebase and repost. > > But it does not "fix" the problem as my problem is related to the > other setup_data > range, I think it is SETUP_PCI (not 100% sure, but it is certainly not RNG_SEED) > The webmail reply broke the lines randomly, sorry for that. I have resent a rebased version. And I also confirmed that in my case it was SETUP_PCI caused the issue. Note, this SETUP_PCI is from previous physical bootup, the old kernel reserved it in kexec e820, it is not the RNG_SEED which was passed in by kexec. I believe the RND_SEED region could cause issues only on the 3rd+ boot with a kernel without the commit you mentioned. It is a little tricky, I suppose not obvious to understand.. Thanks Dave