From: Stephen Zhang <stephenzhangzsd@gmail.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
natechancellor@gmail.com, clang-built-linux@googlegroups.com,
LKML <linux-kernel@vger.kernel.org>,
Tom Roeder <tmroeder@google.com>,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v1] clang_tools:gen_compile_commands: Change the default source directory
Date: Thu, 11 Feb 2021 21:47:53 +0800 [thread overview]
Message-ID: <CALuz2=eSv2N2Qp7GimLgdWjvWDwDh1Dj0Q7Czm4Br5a50rs4ew@mail.gmail.com> (raw)
In-Reply-To: <20210210182400.GA3502674@ubuntu-m3-large-x86>
Nathan Chancellor <nathan@kernel.org> 于2021年2月11日周四 上午2:24写道:
>
> On Wed, Feb 10, 2021 at 08:15:27PM +0800, Stephen Zhang wrote:
> > Nathan Chancellor <nathan@kernel.org> 于2021年2月10日周三 上午3:27写道:
> >
> > > Just as an FYI, your email was HTML, which means it won't hit LKML.
> >
> >
> > Thanks for pointing that out. The existence of a GFW makes it difficult for
> > me to connect
> > to the mail server. so I use git client to send patches only and reply to
> > emails with
> > gmail web client.
>
> You can configure your Gmail web client to send text responses by
> default by clicking on the three dot menu in the compose window then
> chose the "plain text mode" option.
>
Thanks, this has always been a problem for me.
> The build directory needs to be involved because that is where the .cmd
> files will be but the source directory needs to be known because the
> source files in the .cmd files are relative to the source directory, not
> the build directory. This happens to work in most situations like I
> point out above but not always.
>
> I think that my patch is most likely the way to go unless others feel
> differently. It would be nice if you could give it a go.
>
> Cheers,
> Nathan
Do you mean my patch's failure in some cases is because the build
directoty isn't involved after using "-d" to specify the source directory?
Actually, the build directory has already been involved by the "path"
argument. See:
def main():
for path in paths:
....
if os.path.isdir(path):
cmdfiles = cmdfiles_in_dir(path)
.....
where the value of paths is passed by the "path" argument. Do I miss
something?
Cheers,
Stephen
next prev parent reply other threads:[~2021-02-11 14:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 11:28 [PATCH v1] clang_tools:gen_compile_commands: Change the default source directory Stephen Zhang
2021-02-08 19:54 ` Nathan Chancellor
[not found] ` <CALuz2=d-ENRbWgGYaO_ESEaw5eOVSwkQmkeYBJ-w0Vb3zZ+REg@mail.gmail.com>
2021-02-09 19:27 ` Nathan Chancellor
[not found] ` <CALuz2=dyA_ki98t8VNe2L1UcBXrSoJT1r6j1puEmLn7WrX87XQ@mail.gmail.com>
2021-02-10 18:24 ` Nathan Chancellor
2021-02-11 13:47 ` Stephen Zhang [this message]
2021-02-11 14:15 ` Masahiro Yamada
2021-02-12 11:20 ` Stephen Zhang
2021-02-13 12:45 ` Masahiro Yamada
2021-02-14 11:49 ` Stephen Zhang
2021-02-14 17:09 ` Masahiro Yamada
2021-02-15 11:57 ` Stephen Zhang
2021-02-14 23:28 ` Nathan Chancellor
2021-02-15 11:36 ` Stephen Zhang
2021-02-10 20:32 ` Tom Roeder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALuz2=eSv2N2Qp7GimLgdWjvWDwDh1Dj0Q7Czm4Br5a50rs4ew@mail.gmail.com' \
--to=stephenzhangzsd@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=tmroeder@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.