From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5ADAC07E9E for ; Fri, 9 Jul 2021 17:27:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6852613BD for ; Fri, 9 Jul 2021 17:27:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229552AbhGIR37 (ORCPT ); Fri, 9 Jul 2021 13:29:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbhGIR36 (ORCPT ); Fri, 9 Jul 2021 13:29:58 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8205DC0613DD for ; Fri, 9 Jul 2021 10:27:14 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id u25so9164081ljj.11 for ; Fri, 09 Jul 2021 10:27:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A3BFSbignNESj8/rrwZ1G7zuaCPgGVuO823S/jHyGy0=; b=raXro5aqHVk05FqTrS0rJjDV0MZ5+ERPmzQZfuH4nwxpLbqvs33kwRqpd1Y3wfueAn 13oMZAwMS/vpxqlRC13oy5NBgkRRbSl3Fu51UXlk4PfttNKOME2w6oJ61aE5yP/SwLqo An96A6j5eCxtZEaUfZYKpsyaPZpufz6QEAQxfBeyaZ5K4AWiDHQPINxpSYf77MWMDGJO O1W4afwnIwmK9CpfZybIzXwmVK8krSTUIV3I/B9kMDzTBKTaseBG/LJ3JQeYJh5Tdm5X cAlwgtTckxjr7yAQGgJc1AdMzb5aa+aBL5xSvmoV25k/DvgyefzRjrWC2G3AHuRPtNWA 0iSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A3BFSbignNESj8/rrwZ1G7zuaCPgGVuO823S/jHyGy0=; b=gAIulI1Snf4EchnKWHRPb5gTNg294J8OaGDK6mRdeCFTts/BrFRYcfUBQZHLVw6nAK kFJpfhkUpkBulWiebMBgY6EESuKXfO3y7UoHedWsLhAmgocBuSxRLKlWETUKQrriniV6 3j8XqgpEwOTK37CbK7dHZIlnzprLgR/KzExsI4ybf7mao50zVZg5jdHX+oYcC+gwE9jD yrAVdg9YBMN1qIlexYl9WDofg/L1AlGEhKlXaCB+2gPgz4BuU5mWG5LJQzHAiUlUHwuW qKN619B64DnZNDuMsFrwpljfkDSsnw8VJHPWxsqO05ORaOjqCWNBwWclSL1fdh7APomi VACg== X-Gm-Message-State: AOAM533SICpwKzVHZvXjRi9Lz25MyAI88nsLMMu3OOqurKpnE9m1GcTk Z6muNjEzEWvrTWr/354mvMtAsd8DMrUUbiy5SymnAQ== X-Google-Smtp-Source: ABdhPJxSTF27Vf8rpwGTyQEHiZoBoQsGHn5uAdCOrMmM2Yc/JJMk/btI8xEmJa8aPs/xwKR6xmWlXa18b7sKsYeZYBM= X-Received: by 2002:a2e:8215:: with SMTP id w21mr29626159ljg.160.1625851632594; Fri, 09 Jul 2021 10:27:12 -0700 (PDT) MIME-Version: 1.0 References: <20210709171554.3494654-1-surenb@google.com> In-Reply-To: <20210709171554.3494654-1-surenb@google.com> From: Shakeel Butt Date: Fri, 9 Jul 2021 10:27:01 -0700 Message-ID: Subject: Re: [PATCH v2 1/1] mm, memcg: inline mem_cgroup_{charge/uncharge} to improve disabled memcg config To: Suren Baghdasaryan Cc: Tejun Heo , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Roman Gushchin , Muchun Song , Yang Shi , alexs@kernel.org, Wei Yang , Vlastimil Babka , Jens Axboe , Joonsoo Kim , David Hildenbrand , Matthew Wilcox , Alistair Popple , Minchan Kim , Miaohe Lin , LKML , Cgroups , Linux MM , kernel-team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 9, 2021 at 10:15 AM Suren Baghdasaryan wrote: > > Inline mem_cgroup_{charge/uncharge} and mem_cgroup_uncharge_list functions > functions to perform mem_cgroup_disabled static key check inline before > calling the main body of the function. This minimizes the memcg overhead > in the pagefault and exit_mmap paths when memcgs are disabled using > cgroup_disable=memory command-line option. > This change results in ~0.4% overhead reduction when running PFT test > comparing {CONFIG_MEMCG=n} against {CONFIG_MEMCG=y, cgroup_disable=memory} > configurationon on an 8-core ARM64 Android device. > > Signed-off-by: Suren Baghdasaryan Reviewed-by: Shakeel Butt From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87702C07E9B for ; Fri, 9 Jul 2021 17:27:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 095D4613C8 for ; Fri, 9 Jul 2021 17:27:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 095D4613C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B35E46B0074; Fri, 9 Jul 2021 13:27:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ABDAD6B0078; Fri, 9 Jul 2021 13:27:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 937196B007B; Fri, 9 Jul 2021 13:27:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0130.hostedemail.com [216.40.44.130]) by kanga.kvack.org (Postfix) with ESMTP id 667746B0074 for ; Fri, 9 Jul 2021 13:27:15 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A772C2C5B7 for ; Fri, 9 Jul 2021 17:27:14 +0000 (UTC) X-FDA: 78343730388.31.3FECFAC Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by imf19.hostedemail.com (Postfix) with ESMTP id 6F86CB000193 for ; Fri, 9 Jul 2021 17:27:14 +0000 (UTC) Received: by mail-lj1-f173.google.com with SMTP id e20so9157765ljn.8 for ; Fri, 09 Jul 2021 10:27:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A3BFSbignNESj8/rrwZ1G7zuaCPgGVuO823S/jHyGy0=; b=raXro5aqHVk05FqTrS0rJjDV0MZ5+ERPmzQZfuH4nwxpLbqvs33kwRqpd1Y3wfueAn 13oMZAwMS/vpxqlRC13oy5NBgkRRbSl3Fu51UXlk4PfttNKOME2w6oJ61aE5yP/SwLqo An96A6j5eCxtZEaUfZYKpsyaPZpufz6QEAQxfBeyaZ5K4AWiDHQPINxpSYf77MWMDGJO O1W4afwnIwmK9CpfZybIzXwmVK8krSTUIV3I/B9kMDzTBKTaseBG/LJ3JQeYJh5Tdm5X cAlwgtTckxjr7yAQGgJc1AdMzb5aa+aBL5xSvmoV25k/DvgyefzRjrWC2G3AHuRPtNWA 0iSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A3BFSbignNESj8/rrwZ1G7zuaCPgGVuO823S/jHyGy0=; b=Zp2KEQrlQ1t5a90ROaJzTa800GVzAKj5deumkwh1tyFdFcOL9CRDZvuXVbFUJCDmcc YsviUr/QbUGpKRN9bOoTvWqjCwv7oeEm51CEPAx17x1HRpoh+eOSuQVMLbmKSGQW7Fsp 1ZsUQwS9VpOYS4XsKS/UCxeDUavQ/DltP+s+S5IJX6wIUv/GnVBF+amwd9cCfsRYxTbN qYG0Bs568ytAgDxGJlDyElQWIcEX5teWKiIwN5bYjDQvGnf8Cl7dkOISrGjp3GA909l+ WY+LtV/o6ka57K75OXwdvIlLVb9GmtwqkxfYd2zVokEVpa89DxwEszsmkBawAIHn4d1d HUkw== X-Gm-Message-State: AOAM533gwgRsbfp5m7bZ8scaEHynzvsQ1aOTztJehv7hNKqe6p3RnMoD vULxmDb98O1Oxj9oVvHPzrGbaFyBEp7NygE0auhwew== X-Google-Smtp-Source: ABdhPJxSTF27Vf8rpwGTyQEHiZoBoQsGHn5uAdCOrMmM2Yc/JJMk/btI8xEmJa8aPs/xwKR6xmWlXa18b7sKsYeZYBM= X-Received: by 2002:a2e:8215:: with SMTP id w21mr29626159ljg.160.1625851632594; Fri, 09 Jul 2021 10:27:12 -0700 (PDT) MIME-Version: 1.0 References: <20210709171554.3494654-1-surenb@google.com> In-Reply-To: <20210709171554.3494654-1-surenb@google.com> From: Shakeel Butt Date: Fri, 9 Jul 2021 10:27:01 -0700 Message-ID: Subject: Re: [PATCH v2 1/1] mm, memcg: inline mem_cgroup_{charge/uncharge} to improve disabled memcg config To: Suren Baghdasaryan Cc: Tejun Heo , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Roman Gushchin , Muchun Song , Yang Shi , alexs@kernel.org, Wei Yang , Vlastimil Babka , Jens Axboe , Joonsoo Kim , David Hildenbrand , Matthew Wilcox , Alistair Popple , Minchan Kim , Miaohe Lin , LKML , Cgroups , Linux MM , kernel-team Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6F86CB000193 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=raXro5aq; spf=pass (imf19.hostedemail.com: domain of shakeelb@google.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: 757j1byh5w4nnfo1yyd3pttfxb646nrz X-HE-Tag: 1625851634-405797 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 9, 2021 at 10:15 AM Suren Baghdasaryan wrote: > > Inline mem_cgroup_{charge/uncharge} and mem_cgroup_uncharge_list functions > functions to perform mem_cgroup_disabled static key check inline before > calling the main body of the function. This minimizes the memcg overhead > in the pagefault and exit_mmap paths when memcgs are disabled using > cgroup_disable=memory command-line option. > This change results in ~0.4% overhead reduction when running PFT test > comparing {CONFIG_MEMCG=n} against {CONFIG_MEMCG=y, cgroup_disable=memory} > configurationon on an 8-core ARM64 Android device. > > Signed-off-by: Suren Baghdasaryan Reviewed-by: Shakeel Butt From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shakeel Butt Subject: Re: [PATCH v2 1/1] mm, memcg: inline mem_cgroup_{charge/uncharge} to improve disabled memcg config Date: Fri, 9 Jul 2021 10:27:01 -0700 Message-ID: References: <20210709171554.3494654-1-surenb@google.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A3BFSbignNESj8/rrwZ1G7zuaCPgGVuO823S/jHyGy0=; b=raXro5aqHVk05FqTrS0rJjDV0MZ5+ERPmzQZfuH4nwxpLbqvs33kwRqpd1Y3wfueAn 13oMZAwMS/vpxqlRC13oy5NBgkRRbSl3Fu51UXlk4PfttNKOME2w6oJ61aE5yP/SwLqo An96A6j5eCxtZEaUfZYKpsyaPZpufz6QEAQxfBeyaZ5K4AWiDHQPINxpSYf77MWMDGJO O1W4afwnIwmK9CpfZybIzXwmVK8krSTUIV3I/B9kMDzTBKTaseBG/LJ3JQeYJh5Tdm5X cAlwgtTckxjr7yAQGgJc1AdMzb5aa+aBL5xSvmoV25k/DvgyefzRjrWC2G3AHuRPtNWA 0iSA== In-Reply-To: <20210709171554.3494654-1-surenb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Suren Baghdasaryan Cc: Tejun Heo , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Roman Gushchin , Muchun Song , Yang Shi , alexs-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Wei Yang , Vlastimil Babka , Jens Axboe , Joonsoo Kim , David Hildenbrand , Matthew Wilcox , Alistair Popple , Minchan Kim , Miaohe Lin , LKML , Cgroups , Linux MM , kernel-team On Fri, Jul 9, 2021 at 10:15 AM Suren Baghdasaryan wrote: > > Inline mem_cgroup_{charge/uncharge} and mem_cgroup_uncharge_list functions > functions to perform mem_cgroup_disabled static key check inline before > calling the main body of the function. This minimizes the memcg overhead > in the pagefault and exit_mmap paths when memcgs are disabled using > cgroup_disable=memory command-line option. > This change results in ~0.4% overhead reduction when running PFT test > comparing {CONFIG_MEMCG=n} against {CONFIG_MEMCG=y, cgroup_disable=memory} > configurationon on an 8-core ARM64 Android device. > > Signed-off-by: Suren Baghdasaryan Reviewed-by: Shakeel Butt