From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 2EBD6C433EF
	for <linux-kernel@archiver.kernel.org>; Thu, 10 Feb 2022 22:23:53 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1344916AbiBJWXv (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 10 Feb 2022 17:23:51 -0500
Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:49842 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1344803AbiBJWXu (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 10 Feb 2022 17:23:50 -0500
Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E34BE25C2
        for <linux-kernel@vger.kernel.org>; Thu, 10 Feb 2022 14:23:50 -0800 (PST)
Received: by mail-lf1-x12d.google.com with SMTP id f23so13076848lfe.5
        for <linux-kernel@vger.kernel.org>; Thu, 10 Feb 2022 14:23:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=0hO66QIvus488NAq78feGEF3dBYxRKmF5DOdeN40y0E=;
        b=ifAyrepAz0/IittI3oOkEW3ly0MGafuEuH+Wv4mqyEk5J+wQSQK4XejFuQrRyABDxy
         cDqnh5/He67UFdvdqWpWkGAY/4DGX71VVGZtRxmYlXps/XzEIW0/YAK+lGR1Of8QoJhA
         dlcXq1Pjm6j94Eh2UzSeZtQSV1JIKru0Uq60Ossq66fC+6zhWOea8yR11tUdGHv33PQS
         QgWvXdGu9gDVM4ZDMwDCLedn7lb0suJH93kcg+bgyn+ulIlbOetxdtUDPDVAkqcwTwa4
         n4LLOEvLFf2EFgZfhIIv1t/7uc9WiFYkSNxY+AH74ofOtAAxydlupol0MB9qJiSbd0mY
         cn/A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=0hO66QIvus488NAq78feGEF3dBYxRKmF5DOdeN40y0E=;
        b=UeKuQBDqWtkK/rmvLN+7Ks2PIhNqdq3KJHFC9hedr943ZpyrFSd3PK9STUnEOzZ5pt
         WqNWwPi1foDfx9ckNVR01KDquRn1X0d9MrmyrCo/Pt3cA5P+SbNeH0gidcSoYSdbTPUS
         JufQKVQUKQGHWTAfpVUL91j6U5Q3AZjGXZS7fR+eEdKN0xpC7ypyEEJValxDxhar8F71
         T3EpbydtMu4S2UL+2SvIYJc6VJqu8nkuqc57lU02JABT7LJMIldSuAEsgu2iKF0jrL2U
         k7d0l7aaucoZFIf+/VFzoMSQJE3mg7chLkwCBhQGT5gR6wI0cXesILdA4iTfQzzm0jpO
         AQeQ==
X-Gm-Message-State: AOAM532DXS8K1JuEOsNAKoaAPgCnBBsZB+1CKVzpztOuUrwqi3w43hmp
        gsZdjBm50kx1NLvQsh5e0H1MZm1UETTDktaqZCB1DQ==
X-Google-Smtp-Source: ABdhPJwFiSrA1WyKAJ3QOZVAg4E0gV7YsjWEijBGwjO9wjm2Wyh1/Ocie0SCJqhwKTKi5U//VRSxTwUeqtXSwW1SiPE=
X-Received: by 2002:a05:6512:230b:: with SMTP id o11mr6432078lfu.40.1644531829105;
 Thu, 10 Feb 2022 14:23:49 -0800 (PST)
MIME-Version: 1.0
References: <20220210081437.1884008-1-shakeelb@google.com> <20220210081437.1884008-2-shakeelb@google.com>
 <YgVtGhvXqqVzTy7M@carbon.dhcp.thefacebook.com>
In-Reply-To: <YgVtGhvXqqVzTy7M@carbon.dhcp.thefacebook.com>
From:   Shakeel Butt <shakeelb@google.com>
Date:   Thu, 10 Feb 2022 14:23:37 -0800
Message-ID: <CALvZod4Ex+0q+4pDnR8q6bpV8Q5NKbt=5c6SDVUDVnKxTqUNRQ@mail.gmail.com>
Subject: Re: [PATCH 1/4] memcg: refactor mem_cgroup_oom
To:     Roman Gushchin <guro@fb.com>
Cc:     Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@suse.com>,
        Chris Down <chris@chrisdown.name>,
        Andrew Morton <akpm@linux-foundation.org>,
        Cgroups <cgroups@vger.kernel.org>, Linux MM <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 10, 2022 at 11:53 AM Roman Gushchin <guro@fb.com> wrote:
>
> On Thu, Feb 10, 2022 at 12:14:34AM -0800, Shakeel Butt wrote:
> > The function mem_cgroup_oom returns enum which has four possible values
> > but the caller does not care about such values and only care if the
> > return value is OOM_SUCCESS or not. So, remove the enum altogether and
> > make mem_cgroup_oom returns a simple bool.
> >
> > Signed-off-by: Shakeel Butt <shakeelb@google.com>
>
> Nice!
>
> Reviewed-by: Roman Gushchin <guro@fb.com>

Thanks.
>
[...]
>
> The only thing, I'd add a small comment on the return value here. E.g.
> "returns true if one or more tasks have been successfully killed" or something
> like this.
>

Will do in the next version.