From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 932F7C433F5 for ; Wed, 2 Mar 2022 15:52:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11E148D0002; Wed, 2 Mar 2022 10:52:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CFD98D0001; Wed, 2 Mar 2022 10:52:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F25ED8D0002; Wed, 2 Mar 2022 10:52:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id E19918D0001 for ; Wed, 2 Mar 2022 10:52:23 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id A200A619DB for ; Wed, 2 Mar 2022 15:52:23 +0000 (UTC) X-FDA: 79199888166.05.2467B7B Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf25.hostedemail.com (Postfix) with ESMTP id 3B4F1A000B for ; Wed, 2 Mar 2022 15:52:23 +0000 (UTC) Received: by mail-pj1-f49.google.com with SMTP id g7-20020a17090a708700b001bb78857ccdso5175633pjk.1 for ; Wed, 02 Mar 2022 07:52:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nZ9F3jdXPFWl9sjAT6uGDI9vnmPptwOE3cKuD9X4CNU=; b=ehnBjKJ+6C92C62WZfnQJjy0limEN+QHl0wAGFfnC0XFHhF9rOzQKAxeyuNq7OD48w 5S1ox4Fk3PMejr5Pk233anhhWws1E6XluZaC/6NYwiSB2ESPoXxdvfQ4IuJO7SIEhb08 CXG41JPy/aUEN5+ALoC8cI+4lQ4UTEgI2WUyYgxq/cb0mo530ejFkYqeCZlHb24L8sax PQJYue7G6jIycWGtGJzHixc7u5a7ntxF65SjU9q0UKA6nbLBNhmDnEWZ/Kbnq8/0W0aM SOQVrvPCMHjekF+cc7XTwjwLvRj/23Zjvf26FaaEzv9cx5Z4oxhZsVcRSRR+UMQvApMg 9kcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nZ9F3jdXPFWl9sjAT6uGDI9vnmPptwOE3cKuD9X4CNU=; b=yTC92dvhxTs/75rzsQe7EbGNnEw1HGlzD2wW1gYRXv6ls096xpIyAkfebWMrroHjwJ 5tVLSFbN3TQa/xS9ugvWPhfr9sMRyk3kEeE1JyUko2SY9N5oSH5afPpIEpIOM7NqupBi 3bEAdBcZv+jDDbreSfJM3oW/kGGFGTQrHfnXROHqqcj8Q4PmsAdkTffshZyVw45yaWTg +0dYpY71pUbkVvHuwGyr2oO2FJ6K+0ng1VBtIM7lS3EX0WVnEuiitwWxvuVWj3J5MD5q BG13VL5Jsu+Qiln6O58nZTmP8iPWV5VQLvm0FKJSUAZChO3FsbPsq3nPh+tG6bKTu/0m x9Nw== X-Gm-Message-State: AOAM533l05TZEpkNyUq0kwqPruEfzVDEKs8UWEz/jGgX7rEbrvhkQlN+ LPYoRIjs367X5q4eInuqNeIBe1JdvZgSxbBEjsNdOQ== X-Google-Smtp-Source: ABdhPJzIgxMxVc3myP/cOF3aqRxrb4fHjohGAMVQM0oeWEfRaX+zqkmAPkmm1FBwX9nbx21YY2qGOa3Q5DZ/RMDTgPM= X-Received: by 2002:a17:903:2cb:b0:14f:4fb6:2fb0 with SMTP id s11-20020a17090302cb00b0014f4fb62fb0mr30974660plk.172.1646236341863; Wed, 02 Mar 2022 07:52:21 -0800 (PST) MIME-Version: 1.0 References: <20220224185236.qgzm3jpoz2orjfcw@google.com> <20220225180345.GD12037@blackbody.suse.cz> <20220228230949.xrmy6j2glxsoffko@google.com> <20220302025022.nnmpwxmkqed2icck@google.com> In-Reply-To: From: Shakeel Butt Date: Wed, 2 Mar 2022 07:52:10 -0800 Message-ID: Subject: Re: Regression in workingset_refault latency on 5.15 To: Frank Hofmann Cc: Ivan Babrou , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Daniel Dao , kernel-team , Linux MM , Johannes Weiner , Roman Gushchin , Feng Tang , Michal Hocko , Hillf Danton , Andrew Morton , Linus Torvalds Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3B4F1A000B X-Stat-Signature: 5j6b6kcmmd6nrx8n9usqxoyiunf4471k Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ehnBjKJ+; spf=pass (imf25.hostedemail.com: domain of shakeelb@google.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1646236343-867098 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000210, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Frank On Wed, Mar 2, 2022 at 3:50 AM Frank Hofmann wrote: [...] > > Hi Shakeel, > > maybe it's just me, but the codechange below confuses me. I'll comment inline. > [...] > > I understand there is a memory saving from the different table > types/sizes, while the vm events per memcg is a (small) subset of vm > events. How relevant is this to the change, though? > Actually this is the whole reason behind this change i.e. reduce the size of events[_prev] arrays from ~100 to 15. I suspect updating events arrays might be the half the time the rstat flushing is spending on.