From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88BBAC433E0 for ; Fri, 5 Mar 2021 16:42:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47D136508D for ; Fri, 5 Mar 2021 16:42:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231295AbhCEQm1 (ORCPT ); Fri, 5 Mar 2021 11:42:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230179AbhCEQmO (ORCPT ); Fri, 5 Mar 2021 11:42:14 -0500 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F336CC061574 for ; Fri, 5 Mar 2021 08:42:13 -0800 (PST) Received: by mail-lj1-x22c.google.com with SMTP id u18so3589525ljd.3 for ; Fri, 05 Mar 2021 08:42:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Idz6IhNVmVDwrmS9eS02rzcFdMoaAKDHYFFgO5wjPbU=; b=O2TrIrVFHinCDdMspBfmxsGMiJUlgXCqYQ5/0BckQ2Iqy1homQEhVrIQ0XJsIYpaiW +YcSkkOPteNMhOlE5U2GaaBp/HMTEYNawtAoNNIkRe/tsVEzJ4PZB1KAAThN973pDjue IjS6Zw/SOn6Xkj9MzXByMZP+d6xnuMFtlm3qOV4cT/bLE9T0j7pRISgBlXx8E+WEG+s0 Ikc8YL/wTRFWi8DIjOcRUcsXe4QWct1oDvtVTIFV9IFP20cP91zKojuI6/SOhAOV27bO G/2Lnq7h5vsbliyITp9Bs3FcRyDoP2/5N+/HduaduYJDav5igamHgTT/8kSXaey2iA37 KhHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Idz6IhNVmVDwrmS9eS02rzcFdMoaAKDHYFFgO5wjPbU=; b=uWODky6HGFk3z7OVK9eCWJrQ0gOI9IxEZPpmooyK9GolExLYY50ZN5qF+ZjDL93G6N +ryoNjef1YrO/rjPLpWD6BIVww76mBoajvrbu2f6osEQWg6uvjLMWXvs8QR00+H5UtI6 XCjX4qHtvIzIb6Ej1Q7gy7lkmeGQiK/leUNVgHpiVwnMg/NJRPRAxrky9zExciS2sJUL Wdzz7aHnoGa9uivbWZyQLuOjvWQkpChg9+pgti5PFKZQoNlBiDBLY6aQ4Nns34FYDXmm mQNuCZsGUBlu8lsOP1uvipTkzg5WnLzBTJ+cIt0wN7IgZMeThMYFCtr8YRdY58I4rp0r Qzuw== X-Gm-Message-State: AOAM532YIg98cQmPdwVeCZBYV11ls+8F/LsUV3Nokw89BZ97Z1y3m7T8 xA6UtYawqEUtefasckWrPnWE68mhoRXLOWJc+6TTFA== X-Google-Smtp-Source: ABdhPJzGUwk57v52iY1wEp/cPEVzqifiluzS2oM2VVIzq8+D0XPrB/uI8vXaF7jxmAsK+y8S+aaiEC+qngLzzGI2LR0= X-Received: by 2002:a2e:2f05:: with SMTP id v5mr5701469ljv.279.1614962532286; Fri, 05 Mar 2021 08:42:12 -0800 (PST) MIME-Version: 1.0 References: <20210304014229.521351-1-shakeelb@google.com> In-Reply-To: From: Shakeel Butt Date: Fri, 5 Mar 2021 08:42:00 -0800 Message-ID: Subject: Re: [PATCH v3] memcg: charge before adding to swapcache on swapin To: Johannes Weiner Cc: Hugh Dickins , Roman Gushchin , Michal Hocko , Andrew Morton , Cgroups , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 5, 2021 at 8:25 AM Johannes Weiner wrote: > [...] > I'd also rename cgroup_memory_noswap to cgroup_swapaccount - to match > the commandline and (hopefully) make a bit clearer what it effects. Do we really need to keep supporting "swapaccount=0"? Is swap page_counter really a performance issue for systems with memcg and swap? To me, deprecating "swapaccount=0" simplifies already complicated code. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69087C433E0 for ; Fri, 5 Mar 2021 16:42:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D51DA6508D for ; Fri, 5 Mar 2021 16:42:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D51DA6508D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0A9786B005D; Fri, 5 Mar 2021 11:42:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 030FB6B006E; Fri, 5 Mar 2021 11:42:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DED916B0071; Fri, 5 Mar 2021 11:42:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0125.hostedemail.com [216.40.44.125]) by kanga.kvack.org (Postfix) with ESMTP id C074B6B005D for ; Fri, 5 Mar 2021 11:42:27 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 866C0824999B for ; Fri, 5 Mar 2021 16:42:27 +0000 (UTC) X-FDA: 77886388734.12.965BA19 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by imf20.hostedemail.com (Postfix) with ESMTP id 6CA6323BC for ; Fri, 5 Mar 2021 16:42:17 +0000 (UTC) Received: by mail-lj1-f171.google.com with SMTP id u4so3570604ljh.6 for ; Fri, 05 Mar 2021 08:42:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Idz6IhNVmVDwrmS9eS02rzcFdMoaAKDHYFFgO5wjPbU=; b=O2TrIrVFHinCDdMspBfmxsGMiJUlgXCqYQ5/0BckQ2Iqy1homQEhVrIQ0XJsIYpaiW +YcSkkOPteNMhOlE5U2GaaBp/HMTEYNawtAoNNIkRe/tsVEzJ4PZB1KAAThN973pDjue IjS6Zw/SOn6Xkj9MzXByMZP+d6xnuMFtlm3qOV4cT/bLE9T0j7pRISgBlXx8E+WEG+s0 Ikc8YL/wTRFWi8DIjOcRUcsXe4QWct1oDvtVTIFV9IFP20cP91zKojuI6/SOhAOV27bO G/2Lnq7h5vsbliyITp9Bs3FcRyDoP2/5N+/HduaduYJDav5igamHgTT/8kSXaey2iA37 KhHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Idz6IhNVmVDwrmS9eS02rzcFdMoaAKDHYFFgO5wjPbU=; b=JVBDen2iP1rUci+b1u1pjE7jSSD0oY6Umr51S8F9MUEOnYPakZTUopOdI161NaSLA/ UzBSDW1jukTegXqLcvAXNSRGdrHBL6lponUO0JeMw6QlC82f+LrZbrAFgNw9nP1aQqRP 9ayGIVGr6+pm1B6JDxnnedV4nFge0LtXe1lyvIsQPAtZDhtZ3gT6AauQas0rZbd6XgdE wbj6Qj9AGhRCTOH2u+oWkczs5732vwVtk8goywcC3g6ayjKI3kGUiOW6nfghCdAf9ZOh Y5orhbN6j9ZoyJmHCrb6WiQnenJBt/BwJrbJgusKB28Y1bY5M9ipLQLOiJ2krbhySaie 1VQA== X-Gm-Message-State: AOAM532HsiymO6dokGkJw19ybPLq5QYwnnLsUEfFteWJ84I23xaIE4kr 6NL98rw2TiNwlfvB0TCzh+qnnT0G3bTzqsaMBwyn5Q== X-Google-Smtp-Source: ABdhPJzGUwk57v52iY1wEp/cPEVzqifiluzS2oM2VVIzq8+D0XPrB/uI8vXaF7jxmAsK+y8S+aaiEC+qngLzzGI2LR0= X-Received: by 2002:a2e:2f05:: with SMTP id v5mr5701469ljv.279.1614962532286; Fri, 05 Mar 2021 08:42:12 -0800 (PST) MIME-Version: 1.0 References: <20210304014229.521351-1-shakeelb@google.com> In-Reply-To: From: Shakeel Butt Date: Fri, 5 Mar 2021 08:42:00 -0800 Message-ID: Subject: Re: [PATCH v3] memcg: charge before adding to swapcache on swapin To: Johannes Weiner Cc: Hugh Dickins , Roman Gushchin , Michal Hocko , Andrew Morton , Cgroups , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6CA6323BC X-Stat-Signature: e3ixddifpudjzg34pca83sa1ak1e8e7h Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf20; identity=mailfrom; envelope-from=""; helo=mail-lj1-f171.google.com; client-ip=209.85.208.171 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614962537-506616 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 5, 2021 at 8:25 AM Johannes Weiner wrote: > [...] > I'd also rename cgroup_memory_noswap to cgroup_swapaccount - to match > the commandline and (hopefully) make a bit clearer what it effects. Do we really need to keep supporting "swapaccount=0"? Is swap page_counter really a performance issue for systems with memcg and swap? To me, deprecating "swapaccount=0" simplifies already complicated code. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shakeel Butt Subject: Re: [PATCH v3] memcg: charge before adding to swapcache on swapin Date: Fri, 5 Mar 2021 08:42:00 -0800 Message-ID: References: <20210304014229.521351-1-shakeelb@google.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Idz6IhNVmVDwrmS9eS02rzcFdMoaAKDHYFFgO5wjPbU=; b=O2TrIrVFHinCDdMspBfmxsGMiJUlgXCqYQ5/0BckQ2Iqy1homQEhVrIQ0XJsIYpaiW +YcSkkOPteNMhOlE5U2GaaBp/HMTEYNawtAoNNIkRe/tsVEzJ4PZB1KAAThN973pDjue IjS6Zw/SOn6Xkj9MzXByMZP+d6xnuMFtlm3qOV4cT/bLE9T0j7pRISgBlXx8E+WEG+s0 Ikc8YL/wTRFWi8DIjOcRUcsXe4QWct1oDvtVTIFV9IFP20cP91zKojuI6/SOhAOV27bO G/2Lnq7h5vsbliyITp9Bs3FcRyDoP2/5N+/HduaduYJDav5igamHgTT/8kSXaey2iA37 KhHg== In-Reply-To: List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Johannes Weiner Cc: Hugh Dickins , Roman Gushchin , Michal Hocko , Andrew Morton , Cgroups , Linux MM , LKML On Fri, Mar 5, 2021 at 8:25 AM Johannes Weiner wrote: > [...] > I'd also rename cgroup_memory_noswap to cgroup_swapaccount - to match > the commandline and (hopefully) make a bit clearer what it effects. Do we really need to keep supporting "swapaccount=0"? Is swap page_counter really a performance issue for systems with memcg and swap? To me, deprecating "swapaccount=0" simplifies already complicated code.