From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0BEDC433DB for ; Fri, 12 Mar 2021 03:23:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6090C64F93 for ; Fri, 12 Mar 2021 03:23:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231741AbhCLDWz (ORCPT ); Thu, 11 Mar 2021 22:22:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229664AbhCLDWe (ORCPT ); Thu, 11 Mar 2021 22:22:34 -0500 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2ED1DC061574 for ; Thu, 11 Mar 2021 19:22:34 -0800 (PST) Received: by mail-lj1-x22c.google.com with SMTP id r20so4932048ljk.4 for ; Thu, 11 Mar 2021 19:22:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eCIc7dqSdtfRcjLpMj51xq06Wi2OTwxYLeouzZdu4ls=; b=MM4wfvArNdN73GuoyTklV4maIs6VrkD57zcs6ThfaiZRuCZTdKDAM6L/uP+vzRIoic iDmPSZBen/4rN/eaM99rFXvx1b5Qzty24xAHWN4u2nIqOg/A+lmVP6jpChXsPblRClwq mYXzV9aTFX6je8azdoDViZamEkhOVRtYOpTuSy4OEKfL516Wd+SJO9lgx+6otmTcyy4U q56OaSRiiu4wOaSdJYCyAZ+25LdB4tmTy79q829cFqkDEqrz6cieaz/XuZ5qbM1eOliA R+j/AW954iXCyz5LJ2iF2X8bSr2EBCRaUFXOSHPua0Ek6lL3vvwu2Hw6MPIjsGwSuaGz AcLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eCIc7dqSdtfRcjLpMj51xq06Wi2OTwxYLeouzZdu4ls=; b=GNI4M7OyZSQ5lBfusdpr7cmJM0KtIjf+d6qjUUn8uKMr8Kc8T+fGwbQsDUuWwWVdv5 OG4qrXxCmC48TzNpsloXdszGahhgo/9/MAi+dTqwjGPIkAjF7sZTckBusY7pdZ1VYYfq HeBUrSwWpwHMy8WFO5j6gVFcHsdhe5Fb5qXYss/+K0iQj8kIlc8YOTBk0B6J68sk4Tab DFeTB2yJsnxbjvRdkIoGHc+cOBsWhytDpkFwYC7GMyl5oC2jUWCgSMJs6zRIKqB6yHoa 8VQcE0zsA50WOIGbtJp/RDiXj+LfT4txOJOW1lDns9NzXR0cMzwIEEpAZoI+gUNR8BI4 wkZQ== X-Gm-Message-State: AOAM533QAqeiJrtrYm7k7UpqRX8w7q5ccXS1OqfhxPrrYtmPbk/PVD81 NNAQWjXZljJpSC09/0DfSLov8kmgaHr1dwLFexMyHw== X-Google-Smtp-Source: ABdhPJxPlRl6J49DAV+fDgYTfkYsLWkyswd8hWXDG/3S8bbBYuBPzvn3lU7qV8y3vDLNx2XfFyTI27/FLpZOE2whxSA= X-Received: by 2002:a2e:5c02:: with SMTP id q2mr1120647ljb.81.1615519352363; Thu, 11 Mar 2021 19:22:32 -0800 (PST) MIME-Version: 1.0 References: <20210309100717.253-1-songmuchun@bytedance.com> <20210309100717.253-3-songmuchun@bytedance.com> In-Reply-To: <20210309100717.253-3-songmuchun@bytedance.com> From: Shakeel Butt Date: Thu, 11 Mar 2021 19:22:20 -0800 Message-ID: Subject: Re: [PATCH v3 2/4] mm: memcontrol: make page_memcg{_rcu} only applicable for non-kmem page To: Muchun Song Cc: Roman Gushchin , Johannes Weiner , Michal Hocko , Andrew Morton , Vladimir Davydov , LKML , Linux MM , Xiongchun duan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 9, 2021 at 2:09 AM Muchun Song wrote: > > We want to reuse the obj_cgroup APIs to charge the kmem pages. > If we do that, we should store an object cgroup pointer to > page->memcg_data for the kmem pages. > > Finally, page->memcg_data can have 3 different meanings. replace 'can' with 'will' Other than that I think Roman and Johannes have already given very good feedback. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35FDEC433E0 for ; Fri, 12 Mar 2021 03:22:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B3A9264F8D for ; Fri, 12 Mar 2021 03:22:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3A9264F8D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2B6D08D0322; Thu, 11 Mar 2021 22:22:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 266C58D0317; Thu, 11 Mar 2021 22:22:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 108648D0322; Thu, 11 Mar 2021 22:22:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0176.hostedemail.com [216.40.44.176]) by kanga.kvack.org (Postfix) with ESMTP id E5EE08D0317 for ; Thu, 11 Mar 2021 22:22:34 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9D5553635 for ; Fri, 12 Mar 2021 03:22:34 +0000 (UTC) X-FDA: 77909774628.05.C39E363 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by imf18.hostedemail.com (Postfix) with ESMTP id 45D8C2000380 for ; Fri, 12 Mar 2021 03:22:35 +0000 (UTC) Received: by mail-lj1-f172.google.com with SMTP id 184so4932592ljf.9 for ; Thu, 11 Mar 2021 19:22:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eCIc7dqSdtfRcjLpMj51xq06Wi2OTwxYLeouzZdu4ls=; b=MM4wfvArNdN73GuoyTklV4maIs6VrkD57zcs6ThfaiZRuCZTdKDAM6L/uP+vzRIoic iDmPSZBen/4rN/eaM99rFXvx1b5Qzty24xAHWN4u2nIqOg/A+lmVP6jpChXsPblRClwq mYXzV9aTFX6je8azdoDViZamEkhOVRtYOpTuSy4OEKfL516Wd+SJO9lgx+6otmTcyy4U q56OaSRiiu4wOaSdJYCyAZ+25LdB4tmTy79q829cFqkDEqrz6cieaz/XuZ5qbM1eOliA R+j/AW954iXCyz5LJ2iF2X8bSr2EBCRaUFXOSHPua0Ek6lL3vvwu2Hw6MPIjsGwSuaGz AcLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eCIc7dqSdtfRcjLpMj51xq06Wi2OTwxYLeouzZdu4ls=; b=fykkJ+HoJv+e6gez26nBlZnrh8ExsrDUvMMBvSxtb7efFcVfXJym1BIXhhBaQAjwLi 9ohn0dO/Lr9vKogv4Iv+EH98P9t3D8SKiLwZFg5x3114gz9eUN8sOM1uXZ6Z7qQ3DWxH SyTyn1zQBAMKaLwW6iftOcf8LxAinuAXx3vFPSUcBINvlQWUGOBZFzEhjEv71V7Fhg9O mfmuxSWibCrsAhSvwXKn4rWItfQON8vhigoN0tkjlXI3vYP9xn8a55VmmRgv0yFjGIF7 knazKN097RuQ4wFZgyxm5XcsI2eFdTYr0bRFvCD63kwuW3+yk3Tv/+TT0q69pwk7OFcK LZbQ== X-Gm-Message-State: AOAM532awLATi2Jd5TKcPyVSIZ5AKpeJx2aQLeLaRiWphFO47SU4ErUa JCfj5v5hjg7vvi/dPEN8sBA4DdlQkf/6lcPPFJIvKQ== X-Google-Smtp-Source: ABdhPJxPlRl6J49DAV+fDgYTfkYsLWkyswd8hWXDG/3S8bbBYuBPzvn3lU7qV8y3vDLNx2XfFyTI27/FLpZOE2whxSA= X-Received: by 2002:a2e:5c02:: with SMTP id q2mr1120647ljb.81.1615519352363; Thu, 11 Mar 2021 19:22:32 -0800 (PST) MIME-Version: 1.0 References: <20210309100717.253-1-songmuchun@bytedance.com> <20210309100717.253-3-songmuchun@bytedance.com> In-Reply-To: <20210309100717.253-3-songmuchun@bytedance.com> From: Shakeel Butt Date: Thu, 11 Mar 2021 19:22:20 -0800 Message-ID: Subject: Re: [PATCH v3 2/4] mm: memcontrol: make page_memcg{_rcu} only applicable for non-kmem page To: Muchun Song Cc: Roman Gushchin , Johannes Weiner , Michal Hocko , Andrew Morton , Vladimir Davydov , LKML , Linux MM , Xiongchun duan Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 45D8C2000380 X-Stat-Signature: d6eqrsgpm6b84ougrjr5ja4rtd7ns8ie Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=mail-lj1-f172.google.com; client-ip=209.85.208.172 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615519355-946444 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 9, 2021 at 2:09 AM Muchun Song wrote: > > We want to reuse the obj_cgroup APIs to charge the kmem pages. > If we do that, we should store an object cgroup pointer to > page->memcg_data for the kmem pages. > > Finally, page->memcg_data can have 3 different meanings. replace 'can' with 'will' Other than that I think Roman and Johannes have already given very good feedback.