From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0A66C433F5 for ; Mon, 28 Feb 2022 23:43:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D7AD8D0002; Mon, 28 Feb 2022 18:43:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 387948D0001; Mon, 28 Feb 2022 18:43:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24FAD8D0002; Mon, 28 Feb 2022 18:43:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0203.hostedemail.com [216.40.44.203]) by kanga.kvack.org (Postfix) with ESMTP id 139CD8D0001 for ; Mon, 28 Feb 2022 18:43:27 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A51828249980 for ; Mon, 28 Feb 2022 23:43:26 +0000 (UTC) X-FDA: 79193817612.30.27AA0A7 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf12.hostedemail.com (Postfix) with ESMTP id 3B68440002 for ; Mon, 28 Feb 2022 23:43:26 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id j10-20020a17090a94ca00b001bc2a9596f6so624662pjw.5 for ; Mon, 28 Feb 2022 15:43:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Or35bEN/h0PCKmgqwEs6CGjEybk/OzdRRIto9eQ3tQI=; b=bYmyLXHrFg35O2855xd55iTTxo5+vK7BNJZ22SsicNoge/mzUVu3vp6fY0tYbSEpbx t2bJfa7ab0gnOEcf5WxcLWs3rsUufKaFFyz7wJQG9JcdS2TLOSjZ22SCdgnCHDYzE77d 1vhC4xiRMhb0VxA7Ob/g5psqXYig9H/hJTwlLKKtdh/4noc1mn+4nrxh5laX1bJYqoPE YyuyBCQIglM06eay6wV0qzPKsyB/2IdvPQe3YYeetKRApV7zFdtUzEzaPh9KSV5wxL7k PC/5j5M94CBQ5egXqJ08ypO5nPqaxaUN+bV1nxe4f9Qo70KoFUVpXIWT3WEewrRE0KSY OITA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Or35bEN/h0PCKmgqwEs6CGjEybk/OzdRRIto9eQ3tQI=; b=wD6T1iD0KWjC5fV+9UVfzBiOHt3DYYE9ouW19jBzzBUJJhcBLdwR1iW2MZfXZZnUwQ XHw9eOeyuRqM+d9AGlWDn/OzAykT+naEk+KTCJ+puL7SwQ2pSPuKRVQioLLmSiwE9di0 mnxgUpgc0QyrC1h7/5LCOQIQBvAyahhzZsdEps0FMOAmFAWxz8n1isbl6sqv3nGqC5om U8KNTfZ+7lfITqMJUYD+itC6prWboi/gKv3ELBrGOjpWCJM/xAZtqvwfXoEQZqLX9Q2Y Wd1OdU6vG4ofaZBSIVu8kgEXZqe0AQyf9tz6kyb9toB9IIQlwBfdMpbWEDwn9+lVTVr0 87Og== X-Gm-Message-State: AOAM533xkvGAy/cFf3HK0aHcEgKDfvNXea1Oy5EMCQZ6pWDTR3E3RxfC n0p/cTx81e/+up1uFb8vENSh9csay6XeD37xzTXL1A== X-Google-Smtp-Source: ABdhPJwg1uodBCxeHMM3aSDe0xf3cF7zm1RwoNM5SFCPhZuSIPpW59zikha2Etd+8FSJt09+ANEbvyEiFSXVe3Rby7w= X-Received: by 2002:a17:90a:ac14:b0:1bc:2b81:4f5d with SMTP id o20-20020a17090aac1400b001bc2b814f5dmr18969812pjq.207.1646091804953; Mon, 28 Feb 2022 15:43:24 -0800 (PST) MIME-Version: 1.0 References: <20220224165838.oir5clpkkqpstpx3@google.com> <20220224185236.qgzm3jpoz2orjfcw@google.com> <20220225180345.GD12037@blackbody.suse.cz> <20220228230949.xrmy6j2glxsoffko@google.com> In-Reply-To: From: Shakeel Butt Date: Mon, 28 Feb 2022 15:43:13 -0800 Message-ID: Subject: Re: Regression in workingset_refault latency on 5.15 To: Ivan Babrou Cc: =?UTF-8?Q?Michal_Koutn=C3=BD?= , Daniel Dao , kernel-team , Linux MM , Johannes Weiner , Roman Gushchin , Feng Tang , Michal Hocko , Hillf Danton , Andrew Morton , Linus Torvalds Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3B68440002 X-Stat-Signature: enw46xde1s6n14r3iyi5mmuqu6aqj7dx Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=bYmyLXHr; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of shakeelb@google.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=shakeelb@google.com X-HE-Tag: 1646091806-978789 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 28, 2022 at 3:34 PM Ivan Babrou wrote: > > On Mon, Feb 28, 2022 at 3:09 PM Shakeel Butt wrote: > > Hi Ivan & Daniel, > > > > Can you please try the following patch but without the async patch and > > let us know if there is any difference in regression you are observing? > > Hey Shakeel, > > I scheduled some reboots for overnight, one machine in each group: > > 1. Control on 5.15.25 > 2. Your previous patch with delayed flush on top of 5.15.25 > 3. You current patch with targeted flush on top of 5.15.25 > > Either Daniel or I should have some numbers tomorrow. Thanks a lot Ivan. I am also working on improving mem_cgroup_css_rstat_flush() and cgroup_rstat_flush_locked() which will be orthogonal to the patches you are testing.