From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 344F8C64E8A for ; Wed, 2 Dec 2020 01:13:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4CA021D7E for ; Wed, 2 Dec 2020 01:13:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727890AbgLBBMt (ORCPT ); Tue, 1 Dec 2020 20:12:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727096AbgLBBMt (ORCPT ); Tue, 1 Dec 2020 20:12:49 -0500 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28F51C0613CF for ; Tue, 1 Dec 2020 17:12:03 -0800 (PST) Received: by mail-lf1-x142.google.com with SMTP id u19so147076lfr.7 for ; Tue, 01 Dec 2020 17:12:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XWjyeifvSwsRpNI5bt393TR+i6zbs6RUOPTBxq9kpw8=; b=FGE8oRA2h0WmXKhJu9sTaV4vzrA5cucmermNBgl50MomYCjqwiEoGbM4bM3Qt0OxW+ jjgqLICCbSPA/jd3sYCpiWjnnYQ5Dvme5tfsDiTMOvzBcZh9p1110bw7+/Ux+wxyZUmR xEgo8WrhU5lWf1rTtEEAkKCLvoaZQBFUq6CSju8CcwY9WqhbhFhT93tlGNWCuRis9ibz h2bvQ+K4uDxj+GWvnwLmCO5ergZUTAO9/zXJzDOT3Cc81KbI23WMy52SKzECOjaP7v71 lKopOX9BMBB6qpSwNs5dh/ZzFyh4WyNobsZC2NumjBhWq/g+omTA4isEThGrU3Il8tQb a6SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XWjyeifvSwsRpNI5bt393TR+i6zbs6RUOPTBxq9kpw8=; b=Hfs1lqzDFX8T47c4dsngZkiZ1gMZn6+aWKyYesEV7nnb0mgN6xa1pMDNgNHLzo6TkS MnrZOTdtb3wgTLQCvAp32K9vkJp28yrPJfVenof9S5M8edoK5dEDyf0yS5S3aU1de76O Uv5YPK61gJoI7NTCCRP0EVx8Ij+x6EAVtm7FmTnFV3maQ0ev0OUa9row9lFUKIGHWuPi /tIP6rWRif6IEaqG4BZxk8BYrez5pxJ96xxBzyfevF+R3ELOnlya+giFrcHrO+u8/vTs 8nlBg7uI5hRgSSS50W/OyReG97V6EkLKFaqM56RS2mqxUn5i/scusqJep7IH50TcnEde GXHA== X-Gm-Message-State: AOAM532Uoz39ZokRZZT5q0ZexvsFLcnCLIwNn4a/QKN+0rO4ByksxGvi gbxA2MHZPSaaJgyWB8ksIUdq+qUZcwozMZMO9VBZ1A== X-Google-Smtp-Source: ABdhPJwtgioO16asUFHaShqSlxtaZ8WR8+eLYHmxioCs94wY0t5VnpsiMOilaXZuEgd6GY7yhlUswECBEu2xdICu6Do= X-Received: by 2002:a19:cc42:: with SMTP id c63mr116521lfg.521.1606871521372; Tue, 01 Dec 2020 17:12:01 -0800 (PST) MIME-Version: 1.0 References: <20201130233504.3725241-1-axelrasmussen@google.com> <20201201200715.6171d39b@oasis.local.home> In-Reply-To: <20201201200715.6171d39b@oasis.local.home> From: Shakeel Butt Date: Tue, 1 Dec 2020 17:11:50 -0800 Message-ID: Subject: Re: [PATCH] mm: mmap_lock: fix use-after-free race and css ref leak in tracepoints To: Steven Rostedt Cc: Axel Rasmussen , Tejun Heo , Greg Thelen , Andrew Morton , Chinwen Chang , Daniel Jordan , David Rientjes , Davidlohr Bueso , Ingo Molnar , Jann Horn , Laurent Dufour , Michel Lespinasse , Stephen Rothwell , Vlastimil Babka , Yafang Shao , "David S . Miller" , dsahern@kernel.org, Greg Kroah-Hartman , Jakub Kicinski , liuhangbin@gmail.com, LKML , Linux MM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 1, 2020 at 5:07 PM Steven Rostedt wrote: > > On Tue, 1 Dec 2020 16:36:32 -0800 > Shakeel Butt wrote: > > > SGTM but note that usually Andrew squash all the patches into one > > before sending to Linus. If you plan to replace the path buffer with > > integer IDs then no need to spend time fixing buffer related bug. > > I don't think Andrew squashes all the patches. I believe he sends Linus > a patch series. I am talking about the patch and the following fixes to that patch. Those are usually squashed into one patch. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA953C64E7A for ; Wed, 2 Dec 2020 01:12:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 147B121D7E for ; Wed, 2 Dec 2020 01:12:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 147B121D7E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7C1706B005D; Tue, 1 Dec 2020 20:12:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 724818D0002; Tue, 1 Dec 2020 20:12:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6106A8D0001; Tue, 1 Dec 2020 20:12:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0128.hostedemail.com [216.40.44.128]) by kanga.kvack.org (Postfix) with ESMTP id 42E7F6B005D for ; Tue, 1 Dec 2020 20:12:04 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id F33C2181AEF1D for ; Wed, 2 Dec 2020 01:12:03 +0000 (UTC) X-FDA: 77546565768.06.crook16_430851f273af Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id C8F0C1003FB1D for ; Wed, 2 Dec 2020 01:12:03 +0000 (UTC) X-HE-Tag: crook16_430851f273af X-Filterd-Recvd-Size: 4519 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Wed, 2 Dec 2020 01:12:03 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id v14so185663lfo.3 for ; Tue, 01 Dec 2020 17:12:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XWjyeifvSwsRpNI5bt393TR+i6zbs6RUOPTBxq9kpw8=; b=FGE8oRA2h0WmXKhJu9sTaV4vzrA5cucmermNBgl50MomYCjqwiEoGbM4bM3Qt0OxW+ jjgqLICCbSPA/jd3sYCpiWjnnYQ5Dvme5tfsDiTMOvzBcZh9p1110bw7+/Ux+wxyZUmR xEgo8WrhU5lWf1rTtEEAkKCLvoaZQBFUq6CSju8CcwY9WqhbhFhT93tlGNWCuRis9ibz h2bvQ+K4uDxj+GWvnwLmCO5ergZUTAO9/zXJzDOT3Cc81KbI23WMy52SKzECOjaP7v71 lKopOX9BMBB6qpSwNs5dh/ZzFyh4WyNobsZC2NumjBhWq/g+omTA4isEThGrU3Il8tQb a6SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XWjyeifvSwsRpNI5bt393TR+i6zbs6RUOPTBxq9kpw8=; b=cMGD3uULwqzHYJb67crTuwvnj/EBZwBr/1NteAEHdHbJvXaHVxmkBs8MzytznIuVDa JC5XR3hwC7iqhDEBvVNf6fcbhRpLM0jPIPXTZtvkiLQbfs2xg2chOKSOOrEFd9qmM+v0 r8yjx7BR8VODi2zkHRU5QM99lpEbIANMNU7NW3C9eKFQPn69s90BTc8lQSabMs3KulJi ubiUtVMkpbzl48/LpYtfOc++ux1oVtWFryTuI2G1GcCDIHIUAXTKoPSIM89ddqA1/kCw jyKL2xpLCr6hmg3QxW5q6RQ48AlZxnIabvqgbxfgJxqZ0GD27a4KTem2O5epNSZG6AOy xu4w== X-Gm-Message-State: AOAM533CoYBkoJ2IesWaQnBtsJ1wnKDKR1BEExdYMNiAfkoqwZpiAc5k YkLXXkG4UE+v68/YP/hRlwel10oo9d8WBooR4VKXYg== X-Google-Smtp-Source: ABdhPJwtgioO16asUFHaShqSlxtaZ8WR8+eLYHmxioCs94wY0t5VnpsiMOilaXZuEgd6GY7yhlUswECBEu2xdICu6Do= X-Received: by 2002:a19:cc42:: with SMTP id c63mr116521lfg.521.1606871521372; Tue, 01 Dec 2020 17:12:01 -0800 (PST) MIME-Version: 1.0 References: <20201130233504.3725241-1-axelrasmussen@google.com> <20201201200715.6171d39b@oasis.local.home> In-Reply-To: <20201201200715.6171d39b@oasis.local.home> From: Shakeel Butt Date: Tue, 1 Dec 2020 17:11:50 -0800 Message-ID: Subject: Re: [PATCH] mm: mmap_lock: fix use-after-free race and css ref leak in tracepoints To: Steven Rostedt Cc: Axel Rasmussen , Tejun Heo , Greg Thelen , Andrew Morton , Chinwen Chang , Daniel Jordan , David Rientjes , Davidlohr Bueso , Ingo Molnar , Jann Horn , Laurent Dufour , Michel Lespinasse , Stephen Rothwell , Vlastimil Babka , Yafang Shao , "David S . Miller" , dsahern@kernel.org, Greg Kroah-Hartman , Jakub Kicinski , liuhangbin@gmail.com, LKML , Linux MM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 1, 2020 at 5:07 PM Steven Rostedt wrote: > > On Tue, 1 Dec 2020 16:36:32 -0800 > Shakeel Butt wrote: > > > SGTM but note that usually Andrew squash all the patches into one > > before sending to Linus. If you plan to replace the path buffer with > > integer IDs then no need to spend time fixing buffer related bug. > > I don't think Andrew squashes all the patches. I believe he sends Linus > a patch series. I am talking about the patch and the following fixes to that patch. Those are usually squashed into one patch.