From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC315C432BE for ; Thu, 19 Aug 2021 15:04:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CAF46113D for ; Thu, 19 Aug 2021 15:04:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240701AbhHSPFK (ORCPT ); Thu, 19 Aug 2021 11:05:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229612AbhHSPFJ (ORCPT ); Thu, 19 Aug 2021 11:05:09 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4428EC061575 for ; Thu, 19 Aug 2021 08:04:33 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id d4so13597814lfk.9 for ; Thu, 19 Aug 2021 08:04:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T0b4zMAvEzKfXKZwvIB0eeAlmLIDqdVoJMxNV/NqtBs=; b=qoP53fKMhYzr8DPWTxyX4O4kAbrnZ9Wf7TL9vkMQqok0gG+iZiQ87Rleze/VVQLQ8m GWJlt6/3FpblM6R0i913uDUiEsIhF6FkeNJd/wxB4mAm/udUFiU8eTi/BztM6nWJ/Aw1 opjqjd7Rb0avhrUjmwnYT/XIlQtZYCB23D+HlZeKnktJZiMPIG7XCBpGdxiv/Lu/rB40 zpf/AVrsB2PgcOo85i3hJ/zeDdZSLETW6DREXRYOH4VdiDOe+PxgdffK/ksc7VYZITz6 2cMBGwdFF8uxDl/28zyuSP4KLKZLcnSwYSni4JQvp5CaqzollHNPVSWX3uBNW3DiMnk9 lOHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T0b4zMAvEzKfXKZwvIB0eeAlmLIDqdVoJMxNV/NqtBs=; b=slo5nJC6IEbO3pkfe7/0iAHrzg60kt30sQbJw4PKej3A48gDQi3S3LeSV+cEKsU2GX Flf11FM+uwqVwZFFnHIFt5pUJnnc0E+9GIafSQ/cowi56zw6WhRtcdJvMxp72gXL6F8D dDa/bAJAxAdb6UAkcA+xzG89LqQzOwzLqssDbzaPL2092V+Z4m7G37IfZXnAQxlyDj7e 9aSlheuU9y22ORqq0lyDktuMaLrfDCABL2gKFZOIHj6oUwHbrQsQj3INevb9ibEp82sU ewvs4SyhTPIIYCfzvw2DpAVk9EKmuvAPiHQpaQWB0m+igTUMlxJ4CRSbkP2M1SowMqcQ s5RA== X-Gm-Message-State: AOAM531t1NFU6Hvi52R8xIr2mV4v8UR9/Z6bW969HHCONQJr5u3dJm3y xX91u4i/wB1uUJfD/E6jwws8d1RGZ7gaFCzmkS9vRQ== X-Google-Smtp-Source: ABdhPJzTsjsthfdy+dJ+4wlWH97Y445qIp6Ehyno5agh0QLE3abUhbE9HSyRy+S4tlPERhOOTRJNIm8Qf5RJaWGV4gk= X-Received: by 2002:a05:6512:3481:: with SMTP id v1mr7630730lfr.299.1629385470682; Thu, 19 Aug 2021 08:04:30 -0700 (PDT) MIME-Version: 1.0 References: <20210818152457.35846-1-hannes@cmpxchg.org> In-Reply-To: <20210818152457.35846-1-hannes@cmpxchg.org> From: Shakeel Butt Date: Thu, 19 Aug 2021 08:04:19 -0700 Message-ID: Subject: Re: [PATCH] mm: vmscan: fix missing psi annotation for node_reclaim() To: Johannes Weiner Cc: Andrew Morton , Rik van Riel , Linux MM , LKML , Kernel Team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 18, 2021 at 8:26 AM Johannes Weiner wrote: > > In a debugging session the other day, Rik noticed that node_reclaim() > was missing memstall annotations. This means we'll miss pressure and > lost productivity resulting from reclaim on an overloaded local NUMA > node when vm.zone_reclaim_mode is enabled. > > There haven't been any reports, but that's likely because > vm.zone_reclaim_mode hasn't been a commonly used feature recently, and > the intersection between such setups and psi users is probably > nil. Although, secondary memory such as CXL-connected DIMMS, > persistent memory etc. and the page demotion patches that handle them > (https://lore.kernel.org/lkml/20210401183216.443C4443@viggo.jf.intel.com/) > could soon make this a more common codepath again. > > Reported-by: Rik van Riel > Signed-off-by: Johannes Weiner Reviewed-by: Shakeel Butt From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE8FFC4338F for ; Thu, 19 Aug 2021 15:04:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 69F4F610A0 for ; Thu, 19 Aug 2021 15:04:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 69F4F610A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id D73476B006C; Thu, 19 Aug 2021 11:04:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D23646B0071; Thu, 19 Aug 2021 11:04:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C11DE8D0001; Thu, 19 Aug 2021 11:04:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0143.hostedemail.com [216.40.44.143]) by kanga.kvack.org (Postfix) with ESMTP id A488D6B006C for ; Thu, 19 Aug 2021 11:04:33 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5A1E3807ABC1 for ; Thu, 19 Aug 2021 15:04:33 +0000 (UTC) X-FDA: 78492151626.25.48A9450 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf27.hostedemail.com (Postfix) with ESMTP id 20B8B70009C8 for ; Thu, 19 Aug 2021 15:04:33 +0000 (UTC) Received: by mail-lf1-f43.google.com with SMTP id t9so13676063lfc.6 for ; Thu, 19 Aug 2021 08:04:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T0b4zMAvEzKfXKZwvIB0eeAlmLIDqdVoJMxNV/NqtBs=; b=qoP53fKMhYzr8DPWTxyX4O4kAbrnZ9Wf7TL9vkMQqok0gG+iZiQ87Rleze/VVQLQ8m GWJlt6/3FpblM6R0i913uDUiEsIhF6FkeNJd/wxB4mAm/udUFiU8eTi/BztM6nWJ/Aw1 opjqjd7Rb0avhrUjmwnYT/XIlQtZYCB23D+HlZeKnktJZiMPIG7XCBpGdxiv/Lu/rB40 zpf/AVrsB2PgcOo85i3hJ/zeDdZSLETW6DREXRYOH4VdiDOe+PxgdffK/ksc7VYZITz6 2cMBGwdFF8uxDl/28zyuSP4KLKZLcnSwYSni4JQvp5CaqzollHNPVSWX3uBNW3DiMnk9 lOHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T0b4zMAvEzKfXKZwvIB0eeAlmLIDqdVoJMxNV/NqtBs=; b=nm7O8a3PBdlW+RqIsCr6BO/DzkeY3HvaNTPnH/FBYQUYrrzEZX9d/y0+07xt+LUuyw SEF5JMUseQx3AUs3Wd8xDKXcdNKalc/W6VDCqmUsnyGVyMfK4oHAzmsb3v8VHMJSA/58 jvUjarrIsPnnv+l0VLAcZrnWp6eAhP59zP87yPrSdLBclVNb635JglQy4ycIJW4npUDj D/FC2IWUdt6FKtnspI9qG30rAB7oV6T0Xvinbr6Wr83+kiPV1TqX1i+F1NMTWwREYFcL OoesFMAvwdQKtsN2veDCuAwn3I6Sf/CxI6+ds2Z99Bfgv2OLn09/c06i8pC+MIcrvBh4 JXSA== X-Gm-Message-State: AOAM531Z+IU0+rPEH4hNnla7qNQ9DHEpn6bUtS3DNVmY+RDKbfvA3xmt F3sMCBvft6VGVJ0uS95BDJR/p/JOZVYMR9Umuzx65w== X-Google-Smtp-Source: ABdhPJzTsjsthfdy+dJ+4wlWH97Y445qIp6Ehyno5agh0QLE3abUhbE9HSyRy+S4tlPERhOOTRJNIm8Qf5RJaWGV4gk= X-Received: by 2002:a05:6512:3481:: with SMTP id v1mr7630730lfr.299.1629385470682; Thu, 19 Aug 2021 08:04:30 -0700 (PDT) MIME-Version: 1.0 References: <20210818152457.35846-1-hannes@cmpxchg.org> In-Reply-To: <20210818152457.35846-1-hannes@cmpxchg.org> From: Shakeel Butt Date: Thu, 19 Aug 2021 08:04:19 -0700 Message-ID: Subject: Re: [PATCH] mm: vmscan: fix missing psi annotation for node_reclaim() To: Johannes Weiner Cc: Andrew Morton , Rik van Riel , Linux MM , LKML , Kernel Team Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 20B8B70009C8 X-Stat-Signature: 6hyyxsfhp5dd1tjuz8ms1imeqmh5khc1 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=qoP53fKM; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=shakeelb@google.com X-HE-Tag: 1629385473-190727 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 18, 2021 at 8:26 AM Johannes Weiner wrote: > > In a debugging session the other day, Rik noticed that node_reclaim() > was missing memstall annotations. This means we'll miss pressure and > lost productivity resulting from reclaim on an overloaded local NUMA > node when vm.zone_reclaim_mode is enabled. > > There haven't been any reports, but that's likely because > vm.zone_reclaim_mode hasn't been a commonly used feature recently, and > the intersection between such setups and psi users is probably > nil. Although, secondary memory such as CXL-connected DIMMS, > persistent memory etc. and the page demotion patches that handle them > (https://lore.kernel.org/lkml/20210401183216.443C4443@viggo.jf.intel.com/) > could soon make this a more common codepath again. > > Reported-by: Rik van Riel > Signed-off-by: Johannes Weiner Reviewed-by: Shakeel Butt