From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C3E0C4363A for ; Thu, 29 Oct 2020 16:19:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D109E207DE for ; Thu, 29 Oct 2020 16:18:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ZypFrwHF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726464AbgJ2QS6 (ORCPT ); Thu, 29 Oct 2020 12:18:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726256AbgJ2QS6 (ORCPT ); Thu, 29 Oct 2020 12:18:58 -0400 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5DB8C0613D2 for ; Thu, 29 Oct 2020 09:18:57 -0700 (PDT) Received: by mail-lf1-x144.google.com with SMTP id 126so4040407lfi.8 for ; Thu, 29 Oct 2020 09:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=G9EtR8ay+CFHP0VWhr60l9Agx6oBhnBUNvO58Pm5n2c=; b=ZypFrwHFGFdiH3//0NKW6vQX1p5u1pLj9CchSpsY8VglCbaO2vGBx2uveHOn+HSxzq O9Uwvtp1dzgD56WgMNXb2hhjjdjiSi/B1wQtiI6Ap/p4ZUtD3xctBS+5x3BZ2cOEhSSg +nX9mb4w+MOOeGPQM6MbQXVpUd2uhKi+z1z7Xtf6A07T8HHVYZ8i3zH4begi4U/VBCuX Yn2KWTFJa0FSTi3LiRcT1LGfcNUBE8/Mza2QMwPBACfFLoCzE6DaLbauBuPCkbTQgTWr QDTXah3K6U8HNIb/ifAcYX6mB4g+Nsw837iHGB7rnB488OMnyCTszLAZZ84zKoyFiCZ6 VzDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G9EtR8ay+CFHP0VWhr60l9Agx6oBhnBUNvO58Pm5n2c=; b=QWKleTVkhm6Qp/j19/XLiSDViSks4DwEG7bCwt6wMWx3ySnjj2+MGn7dqYWyuUoWun IEFRFVf2nK7PKLRHLUFHXEYxM8ZfMgVX4+S7qmoU/agMlKq/xs2fF4aQRRCJOiUPq8qA 19K/5wQfMLgN8IvTowQN/SS8xLdXOBpufki3Wz+9gM+XkLVgw6XKUp7AKEMNFplnP1dK azk63mUW/BaDyJPMjPNPiNN0otXii8CKAr6SSGkFehPwzLh6xx7LQvoybTOSKqbSH5Nu arzzbJ3hKcK/0r6ADUUdWOg8XypgNO+lilqLzBZ+Ph9y2kp83QulR24Y/kHNA4OR9lLg YaNA== X-Gm-Message-State: AOAM5303Ia78RVOgsqbeepX/CbCryVPM92g0SF4NEIJap8C/ce7z62Ee IbwI8hBYp+hnCq0SSD4v7aAGwggeN+X8/JJzdG2y7w== X-Google-Smtp-Source: ABdhPJwDUMPMP12s120vl/5u2CihW7CO4f8+IgmIiwZd79+cJvWwOZSSCzYSedlU15A8/2stmps0+QqOjNwIgwF0euA= X-Received: by 2002:a19:7719:: with SMTP id s25mr1785670lfc.521.1603988336095; Thu, 29 Oct 2020 09:18:56 -0700 (PDT) MIME-Version: 1.0 References: <20201028035013.99711-1-songmuchun@bytedance.com> In-Reply-To: From: Shakeel Butt Date: Thu, 29 Oct 2020 09:18:45 -0700 Message-ID: Subject: Re: [External] Re: [PATCH v2] mm: memcg/slab: Fix return child memcg objcg for root memcg To: Muchun Song Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Roman Gushchin , Joonsoo Kim , Yafang Shao , Chris Down , Christian Brauner , "Peter Zijlstra (Intel)" , Ingo Molnar , Kees Cook , Thomas Gleixner , esyr@redhat.com, Suren Baghdasaryan , areber@redhat.com, Marco Elver , LKML , Cgroups , Linux MM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 29, 2020 at 9:09 AM Muchun Song wrote: > > On Thu, Oct 29, 2020 at 11:48 PM Shakeel Butt wrote: > > > > On Tue, Oct 27, 2020 at 8:50 PM Muchun Song wrote: > > > > > > Consider the following memcg hierarchy. > > > > > > root > > > / \ > > > A B > > > > > > If we get the objcg of memcg A failed, > > > > Please fix the above statement. > > Sorry, could you be more specific, I don't quite understand. Fix the grammar. Something like "If we failed to get the reference on objcg of memcg A..." From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CF3DC55179 for ; Thu, 29 Oct 2020 16:19:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A403F206FB for ; Thu, 29 Oct 2020 16:18:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ZypFrwHF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A403F206FB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 19CD76B006E; Thu, 29 Oct 2020 12:18:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 14E696B0070; Thu, 29 Oct 2020 12:18:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03C376B0071; Thu, 29 Oct 2020 12:18:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id CA4486B006E for ; Thu, 29 Oct 2020 12:18:58 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 72325180AD806 for ; Thu, 29 Oct 2020 16:18:58 +0000 (UTC) X-FDA: 77425471956.22.look33_1f1641b2728e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 4E22B18038E67 for ; Thu, 29 Oct 2020 16:18:58 +0000 (UTC) X-HE-Tag: look33_1f1641b2728e X-Filterd-Recvd-Size: 4096 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Thu, 29 Oct 2020 16:18:57 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id j30so4058836lfp.4 for ; Thu, 29 Oct 2020 09:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=G9EtR8ay+CFHP0VWhr60l9Agx6oBhnBUNvO58Pm5n2c=; b=ZypFrwHFGFdiH3//0NKW6vQX1p5u1pLj9CchSpsY8VglCbaO2vGBx2uveHOn+HSxzq O9Uwvtp1dzgD56WgMNXb2hhjjdjiSi/B1wQtiI6Ap/p4ZUtD3xctBS+5x3BZ2cOEhSSg +nX9mb4w+MOOeGPQM6MbQXVpUd2uhKi+z1z7Xtf6A07T8HHVYZ8i3zH4begi4U/VBCuX Yn2KWTFJa0FSTi3LiRcT1LGfcNUBE8/Mza2QMwPBACfFLoCzE6DaLbauBuPCkbTQgTWr QDTXah3K6U8HNIb/ifAcYX6mB4g+Nsw837iHGB7rnB488OMnyCTszLAZZ84zKoyFiCZ6 VzDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G9EtR8ay+CFHP0VWhr60l9Agx6oBhnBUNvO58Pm5n2c=; b=T3uIMGpmFQ89NGRBdGaBF8WoqZfrqw4griz9ZUqirDRBEW7nxA2N1zi4kcKRSNb+S7 dOMobJ6wDzqDNzhPw/HospRYd6hWSzUNinCRTjXAtnrvCo7SIlg3tonhJMO2x6Z91t6V 8VwCI1OC8ZisOcp/xIfiwIbZz0wgX77T0OSXd/zPtCkyk7f5iTF9JBEUg+GbvSzyScd9 /S7DZbJymk/7erG8MeJSESKPVCSBwtFXoj8yTQe7SHQ4EpmLUL102M7TACR8N6+xAAXU RaJGh79h0DL4QTxRhtbKf4LCj+nrir0dmXT75jsWQF41QEdqxd2HbCvHgZhGkVWZnm7P hdJA== X-Gm-Message-State: AOAM531sexGP9DJsUcQmGtLr3HBrDD6jIWINygOqkggSeRG1l7SuLDuL i6WzeBDjqUXHJUfi4GdKZSnNycYn5z87t3DtXtl19Q== X-Google-Smtp-Source: ABdhPJwDUMPMP12s120vl/5u2CihW7CO4f8+IgmIiwZd79+cJvWwOZSSCzYSedlU15A8/2stmps0+QqOjNwIgwF0euA= X-Received: by 2002:a19:7719:: with SMTP id s25mr1785670lfc.521.1603988336095; Thu, 29 Oct 2020 09:18:56 -0700 (PDT) MIME-Version: 1.0 References: <20201028035013.99711-1-songmuchun@bytedance.com> In-Reply-To: From: Shakeel Butt Date: Thu, 29 Oct 2020 09:18:45 -0700 Message-ID: Subject: Re: [External] Re: [PATCH v2] mm: memcg/slab: Fix return child memcg objcg for root memcg To: Muchun Song Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Roman Gushchin , Joonsoo Kim , Yafang Shao , Chris Down , Christian Brauner , "Peter Zijlstra (Intel)" , Ingo Molnar , Kees Cook , Thomas Gleixner , esyr@redhat.com, Suren Baghdasaryan , areber@redhat.com, Marco Elver , LKML , Cgroups , Linux MM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 29, 2020 at 9:09 AM Muchun Song wrote: > > On Thu, Oct 29, 2020 at 11:48 PM Shakeel Butt wrote: > > > > On Tue, Oct 27, 2020 at 8:50 PM Muchun Song wrote: > > > > > > Consider the following memcg hierarchy. > > > > > > root > > > / \ > > > A B > > > > > > If we get the objcg of memcg A failed, > > > > Please fix the above statement. > > Sorry, could you be more specific, I don't quite understand. Fix the grammar. Something like "If we failed to get the reference on objcg of memcg A..." From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shakeel Butt Subject: Re: [External] Re: [PATCH v2] mm: memcg/slab: Fix return child memcg objcg for root memcg Date: Thu, 29 Oct 2020 09:18:45 -0700 Message-ID: References: <20201028035013.99711-1-songmuchun@bytedance.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=G9EtR8ay+CFHP0VWhr60l9Agx6oBhnBUNvO58Pm5n2c=; b=ZypFrwHFGFdiH3//0NKW6vQX1p5u1pLj9CchSpsY8VglCbaO2vGBx2uveHOn+HSxzq O9Uwvtp1dzgD56WgMNXb2hhjjdjiSi/B1wQtiI6Ap/p4ZUtD3xctBS+5x3BZ2cOEhSSg +nX9mb4w+MOOeGPQM6MbQXVpUd2uhKi+z1z7Xtf6A07T8HHVYZ8i3zH4begi4U/VBCuX Yn2KWTFJa0FSTi3LiRcT1LGfcNUBE8/Mza2QMwPBACfFLoCzE6DaLbauBuPCkbTQgTWr QDTXah3K6U8HNIb/ifAcYX6mB4g+Nsw837iHGB7rnB488OMnyCTszLAZZ84zKoyFiCZ6 VzDw== In-Reply-To: List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Muchun Song Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Roman Gushchin , Joonsoo Kim , Yafang Shao , Chris Down , Christian Brauner , "Peter Zijlstra (Intel)" , Ingo Molnar , Kees Cook , Thomas Gleixner , esyr-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Suren Baghdasaryan , areber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Marco Elver , LKML , Cgroups , Linux MM On Thu, Oct 29, 2020 at 9:09 AM Muchun Song wrote: > > On Thu, Oct 29, 2020 at 11:48 PM Shakeel Butt wrote: > > > > On Tue, Oct 27, 2020 at 8:50 PM Muchun Song wrote: > > > > > > Consider the following memcg hierarchy. > > > > > > root > > > / \ > > > A B > > > > > > If we get the objcg of memcg A failed, > > > > Please fix the above statement. > > Sorry, could you be more specific, I don't quite understand. Fix the grammar. Something like "If we failed to get the reference on objcg of memcg A..."