From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A47AC433ED for ; Thu, 1 Apr 2021 18:11:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 551926112E for ; Thu, 1 Apr 2021 18:11:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237323AbhDASLv (ORCPT ); Thu, 1 Apr 2021 14:11:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236859AbhDARz2 (ORCPT ); Thu, 1 Apr 2021 13:55:28 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69AE9C0319C0 for ; Thu, 1 Apr 2021 10:15:58 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id d13so3938998lfg.7 for ; Thu, 01 Apr 2021 10:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WVDGqZfP8CTFi7i9UziPzlSl+qgQw2QPqRQAU0O6vCI=; b=IX55qoHfL8y3EtErFQYBvPcpWM6kg4j9Lq7Vuh5ufhjKJGc3KczMGzc39TUpbbMzVT CSpHGFsKsQjzUA+LqiSMVyfny3edaLBYuDm341QVKfxWacX5CDe3xo8Gab0ojqeah7fX ZGURyN/PM7LJn8ERrBrnbEetwPBOpv2Izcp5McUcxF7YsVw2cGtb3ma6B3xaHbuP5beZ pDd0HTgJInatB++grkOkHnOxfrMSvpLovoiaq+elQ4XjXk0GKhKLf5po4n4tYIteamhq Unar5bdRt0RiBRd1sHJ3AFfkPmNg7Rn2gESb6l9hDtCPl4h838xz/1HIYYpEcL5qs08Q Q1lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WVDGqZfP8CTFi7i9UziPzlSl+qgQw2QPqRQAU0O6vCI=; b=RGwfFCwBXO05jHkg1G3E21uHrwkIWJqo+fh/522hky4PopFXnmZPh2GhdsdsWdlxua uVwCJ08s3yzH4SApu34DyDxai4WqUPEmbTFBB/rOmYpkX/PvLlBz4Er3o7KAjLYLG4de +iX9lxYRrwV4yMxvESVAPoLUGMJQVsCKpHpMUoJxFEMpRbRGd2BaXYEYmoDM/xjIbZXD BYfGaEOm9newxSQELChy1X07epfgTZYdJiOvjfuDkjJrFF7Nv9M+DlIe0sHRXd/lQoQd +t+2plU6gS9xZiDB1i37MMJQtdyBBMylJ7rlhtmK95VbCAHTBxLpGLqyS8YFbOI2WT+I JpRg== X-Gm-Message-State: AOAM530bQlvfd3gVPlTptM0OZSpf3C/W0iC8MEqxTEtIU2XczgxhlpdI uBZtiGyufuKYLrl3t3Nmr89d1Li4EKPuOcgPkZXzfg== X-Google-Smtp-Source: ABdhPJyTtcQEz3dDdExeyagC8hu6fOgWKz7iFXCveSspTZ6Jukk9GiQddSqWeVrwsI2KQRRtDE1x/0e3S0nFutElX6A= X-Received: by 2002:a05:6512:2356:: with SMTP id p22mr5958452lfu.347.1617297356582; Thu, 01 Apr 2021 10:15:56 -0700 (PDT) MIME-Version: 1.0 References: <20210330101531.82752-1-songmuchun@bytedance.com> In-Reply-To: From: Shakeel Butt Date: Thu, 1 Apr 2021 10:15:45 -0700 Message-ID: Subject: Re: [External] Re: [RFC PATCH 00/15] Use obj_cgroup APIs to charge the LRU pages To: Muchun Song Cc: Johannes Weiner , Roman Gushchin , Greg Thelen , Michal Hocko , Andrew Morton , Vladimir Davydov , LKML , Linux MM , Xiongchun duan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 1, 2021 at 9:08 AM Muchun Song wrote: > [...] > > The zombie issue is a pretty urgent concern that has caused several > > production emergencies now. It needs a fix sooner rather than later. > > Thank you very much for clarifying the problem for me. I do agree > with you. This issue should be fixed ASAP. Using objcg is a good > choice. Dying objcg should not be a problem. Because the size of > objcg is so small compared to memcg. > Just wanted to say out loud that yes this patchset will reduce the memcg zombie issue but this is not the final destination. We should continue the discussions on sharing/reusing scenarios. Muchun, can you please also CC Hugh Dickins and Alex Shi in the next version of your patchset? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6A90C433B4 for ; Thu, 1 Apr 2021 17:16:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 19050613C7 for ; Thu, 1 Apr 2021 17:15:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19050613C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3E2C46B0073; Thu, 1 Apr 2021 13:15:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3901D6B0074; Thu, 1 Apr 2021 13:15:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 230DF6B0075; Thu, 1 Apr 2021 13:15:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id 038906B0073 for ; Thu, 1 Apr 2021 13:15:58 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A46F212C0 for ; Thu, 1 Apr 2021 17:15:58 +0000 (UTC) X-FDA: 77984450796.05.37648D3 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf13.hostedemail.com (Postfix) with ESMTP id 15FE6E000113 for ; Thu, 1 Apr 2021 17:15:56 +0000 (UTC) Received: by mail-lf1-f47.google.com with SMTP id m12so3907567lfq.10 for ; Thu, 01 Apr 2021 10:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WVDGqZfP8CTFi7i9UziPzlSl+qgQw2QPqRQAU0O6vCI=; b=IX55qoHfL8y3EtErFQYBvPcpWM6kg4j9Lq7Vuh5ufhjKJGc3KczMGzc39TUpbbMzVT CSpHGFsKsQjzUA+LqiSMVyfny3edaLBYuDm341QVKfxWacX5CDe3xo8Gab0ojqeah7fX ZGURyN/PM7LJn8ERrBrnbEetwPBOpv2Izcp5McUcxF7YsVw2cGtb3ma6B3xaHbuP5beZ pDd0HTgJInatB++grkOkHnOxfrMSvpLovoiaq+elQ4XjXk0GKhKLf5po4n4tYIteamhq Unar5bdRt0RiBRd1sHJ3AFfkPmNg7Rn2gESb6l9hDtCPl4h838xz/1HIYYpEcL5qs08Q Q1lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WVDGqZfP8CTFi7i9UziPzlSl+qgQw2QPqRQAU0O6vCI=; b=XqTPfvEAYOmeJIpXUihiUbraM81KLAz2EOO3OHZeIDuz3v4Nzv3PU4tLavOvYV1MCr /0b2arE6yz+DcAJ+SwgKfe8TwrNDnumRye/ANCVZ8qi1kXER1I8Qv+BAF5RIhJsJMTY8 DypJmgv2o81jbkOU441AKXwrJ/wCXByUG7IJYHxEHGyKimkSIhraD9qzLZi3DUnTunpw QKt5szUo1yjqqgnk7vvaU2M0W5o2BNQ38oYoafrib5MzCp/KBn9VL17S8BDH1RRC8j54 DsvbsA0KviZ5GzdmYdT5AxuBUz3/S7LvIQ/STq390vZBLrqTMcmgcptLUKOHr0wfYs1z y5fQ== X-Gm-Message-State: AOAM530RfY12V1bUoQ9wBR2TD3Sc169lZIQlby7GFsXHfY8RUsbQgXHM ibfW88Ce61JlvOIDR2Eagr1UFW5RORNvPJnNFxgfXw== X-Google-Smtp-Source: ABdhPJyTtcQEz3dDdExeyagC8hu6fOgWKz7iFXCveSspTZ6Jukk9GiQddSqWeVrwsI2KQRRtDE1x/0e3S0nFutElX6A= X-Received: by 2002:a05:6512:2356:: with SMTP id p22mr5958452lfu.347.1617297356582; Thu, 01 Apr 2021 10:15:56 -0700 (PDT) MIME-Version: 1.0 References: <20210330101531.82752-1-songmuchun@bytedance.com> In-Reply-To: From: Shakeel Butt Date: Thu, 1 Apr 2021 10:15:45 -0700 Message-ID: Subject: Re: [External] Re: [RFC PATCH 00/15] Use obj_cgroup APIs to charge the LRU pages To: Muchun Song Cc: Johannes Weiner , Roman Gushchin , Greg Thelen , Michal Hocko , Andrew Morton , Vladimir Davydov , LKML , Linux MM , Xiongchun duan Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 4zy4gtfx64w3b8rjkpmih9urx93ib44z X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 15FE6E000113 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf13; identity=mailfrom; envelope-from=""; helo=mail-lf1-f47.google.com; client-ip=209.85.167.47 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617297356-864959 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 1, 2021 at 9:08 AM Muchun Song wrote: > [...] > > The zombie issue is a pretty urgent concern that has caused several > > production emergencies now. It needs a fix sooner rather than later. > > Thank you very much for clarifying the problem for me. I do agree > with you. This issue should be fixed ASAP. Using objcg is a good > choice. Dying objcg should not be a problem. Because the size of > objcg is so small compared to memcg. > Just wanted to say out loud that yes this patchset will reduce the memcg zombie issue but this is not the final destination. We should continue the discussions on sharing/reusing scenarios. Muchun, can you please also CC Hugh Dickins and Alex Shi in the next version of your patchset?