From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0C8AC433B4 for ; Tue, 13 Apr 2021 13:28:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A81CF613B1 for ; Tue, 13 Apr 2021 13:28:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345986AbhDMN3A (ORCPT ); Tue, 13 Apr 2021 09:29:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242158AbhDMN2n (ORCPT ); Tue, 13 Apr 2021 09:28:43 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D977C061574 for ; Tue, 13 Apr 2021 06:28:23 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id r22so8629281ljc.5 for ; Tue, 13 Apr 2021 06:28:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Hj/SeZ1ZvvwY1xIzJooNaPGvpH3onFVxBgFQtfF6dKs=; b=b5uJDNpPZbifglYYEysAar2xQtFPzsraSWEM4TDaO+4wZXQiLchll2ftbQN4OaTVoS CVOXKoqUpICrWyhMIeJQya5LKJmA/im+tlRBCtBLgSpBDTOmaYCcdwHrRbkl7mBZPYxC AbSC7cZNjgfZQlIfdWAtWvymvtrpX+ZiYbkydyhtR4XY93fFeV3l7KaCzG7PhLC/gMnA dX83Q0DNRfUXDQTaISGbVrG5H2kP5Gr+VuUHY4sBpxld5+SzquxYs87K/xFh7kJFdjQf sx0z7JLZkJbHa/DG2l7xo/dAznjYkEsrwivW16Dhhng4JSWR3rqpax9U7TP90BaGmAIc HDVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Hj/SeZ1ZvvwY1xIzJooNaPGvpH3onFVxBgFQtfF6dKs=; b=DtUgWepKlIOhWomu4dYC/UFmFS3B6UziFWrq1twOf4Flk+feU0vRRUQGyOtXF62CV3 9uwtoVIM7NAucBd47vue1HgEoeKoB2iX+V1vr1y6UoH/2lDro2zDsiQX2G5P91iXdrfR 7OhBuQyp+vnepcSfEKomxfXz9iTNKZGVDyRuAnpnygEzz04F4U4w8DepZ1PX1DyOuldR eWWgjHNV1zh7LliFU27DZf3mis8t9GPwalhrnTSfEqxQstgfc8krJeXK43TLI8aRsDc6 Jd9Ue3LnkPUq6M3GMm9aJK3b+czDqumRG0JdMWG0dTJSSyg5YVB9iH1ANV+tjE7Vbtjw B9eg== X-Gm-Message-State: AOAM533reXChNPrVg76rC9TrYVfqw8lW8jI3cX60f78z/mMcUbpyuUQx Qeksb1YTb0ZnY2SUa3+s75eQ4bG2z8R/Wr2AFBGjOQ== X-Google-Smtp-Source: ABdhPJxxakCZqZ1Ab2CgtoWpKw/Pji9vy4PUpSty494sfE4n1OebazycmnhmYDcpWpHnnzHE8VbrITfOH+HnUDVQvLo= X-Received: by 2002:a2e:8084:: with SMTP id i4mr21632742ljg.122.1618320501679; Tue, 13 Apr 2021 06:28:21 -0700 (PDT) MIME-Version: 1.0 References: <20210413065153.63431-1-songmuchun@bytedance.com> <20210413065153.63431-5-songmuchun@bytedance.com> In-Reply-To: <20210413065153.63431-5-songmuchun@bytedance.com> From: Shakeel Butt Date: Tue, 13 Apr 2021 06:28:09 -0700 Message-ID: Subject: Re: [PATCH 4/7] mm: memcontrol: simplify lruvec_holds_page_lru_lock To: Muchun Song Cc: Roman Gushchin , Johannes Weiner , Michal Hocko , Andrew Morton , Vladimir Davydov , LKML , Linux MM , Xiongchun duan , fam.zheng@bytedance.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 12, 2021 at 11:57 PM Muchun Song wrote: > > We already have a helper lruvec_memcg() to get the memcg from lruvec, we > do not need to do it ourselves in the lruvec_holds_page_lru_lock(). So use > lruvec_memcg() instead. And if mem_cgroup_disabled() returns false, the > page_memcg(page) (the LRU pages) cannot be NULL. So remove the odd logic > of "memcg = page_memcg(page) ? : root_mem_cgroup". And use lruvec_pgdat > to simplify the code. We can have a single definition for this function > that works for !CONFIG_MEMCG, CONFIG_MEMCG + mem_cgroup_disabled() and > CONFIG_MEMCG. > > Signed-off-by: Muchun Song > Acked-by: Johannes Weiner Reviewed-by: Shakeel Butt From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F428C43460 for ; Tue, 13 Apr 2021 13:28:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E46C3613B6 for ; Tue, 13 Apr 2021 13:28:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E46C3613B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 515A66B0036; Tue, 13 Apr 2021 09:28:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49DFC6B006E; Tue, 13 Apr 2021 09:28:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33F126B0070; Tue, 13 Apr 2021 09:28:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0049.hostedemail.com [216.40.44.49]) by kanga.kvack.org (Postfix) with ESMTP id 141016B0036 for ; Tue, 13 Apr 2021 09:28:24 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C219E3E3DF for ; Tue, 13 Apr 2021 13:28:23 +0000 (UTC) X-FDA: 78027422886.20.49EB1F0 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by imf27.hostedemail.com (Postfix) with ESMTP id 01C2180192C0 for ; Tue, 13 Apr 2021 13:28:12 +0000 (UTC) Received: by mail-lj1-f171.google.com with SMTP id u20so19306886lja.13 for ; Tue, 13 Apr 2021 06:28:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Hj/SeZ1ZvvwY1xIzJooNaPGvpH3onFVxBgFQtfF6dKs=; b=b5uJDNpPZbifglYYEysAar2xQtFPzsraSWEM4TDaO+4wZXQiLchll2ftbQN4OaTVoS CVOXKoqUpICrWyhMIeJQya5LKJmA/im+tlRBCtBLgSpBDTOmaYCcdwHrRbkl7mBZPYxC AbSC7cZNjgfZQlIfdWAtWvymvtrpX+ZiYbkydyhtR4XY93fFeV3l7KaCzG7PhLC/gMnA dX83Q0DNRfUXDQTaISGbVrG5H2kP5Gr+VuUHY4sBpxld5+SzquxYs87K/xFh7kJFdjQf sx0z7JLZkJbHa/DG2l7xo/dAznjYkEsrwivW16Dhhng4JSWR3rqpax9U7TP90BaGmAIc HDVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Hj/SeZ1ZvvwY1xIzJooNaPGvpH3onFVxBgFQtfF6dKs=; b=ThO2n3NQPqH0LCXTAwJMgkWIZ9rBBs8vhJ/w5vJuTfxy2U0PiJw7DM7AVaqR5YfIVz kmUAlspyC6i4Jc5GBqah6lmfCtDPI1+6HGW+sJVmcCYNa+7WQ2wlIps3q202gXNtMRRJ GTQFJI3Xh/ZMYks6/VsQACg33I+ZW3t+O9IvJZ9814ExoDF6hs6X+k5nFH5n6wPc3hNW POZ6zgSOkO4xay3x6NfWNwbkrUOapACzH5ReZX+Eo+LPC7gxLyt8mDxcZEUA+aX34z7n k9c1LvXP1nkA9abyMKnRlicUFJmYpKQEfdspIWV4sHxoRzTFMpkOURz2ozw/+NfHmn9D Lo+g== X-Gm-Message-State: AOAM533wiLbZ+DoPCC4xTWxPSDDkS0+z8pxXuL0f5STs3GyNV9n3OSBx rmELzYelyK2jPCbi/Mr7AqIqZQ7cdh0KkOr4lWxGdw== X-Google-Smtp-Source: ABdhPJxxakCZqZ1Ab2CgtoWpKw/Pji9vy4PUpSty494sfE4n1OebazycmnhmYDcpWpHnnzHE8VbrITfOH+HnUDVQvLo= X-Received: by 2002:a2e:8084:: with SMTP id i4mr21632742ljg.122.1618320501679; Tue, 13 Apr 2021 06:28:21 -0700 (PDT) MIME-Version: 1.0 References: <20210413065153.63431-1-songmuchun@bytedance.com> <20210413065153.63431-5-songmuchun@bytedance.com> In-Reply-To: <20210413065153.63431-5-songmuchun@bytedance.com> From: Shakeel Butt Date: Tue, 13 Apr 2021 06:28:09 -0700 Message-ID: Subject: Re: [PATCH 4/7] mm: memcontrol: simplify lruvec_holds_page_lru_lock To: Muchun Song Cc: Roman Gushchin , Johannes Weiner , Michal Hocko , Andrew Morton , Vladimir Davydov , LKML , Linux MM , Xiongchun duan , fam.zheng@bytedance.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 01C2180192C0 X-Stat-Signature: 4xckf7tboobmc16j4bjkujkmx95e3kmn X-Rspamd-Server: rspam02 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf27; identity=mailfrom; envelope-from=""; helo=mail-lj1-f171.google.com; client-ip=209.85.208.171 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618320492-271880 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 12, 2021 at 11:57 PM Muchun Song wrote: > > We already have a helper lruvec_memcg() to get the memcg from lruvec, we > do not need to do it ourselves in the lruvec_holds_page_lru_lock(). So use > lruvec_memcg() instead. And if mem_cgroup_disabled() returns false, the > page_memcg(page) (the LRU pages) cannot be NULL. So remove the odd logic > of "memcg = page_memcg(page) ? : root_mem_cgroup". And use lruvec_pgdat > to simplify the code. We can have a single definition for this function > that works for !CONFIG_MEMCG, CONFIG_MEMCG + mem_cgroup_disabled() and > CONFIG_MEMCG. > > Signed-off-by: Muchun Song > Acked-by: Johannes Weiner Reviewed-by: Shakeel Butt