From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC2DAC433E0 for ; Wed, 27 May 2020 16:50:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6BC2320787 for ; Wed, 27 May 2020 16:50:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="eN/xrHM4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BC2320787 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 059C8800B6; Wed, 27 May 2020 12:50:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00A1880010; Wed, 27 May 2020 12:50:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3B40800B6; Wed, 27 May 2020 12:50:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0191.hostedemail.com [216.40.44.191]) by kanga.kvack.org (Postfix) with ESMTP id C8BE780010 for ; Wed, 27 May 2020 12:50:23 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 85B5022C618 for ; Wed, 27 May 2020 16:50:23 +0000 (UTC) X-FDA: 76863087126.02.cloth36_161633426d53 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 6EBCA82DA9 for ; Wed, 27 May 2020 16:50:23 +0000 (UTC) X-HE-Tag: cloth36_161633426d53 X-Filterd-Recvd-Size: 3516 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 May 2020 16:50:22 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id k5so29735194lji.11 for ; Wed, 27 May 2020 09:50:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1zPnuLTvgprdTVM4lyX4wiBkB+XwPNWKNu3f5Lxz02s=; b=eN/xrHM4bcrmGppt3VwmPF48oii8uREomXNXGJofLy/UiMHveURMD8R31PSOHxW+fx VCzf2zlhdE422jlGR2fETv7FS+o67Bl3zmIbl175bgQsf1+bvkaO8Fh4qEKsDHeHedyA AT3mvMzj3zZdlmYGhFd7kcZ34AZq1oMxcHAGYl22G8aWeicey18DykQEze99QWaVzttx 4VH8vFuYd1U1Okb5SdQXc+EoZytk9eGTvgRumvb6QSjRouqOgzmsouN1X69gjYwftTBZ BkpDC3DchvTHnJvHkbVChjblgiUXDjqEt8LgGWsvzEKtHTW6wnQlsVer6XxRBzfqXcgO +rkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1zPnuLTvgprdTVM4lyX4wiBkB+XwPNWKNu3f5Lxz02s=; b=LEUuTVZ4qKRIoDb7qlo5DutFKOAd8a6kQKUpKbakJBWz+sElQI66FhIThrwlo1BZxq T65KqhyEOF/D2aWCfUcFOPxLOZ44YFvXHIFdidjTeolGek49/lk6dx5uE+VeTN3Nrag2 +AisDMANJGwiV8eUZ+MikcsZzXbrbIkBwTpsHzwT+ftanc/d7tO6jftWO5L1pvE5XIHx kp9PcdXpdn9BaeGyIpAaMhmpW5BKURizTfk3WioO8RqG82/o/QqZVyFxJwDC9ZBwl4Y5 iXF2BUnOpRj3jW2r2Uxsidg8WHQuseE3oOoSz2I7x/hZXgtI5C0o6IMdj2cMYtbBpW/4 /4cw== X-Gm-Message-State: AOAM531uHWbUoDqZ+u14BQ2pUGJJaXaM/v1zNhOTzfQYnJhw29UaZpBv MAv71tsq/JSEb6erGPP/V9UFO6ll3/2iremTyehR6g== X-Google-Smtp-Source: ABdhPJxd4n5gepYQ3iTBd03RHtrAoA8GfOgL4pSvv2448ISIpzVRCCn1ztoXBlb3uTPyhPTcBQw2H6IqoO/uSjBX9H4= X-Received: by 2002:a2e:8e79:: with SMTP id t25mr3730099ljk.446.1590598221022; Wed, 27 May 2020 09:50:21 -0700 (PDT) MIME-Version: 1.0 References: <20200513090502.GV29153@dhcp22.suse.cz> <76f71776-d049-7407-8574-86b6e9d80704@huawei.com> <20200513112905.GX29153@dhcp22.suse.cz> <1d202a12-26fe-0012-ea14-f025ddcd044a@huawei.com> In-Reply-To: <1d202a12-26fe-0012-ea14-f025ddcd044a@huawei.com> From: Shakeel Butt Date: Wed, 27 May 2020 09:50:07 -0700 Message-ID: Subject: Re: [PATCH v3] memcg: Fix memcg_kmem_bypass() for remote memcg charging To: Zefan Li Cc: Michal Hocko , Andrew Morton , Johannes Weiner , Vladimir Davydov , Cgroups , Linux MM , Roman Gushchin Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 6EBCA82DA9 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 25, 2020 at 6:25 PM Zefan Li wrote: > > While trying to use remote memcg charging in an out-of-tree kernel module > I found it's not working, because the current thread is a workqueue thread. > > As we will probably encounter this issue in the future as the users of > memalloc_use_memcg() grow, and it's nothing wrong for this usage, it's > better we fix it now. > > Acked-by: Johannes Weiner > Signed-off-by: Zefan Li Reviewed-by: Shakeel Butt From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shakeel Butt Subject: Re: [PATCH v3] memcg: Fix memcg_kmem_bypass() for remote memcg charging Date: Wed, 27 May 2020 09:50:07 -0700 Message-ID: References: <20200513090502.GV29153@dhcp22.suse.cz> <76f71776-d049-7407-8574-86b6e9d80704@huawei.com> <20200513112905.GX29153@dhcp22.suse.cz> <1d202a12-26fe-0012-ea14-f025ddcd044a@huawei.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1zPnuLTvgprdTVM4lyX4wiBkB+XwPNWKNu3f5Lxz02s=; b=eN/xrHM4bcrmGppt3VwmPF48oii8uREomXNXGJofLy/UiMHveURMD8R31PSOHxW+fx VCzf2zlhdE422jlGR2fETv7FS+o67Bl3zmIbl175bgQsf1+bvkaO8Fh4qEKsDHeHedyA AT3mvMzj3zZdlmYGhFd7kcZ34AZq1oMxcHAGYl22G8aWeicey18DykQEze99QWaVzttx 4VH8vFuYd1U1Okb5SdQXc+EoZytk9eGTvgRumvb6QSjRouqOgzmsouN1X69gjYwftTBZ BkpDC3DchvTHnJvHkbVChjblgiUXDjqEt8LgGWsvzEKtHTW6wnQlsVer6XxRBzfqXcgO +rkQ== In-Reply-To: <1d202a12-26fe-0012-ea14-f025ddcd044a-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Zefan Li Cc: Michal Hocko , Andrew Morton , Johannes Weiner , Vladimir Davydov , Cgroups , Linux MM , Roman Gushchin On Mon, May 25, 2020 at 6:25 PM Zefan Li wrote: > > While trying to use remote memcg charging in an out-of-tree kernel module > I found it's not working, because the current thread is a workqueue thread. > > As we will probably encounter this issue in the future as the users of > memalloc_use_memcg() grow, and it's nothing wrong for this usage, it's > better we fix it now. > > Acked-by: Johannes Weiner > Signed-off-by: Zefan Li Reviewed-by: Shakeel Butt