From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E855EC433EF for ; Fri, 4 Mar 2022 04:31:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 436C98D0002; Thu, 3 Mar 2022 23:31:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 40C478D0001; Thu, 3 Mar 2022 23:31:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D56A8D0002; Thu, 3 Mar 2022 23:31:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0085.hostedemail.com [216.40.44.85]) by kanga.kvack.org (Postfix) with ESMTP id 1F1CF8D0001 for ; Thu, 3 Mar 2022 23:31:20 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D35BB978FE for ; Fri, 4 Mar 2022 04:31:19 +0000 (UTC) X-FDA: 79205429478.29.C3524AB Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf18.hostedemail.com (Postfix) with ESMTP id 639561C0006 for ; Fri, 4 Mar 2022 04:31:19 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id p3-20020a17090a680300b001bbfb9d760eso9665526pjj.2 for ; Thu, 03 Mar 2022 20:31:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HkmuC6LUR69e1RHJ1291GzyzK763QWWvo9uSMMvn1DI=; b=L5ykbH0MXGPy5HOibQRXZ+mNiYY8Bp3zDggzF0WONXOnc+pt+0Y8lK1oApme8ZRHpo 6cCxMVLCkFJTSVpdRxg2Olv4NMjEpGfh5ANZ1kU4Zu1jCSoystG7UEaxQHNzfE9VKGGI 44PjpMgOvPi0C1G/5A7gL7mszMinJUEj0VFMxMfJACsYU0kFsrQ4yey1cHfI9OkqMDXY xKa1kH9oIo2oIj33q0O/vVJdeFmGd48OR0xNID8uL7JcrAwdtR7B2X58r5XElNFXzzSN Y+75EATjKv6NGJ4SX94FyY6u/3ObgsOeyGb2EK3am4Vg4qUYI4x02cItjDpxJ+PP0oWX WYQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HkmuC6LUR69e1RHJ1291GzyzK763QWWvo9uSMMvn1DI=; b=xDNYefUBOjXbuoqGmRNrTr4EnRiT3/l4lqNr9MmxI9Z3TuyklTYwpSlQVpb8M/Ak+O tGIK0iSH/dnJ7ty4qaWBg6r8LBNjtKQWlqKMDjYFRsGLcfzmzk58uWfC2rSdCwgICvXV VShUGY3s2gPffYIXRTcn8vWFTIjAeVCFfcMXi66PGQXW7ImzHqu7V3VZSRCRLPDAhbNa GXTPcBYkqc/a+6aT5w5zKLNoW1OO9qMEMZ/6KubXgHTpiELWiAYjLd+JT5AuTme/rYV9 dnyFjMS/S9e4m1/WOeFa+g3COrqiE4OLrME1mnPtNbZQ0yA6zt/Ror0B0hsVE/hR++MD nBvQ== X-Gm-Message-State: AOAM533JJo1+Phc1BOZKtaO13vfHzj3ktdRThqXnXkP9mhmDyYrVb6bv DZeKLaRTNYfrr0vxfuJft86q0ZYBfZROe1Fwtg8K9ZZBbwM= X-Google-Smtp-Source: ABdhPJx4WCefiRjkjPcPq0VIWZv0ZfNq2BmMIGX9FhcKOohSipnfz8xX8zeP256sQ6763693rIPbrX9TLkFM6/mLkiE= X-Received: by 2002:a17:903:2cb:b0:14f:4fb6:2fb0 with SMTP id s11-20020a17090302cb00b0014f4fb62fb0mr38458840plk.172.1646355953343; Thu, 03 Mar 2022 17:05:53 -0800 (PST) MIME-Version: 1.0 References: <20220225180345.GD12037@blackbody.suse.cz> <20220228230949.xrmy6j2glxsoffko@google.com> <20220302025022.nnmpwxmkqed2icck@google.com> <20220303023504.gux47rd5wvnikymh@google.com> In-Reply-To: From: Shakeel Butt Date: Thu, 3 Mar 2022 17:05:39 -0800 Message-ID: Subject: Re: Regression in workingset_refault latency on 5.15 To: Ivan Babrou Cc: =?UTF-8?Q?Michal_Koutn=C3=BD?= , Daniel Dao , kernel-team , Linux MM , Johannes Weiner , Roman Gushchin , Feng Tang , Michal Hocko , Hillf Danton , Andrew Morton , Linus Torvalds Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 639561C0006 X-Stat-Signature: nnry8n6m8tx75zgsfqnbf5pgcoskkxr4 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=L5ykbH0M; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of shakeelb@google.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=shakeelb@google.com X-HE-Tag: 1646368279-288679 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 3, 2022 at 4:21 PM Ivan Babrou wrote: > > On Wed, Mar 2, 2022 at 6:35 PM Shakeel Butt wrote: > > > > On Wed, Mar 02, 2022 at 02:33:41PM -0800, Ivan Babrou wrote: > > > On Tue, Mar 1, 2022 at 7:40 PM Ivan Babrou wrote: > > [...] > > > > Please try the following patch: > > * Linux 5.10.101: > > $ sudo /usr/share/bcc/tools/funclatency -d 60 workingset_refault > Tracing 1 functions for "workingset_refault"... Hit Ctrl-C to end. > > nsecs : count distribution > 0 -> 1 : 0 | | > 2 -> 3 : 0 | | > 4 -> 7 : 0 | | > 8 -> 15 : 0 | | > 16 -> 31 : 0 | | > 32 -> 63 : 0 | | > 64 -> 127 : 0 | | > 128 -> 255 : 0 | | > 256 -> 511 : 5496 |****************************************| > 512 -> 1023 : 3161 |*********************** | > 1024 -> 2047 : 1059 |******* | > 2048 -> 4095 : 3149 |********************** | > 4096 -> 8191 : 2074 |*************** | > 8192 -> 16383 : 90 | | > 16384 -> 32767 : 43 | | > 32768 -> 65535 : 44 | | > 65536 -> 131071 : 12 | | > 131072 -> 262143 : 3 | | > 262144 -> 524287 : 1 | | > > avg = 2144 nsecs, total: 32453571 nsecs, count: 15132 > > * Linux 5.15.25: > > $ sudo /usr/share/bcc/tools/funclatency -d 60 workingset_refault > Tracing 1 functions for "workingset_refault"... Hit Ctrl-C to end. > > nsecs : count distribution > 0 -> 1 : 0 | | > 2 -> 3 : 0 | | > 4 -> 7 : 0 | | > 8 -> 15 : 0 | | > 16 -> 31 : 0 | | > 32 -> 63 : 0 | | > 64 -> 127 : 0 | | > 128 -> 255 : 0 | | > 256 -> 511 : 132411 |****************************************| > 512 -> 1023 : 45547 |************* | > 1024 -> 2047 : 5869 |* | > 2048 -> 4095 : 10553 |*** | > 4096 -> 8191 : 5297 |* | > 8192 -> 16383 : 455 | | > 16384 -> 32767 : 214 | | > 32768 -> 65535 : 175 | | > 65536 -> 131071 : 50 | | > 131072 -> 262143 : 6 | | > 262144 -> 524287 : 2 | | > 524288 -> 1048575 : 80 | | > 1048576 -> 2097151 : 3228 | | > 2097152 -> 4194303 : 13514 |**** | > 4194304 -> 8388607 : 792 | | > 8388608 -> 16777215 : 1 | | > > avg = 221955 nsecs, total: 48429632352 nsecs, count: 218195 > > * Linux 5.15.25 + delayed flush: > > $ sudo /usr/share/bcc/tools/funclatency -d 60 workingset_refault > Tracing 1 functions for "workingset_refault"... Hit Ctrl-C to end. > > nsecs : count distribution > 0 -> 1 : 0 | | > 2 -> 3 : 0 | | > 4 -> 7 : 0 | | > 8 -> 15 : 0 | | > 16 -> 31 : 0 | | > 32 -> 63 : 0 | | > 64 -> 127 : 0 | | > 128 -> 255 : 0 | | > 256 -> 511 : 103067 |****************************************| > 512 -> 1023 : 39054 |*************** | > 1024 -> 2047 : 8953 |*** | > 2048 -> 4095 : 12986 |***** | > 4096 -> 8191 : 10173 |*** | > 8192 -> 16383 : 8090 |*** | > 16384 -> 32767 : 890 | | > 32768 -> 65535 : 540 | | > 65536 -> 131071 : 198 | | > 131072 -> 262143 : 50 | | > 262144 -> 524287 : 7 | | > > avg = 1837 nsecs, total: 338115740 nsecs, count: 184008 > > * Linux 5.15.25 + your latest patch with "if_late": > > $ sudo /usr/share/bcc/tools/funclatency -d 60 workingset_refault > Tracing 1 functions for "workingset_refault"... Hit Ctrl-C to end. > > nsecs : count distribution > 0 -> 1 : 0 | | > 2 -> 3 : 0 | | > 4 -> 7 : 0 | | > 8 -> 15 : 0 | | > 16 -> 31 : 0 | | > 32 -> 63 : 0 | | > 64 -> 127 : 0 | | > 128 -> 255 : 0 | | > 256 -> 511 : 9241 |****************************************| > 512 -> 1023 : 7041 |****************************** | > 1024 -> 2047 : 1457 |****** | > 2048 -> 4095 : 3401 |************** | > 4096 -> 8191 : 2207 |********* | > 8192 -> 16383 : 130 | | > 16384 -> 32767 : 53 | | > 32768 -> 65535 : 40 | | > 65536 -> 131071 : 16 | | > 131072 -> 262143 : 1 | | > 262144 -> 524287 : 1 | | > > avg = 1663 nsecs, total: 39249164 nsecs, count: 23588 > > The numbers look pretty good. Thanks a lot Ivan. I will send the signed-off patch for 'if_late' and I would like to have your Tested-by on that.