From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E8ABC433E0 for ; Wed, 27 May 2020 19:46:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 502E42088E for ; Wed, 27 May 2020 19:46:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="tgQVm3l2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728337AbgE0Tq0 (ORCPT ); Wed, 27 May 2020 15:46:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725872AbgE0Tq0 (ORCPT ); Wed, 27 May 2020 15:46:26 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E20FC05BD1E for ; Wed, 27 May 2020 12:46:25 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id e4so7970020ljn.4 for ; Wed, 27 May 2020 12:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mWhAV+oalNjQE28LBxoMsLXJD6jlzY/ddZHzS5PvNwY=; b=tgQVm3l2X8qPOygWBAnzNsgUIRIcVeW2WuBwqzLOuKVx3HMHaiOAay8Zivr02tExiz 6VtK81R3seVi6PTDTNkRw090IS5JYXDZklfI8TtuFyDUGIt3ZMtYFdKHVbX/lH+rpDAN AsnFxXNdnRY0OKiSi/PctDt0ko1DsNswoTGUpzqg3RyPFA+1AxX6StlVcpuLUv4CTQZk 5wXe7T86+CQnb/J7QN2nApObS8C8S12EhYq707hVdn11Llw5MjPqTYIzgBLu0wjWENtI 4OQZvOVY0galy6YdtiwNnrOJGoB1KX9XEnCXCXiq6vtYNNo9CKQ/0VCj2w4ARspj9AQr DKCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mWhAV+oalNjQE28LBxoMsLXJD6jlzY/ddZHzS5PvNwY=; b=Qo8Rp3b6XFeqpJnzQ5D0tqbMQ4yHvLtq6sIH6o0SjOgz1oPz8TjE3vGEKBA5OCm131 EJ+GPiD2AXK4SL7LNIjyRjE6Hm7/PuTF3iysGUzr3wYZxfnnRCVi+PFfkkIsaDwCkh/D bqrAG9Htn7GEofpDFv1ndKC3hJT0mvm4EJ/JnU1n0WyZTKPqC60JIK1IHFUYJ7ZpT0SR KfuCLv4AFF1YtKICfDlubPOIeAz+1ViaR6XeVJjIfUwJ9z0ehKnVv0DhEwigltb9oYzR 5E3nRHgGmSD+3+j1kmctc3KrBbEHgTMsehGwX5IShjjwraJKroQlUbdgDpQaBvy4PD44 +5+w== X-Gm-Message-State: AOAM5303ykw9DGPHzC4BM8hwW5tPshDqnnJn1Klw6ygQ2n+YC5lcy5vG rAT9cb4X87DW8KuKRJrezMFPd1nakDAFYV/EG1QqSg== X-Google-Smtp-Source: ABdhPJxOcdjgr3W3iJp2ZHQW3sk0rlBDc+qPkqLsHMJGAot3E0Nyk/3oLAFsChktA4ZzE+QNK+yp04GOTz4yqxubtcc= X-Received: by 2002:a2e:a58a:: with SMTP id m10mr3993911ljp.347.1590608783797; Wed, 27 May 2020 12:46:23 -0700 (PDT) MIME-Version: 1.0 References: <20200527182958.252402-1-shakeelb@google.com> <20200527194148.GA47905@cmpxchg.org> In-Reply-To: <20200527194148.GA47905@cmpxchg.org> From: Shakeel Butt Date: Wed, 27 May 2020 12:46:12 -0700 Message-ID: Subject: Re: [PATCH resend 3/3] mm: fix LRU balancing effect of new transparent huge pages To: Johannes Weiner Cc: Mel Gorman , Roman Gushchin , Michal Hocko , Andrew Morton , Minchan Kim , Rik van Riel , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2020 at 12:42 PM Johannes Weiner wrote: > > On Wed, May 27, 2020 at 11:29:58AM -0700, Shakeel Butt wrote: > > From: Johannes Weiner > > > > Currently, THP are counted as single pages until they are split right > > before being swapped out. However, at that point the VM is already in > > the middle of reclaim, and adjusting the LRU balance then is useless. > > > > Always account THP by the number of basepages, and remove the fixup > > from the splitting path. > > > > Signed-off-by: Johannes Weiner > > Signed-off-by: Shakeel Butt > > This is now already in mm as part of the "mm: balance LRU lists based > on relative thrashing" series that I sent out last week and where it > was originally from. Oh sorry, I missed it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91F2BC433DF for ; Wed, 27 May 2020 19:46:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5D72020B80 for ; Wed, 27 May 2020 19:46:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="tgQVm3l2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D72020B80 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F105C8001A; Wed, 27 May 2020 15:46:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE32F80010; Wed, 27 May 2020 15:46:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1F428001A; Wed, 27 May 2020 15:46:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id C821B80010 for ; Wed, 27 May 2020 15:46:26 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8282D8245578 for ; Wed, 27 May 2020 19:46:26 +0000 (UTC) X-FDA: 76863530772.09.skate56_520cc3826d54 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 66EDD180AD815 for ; Wed, 27 May 2020 19:46:26 +0000 (UTC) X-HE-Tag: skate56_520cc3826d54 X-Filterd-Recvd-Size: 3679 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 May 2020 19:46:25 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id m12so28039989ljc.6 for ; Wed, 27 May 2020 12:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mWhAV+oalNjQE28LBxoMsLXJD6jlzY/ddZHzS5PvNwY=; b=tgQVm3l2X8qPOygWBAnzNsgUIRIcVeW2WuBwqzLOuKVx3HMHaiOAay8Zivr02tExiz 6VtK81R3seVi6PTDTNkRw090IS5JYXDZklfI8TtuFyDUGIt3ZMtYFdKHVbX/lH+rpDAN AsnFxXNdnRY0OKiSi/PctDt0ko1DsNswoTGUpzqg3RyPFA+1AxX6StlVcpuLUv4CTQZk 5wXe7T86+CQnb/J7QN2nApObS8C8S12EhYq707hVdn11Llw5MjPqTYIzgBLu0wjWENtI 4OQZvOVY0galy6YdtiwNnrOJGoB1KX9XEnCXCXiq6vtYNNo9CKQ/0VCj2w4ARspj9AQr DKCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mWhAV+oalNjQE28LBxoMsLXJD6jlzY/ddZHzS5PvNwY=; b=fRRHnnTSb24QL41Ja8ft7dWFT0laNQCtoJJHOVqlM7j89HYaxhccJjAP9/WvsT/tqY oqpzefh5tyR/VHAGFA5nGARd4es5vtxYoFnX71CoKtR8iqSZGKt23N77PNvQW8ZyXalW 7nrz6f6cZGrzmupMg/Tx6c5w+DPUpp6KEJq7I762P0/fhRPLUijQ1XtPlnHzauysS2OY aAZ6XjSY4R8m+c19NODi7i7rNj5dhqLZ8UTyU0PXtOT5pLvVR361JUQIpA3ttQIy3H08 GnLQpRg1BkrXHD1SCYYeD0IMDxhP5uPj3W6dVsmzKG6NWwB4PAC3Bwh1xkI9J45K61i+ Vszw== X-Gm-Message-State: AOAM5330Fs0HiFlH4fJTsFzOUQkk3lqcL6kG7UahiHlNp7tx3P3j9CEG S0IwU9BLkNgrtc4uy0vZxH364VfEb3u/5lCOBWN2Iw== X-Google-Smtp-Source: ABdhPJxOcdjgr3W3iJp2ZHQW3sk0rlBDc+qPkqLsHMJGAot3E0Nyk/3oLAFsChktA4ZzE+QNK+yp04GOTz4yqxubtcc= X-Received: by 2002:a2e:a58a:: with SMTP id m10mr3993911ljp.347.1590608783797; Wed, 27 May 2020 12:46:23 -0700 (PDT) MIME-Version: 1.0 References: <20200527182958.252402-1-shakeelb@google.com> <20200527194148.GA47905@cmpxchg.org> In-Reply-To: <20200527194148.GA47905@cmpxchg.org> From: Shakeel Butt Date: Wed, 27 May 2020 12:46:12 -0700 Message-ID: Subject: Re: [PATCH resend 3/3] mm: fix LRU balancing effect of new transparent huge pages To: Johannes Weiner Cc: Mel Gorman , Roman Gushchin , Michal Hocko , Andrew Morton , Minchan Kim , Rik van Riel , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 66EDD180AD815 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 27, 2020 at 12:42 PM Johannes Weiner wrote: > > On Wed, May 27, 2020 at 11:29:58AM -0700, Shakeel Butt wrote: > > From: Johannes Weiner > > > > Currently, THP are counted as single pages until they are split right > > before being swapped out. However, at that point the VM is already in > > the middle of reclaim, and adjusting the LRU balance then is useless. > > > > Always account THP by the number of basepages, and remove the fixup > > from the splitting path. > > > > Signed-off-by: Johannes Weiner > > Signed-off-by: Shakeel Butt > > This is now already in mm as part of the "mm: balance LRU lists based > on relative thrashing" series that I sent out last week and where it > was originally from. Oh sorry, I missed it.