From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06E3FC432BE for ; Mon, 2 Aug 2021 14:32:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE64460F4B for ; Mon, 2 Aug 2021 14:32:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234177AbhHBOc0 (ORCPT ); Mon, 2 Aug 2021 10:32:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234014AbhHBOcY (ORCPT ); Mon, 2 Aug 2021 10:32:24 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC03BC0613D5 for ; Mon, 2 Aug 2021 07:32:14 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id x8so20735047lfe.3 for ; Mon, 02 Aug 2021 07:32:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=19nfVkDw1JHrHyLVrxQ7C3iIv4HJUAVawRYI+zVDKis=; b=g2rXIt6PCcJyTa2L7O6qIeZjWDnqOSfddyk6MrYcfEsfL7ZHrImFAKiYu/6qeNFXml uFaNVZeiebZF2qSRn4MPkT99U8W2aI+dIRtgDQCtGeKJguajzSd2fILGxt3hoaOrg5Al jNhOcCLyG2pjA96otAuaSej7Cs/zqm5fq7ZGMOXetpdUIAfuG7QYlshPWqrprPyvnP/b eWM3QaOgo34fZF71q7x5gABjzMONsiYCOtCG0wrB3MMQG3KaQk5Cflt++3Ea2NnFguBI Vvm4lTfSqGY7YleaXqoyw66XVOUYcxVgtMYqifv6gkKvQu33r8bafyCu1ggNmNAPF1uk 2QEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=19nfVkDw1JHrHyLVrxQ7C3iIv4HJUAVawRYI+zVDKis=; b=cqkOAVytbysXqrwavRX4ITFPU8xg0fkyJKUgeTHPq7YkL0fl5Mw6aDUBPCQtoXOHij E35xi7f3P3ddEudaYf03LK53hdG/IenMp9K7c1Qa7HsFkRYJJkN5SmuvZ3eIaF71wvz1 X/LPwP+nBOPWN39Hh65S0JU377//bKWi+6/+jXUwgNaBY27NfYdeh/aRgMvGHE63+vRS 0jV9NzhFjCu7JRAz6E7tNdfRhRUKwmKvrD+2ZqgzSDk6dq4PvdbHxUdke1BWQTGZXVgu LTYYfBu1cVp+qzK4BLaUfWNaRnZR6AwmzIqKQkESia66I5Bnre4cfjJM8abCefFRCTQI SA1A== X-Gm-Message-State: AOAM532Ns+I8607rFLq1T1EFk1wf1uVUfkN9TZ9Ji5Jsbdo3WrWDRL/V U/eP7XSb6Idq2H2XJUrxD/JtB5gxPB1Fx3qSWID7ow== X-Google-Smtp-Source: ABdhPJw3boDKwPQvVaGncMOJTyPUymUUTg6mvCS3v3pvSwz7jcn5lVWSJhrMrzCzEd8llnaJ0PB/fY5esLDv7jWE+o8= X-Received: by 2002:a19:ae0f:: with SMTP id f15mr12931254lfc.117.1627914732988; Mon, 02 Aug 2021 07:32:12 -0700 (PDT) MIME-Version: 1.0 References: <20210802022827.10192-1-longman@redhat.com> In-Reply-To: <20210802022827.10192-1-longman@redhat.com> From: Shakeel Butt Date: Mon, 2 Aug 2021 07:32:01 -0700 Message-ID: Subject: Re: [PATCH] mm/memcg: Fix incorrect flushing of lruvec data in obj_stock To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Tejun Heo , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , LKML , Cgroups , Linux MM , Muchun Song , Alex Shi , Chris Down , Yafang Shao , Wei Yang , Masayoshi Mizuma , Xing Zhengjun , Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 1, 2021 at 7:28 PM Waiman Long wrote: > > When mod_objcg_state() is called with a pgdat that is different from > that in the obj_stock, the old lruvec data cached in obj_stock are > flushed out. Unfortunately, they were flushed to the new pgdat and > hence the wrong node, not the one cached in obj_stock. > > Fix that by flushing the data to the cached pgdat instead. > > Fixes: 68ac5b3c8db2 ("mm/memcg: cache vmstat data in percpu memcg_stock_pcp") > Signed-off-by: Waiman Long After incorporating Michal's comments, you can add: Reviewed-by: Shakeel Butt From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A691C4338F for ; Mon, 2 Aug 2021 14:32:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6851D60F50 for ; Mon, 2 Aug 2021 14:32:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6851D60F50 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id AFF538D0001; Mon, 2 Aug 2021 10:32:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB0276B0036; Mon, 2 Aug 2021 10:32:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99F578D0001; Mon, 2 Aug 2021 10:32:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0125.hostedemail.com [216.40.44.125]) by kanga.kvack.org (Postfix) with ESMTP id 7C1F96B0033 for ; Mon, 2 Aug 2021 10:32:15 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0E2BD1DE9D for ; Mon, 2 Aug 2021 14:32:15 +0000 (UTC) X-FDA: 78430380630.07.A706137 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf19.hostedemail.com (Postfix) with ESMTP id BD9D1B0001B9 for ; Mon, 2 Aug 2021 14:32:14 +0000 (UTC) Received: by mail-lf1-f49.google.com with SMTP id bq29so8487061lfb.5 for ; Mon, 02 Aug 2021 07:32:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=19nfVkDw1JHrHyLVrxQ7C3iIv4HJUAVawRYI+zVDKis=; b=g2rXIt6PCcJyTa2L7O6qIeZjWDnqOSfddyk6MrYcfEsfL7ZHrImFAKiYu/6qeNFXml uFaNVZeiebZF2qSRn4MPkT99U8W2aI+dIRtgDQCtGeKJguajzSd2fILGxt3hoaOrg5Al jNhOcCLyG2pjA96otAuaSej7Cs/zqm5fq7ZGMOXetpdUIAfuG7QYlshPWqrprPyvnP/b eWM3QaOgo34fZF71q7x5gABjzMONsiYCOtCG0wrB3MMQG3KaQk5Cflt++3Ea2NnFguBI Vvm4lTfSqGY7YleaXqoyw66XVOUYcxVgtMYqifv6gkKvQu33r8bafyCu1ggNmNAPF1uk 2QEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=19nfVkDw1JHrHyLVrxQ7C3iIv4HJUAVawRYI+zVDKis=; b=LpDp2Vdz6RyFdSmccLJUyVxp/dAIRXNZbAFpmHr7BnsujQdiY6MANi0b0uUTD1qtW8 8ss2Eg4lcEgsOIraj9aLlgR7oVvkzI+G8+NoKyg6Vuo0vOWiJ1txI9n/eZVoBd21w3HB VvN8mm5FgAJtOBWEXha78IYNQ5iNqj24HkJMnCndd+zh/u3kws1IQHwWaiFnEZx+AF7M lquSxh4SYfnTy8GLZenbl2r4TuFbl1YbLONcMOkAdXYHm6KyLtasmeeXrRQ3S+BQD32Q o44poFpgVaP7GcVuNUvvjkkRXEZs5H+QUURMMzHQPd4kshlsDLH9Qo2ct4lB4pfD91bo hQlQ== X-Gm-Message-State: AOAM532iwXAROsW+Pv2+mzsZRNl5KWtToeX+N0qBeZ0/kGK/LOad1lsW CU1rU6QderyPDr6o+FVBE5s7XsRRf5tYG3dAMSjjUw== X-Google-Smtp-Source: ABdhPJw3boDKwPQvVaGncMOJTyPUymUUTg6mvCS3v3pvSwz7jcn5lVWSJhrMrzCzEd8llnaJ0PB/fY5esLDv7jWE+o8= X-Received: by 2002:a19:ae0f:: with SMTP id f15mr12931254lfc.117.1627914732988; Mon, 02 Aug 2021 07:32:12 -0700 (PDT) MIME-Version: 1.0 References: <20210802022827.10192-1-longman@redhat.com> In-Reply-To: <20210802022827.10192-1-longman@redhat.com> From: Shakeel Butt Date: Mon, 2 Aug 2021 07:32:01 -0700 Message-ID: Subject: Re: [PATCH] mm/memcg: Fix incorrect flushing of lruvec data in obj_stock To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Tejun Heo , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , LKML , Cgroups , Linux MM , Muchun Song , Alex Shi , Chris Down , Yafang Shao , Wei Yang , Masayoshi Mizuma , Xing Zhengjun , Matthew Wilcox Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BD9D1B0001B9 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=g2rXIt6P; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=shakeelb@google.com X-Stat-Signature: 7pqjgjajedj6n1meq9yu86uf4jsjdkfm X-HE-Tag: 1627914734-546351 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Aug 1, 2021 at 7:28 PM Waiman Long wrote: > > When mod_objcg_state() is called with a pgdat that is different from > that in the obj_stock, the old lruvec data cached in obj_stock are > flushed out. Unfortunately, they were flushed to the new pgdat and > hence the wrong node, not the one cached in obj_stock. > > Fix that by flushing the data to the cached pgdat instead. > > Fixes: 68ac5b3c8db2 ("mm/memcg: cache vmstat data in percpu memcg_stock_pcp") > Signed-off-by: Waiman Long After incorporating Michal's comments, you can add: Reviewed-by: Shakeel Butt From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shakeel Butt Subject: Re: [PATCH] mm/memcg: Fix incorrect flushing of lruvec data in obj_stock Date: Mon, 2 Aug 2021 07:32:01 -0700 Message-ID: References: <20210802022827.10192-1-longman@redhat.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=19nfVkDw1JHrHyLVrxQ7C3iIv4HJUAVawRYI+zVDKis=; b=g2rXIt6PCcJyTa2L7O6qIeZjWDnqOSfddyk6MrYcfEsfL7ZHrImFAKiYu/6qeNFXml uFaNVZeiebZF2qSRn4MPkT99U8W2aI+dIRtgDQCtGeKJguajzSd2fILGxt3hoaOrg5Al jNhOcCLyG2pjA96otAuaSej7Cs/zqm5fq7ZGMOXetpdUIAfuG7QYlshPWqrprPyvnP/b eWM3QaOgo34fZF71q7x5gABjzMONsiYCOtCG0wrB3MMQG3KaQk5Cflt++3Ea2NnFguBI Vvm4lTfSqGY7YleaXqoyw66XVOUYcxVgtMYqifv6gkKvQu33r8bafyCu1ggNmNAPF1uk 2QEg== In-Reply-To: <20210802022827.10192-1-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Tejun Heo , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , LKML , Cgroups , Linux MM , Muchun Song , Alex Shi , Chris Down , Yafang Shao , Wei Yang , Masayoshi Mizuma , Xing Zhengjun On Sun, Aug 1, 2021 at 7:28 PM Waiman Long wrote: > > When mod_objcg_state() is called with a pgdat that is different from > that in the obj_stock, the old lruvec data cached in obj_stock are > flushed out. Unfortunately, they were flushed to the new pgdat and > hence the wrong node, not the one cached in obj_stock. > > Fix that by flushing the data to the cached pgdat instead. > > Fixes: 68ac5b3c8db2 ("mm/memcg: cache vmstat data in percpu memcg_stock_pcp") > Signed-off-by: Waiman Long After incorporating Michal's comments, you can add: Reviewed-by: Shakeel Butt