From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E4E1C433ED for ; Sat, 10 Apr 2021 17:48:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 11F9F610A4 for ; Sat, 10 Apr 2021 17:48:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234866AbhDJRsp (ORCPT ); Sat, 10 Apr 2021 13:48:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234392AbhDJRso (ORCPT ); Sat, 10 Apr 2021 13:48:44 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F60FC06138A for ; Sat, 10 Apr 2021 10:48:29 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id u4so10246691ljo.6 for ; Sat, 10 Apr 2021 10:48:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DFoH6NSNyfcllxZN9x7T5g5NvAfI0hR11J01wzi+Rak=; b=emMH1QS+ntGVOEoQCjkRSaiVYfOIXxsZAVWPA2MGa6XMik3AdWgQe0SryVA+QHUPzp XOvi4etlW95I/m9i34aOYC4SMQsb5KTxp6WCbSId/48q0S9g8FzTlEc8njKoIZdLihmE iZT6H5AZ/gyN0aVdSsYbUXFyrdNEprEAj0KT6RE/aoSZHVzhKSEVLzGirP9vQAb8HdQC OpyC4JlAqWTCaW+dnXwU2pXLMzLxZakFewNyqPnwe/9/yRqmzjzsXyL9Xw9IuHediXVg oiXZeX4mcb8DiaMAxUhWTxbFh2UCVWbuzwVhD+5Y+XC62vsTXf7VMEnW4uMb7CKr3Cvy IPTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DFoH6NSNyfcllxZN9x7T5g5NvAfI0hR11J01wzi+Rak=; b=BbuZs9BJE2oSKkZ4hlu1o0VefQ7+CDhYTry5KTRMBxw54nUaYoulqYGPqvkW6IPJfO stIrjZS4uMk1VLWzmkl3Kn+uAuN2yZMTifMPOpYPVTP0M2kFbViE+uU8lOmmDquXVDLE sKooM1TP4ZhgU3nRKi/+QOSKJbmSaCFNGzL9DtOxynHNX1PzDPrvcXlbLCInWe0k4REN /3dJEAHL1lUzkEBBDeiyCHqyhyHBcOzU+5lxDKkN/XYbwNnAZyXWALpqvWf1lXrwFdxp 1hw01yVDzOUJ4+kWrgPOuXIQm1M9XAWzgDy9yAdBHvnJtPgPGDTviZB2L89KYLJDbccI rS3g== X-Gm-Message-State: AOAM531cLPzReqIyuDVl00IHTxH6CBSA1u6WczthaDgkuF7ApTjSNvy1 ApJ3FyxqYVQUfg0HS4bLkQlOL1pPhFx8yb1LCk+otw== X-Google-Smtp-Source: ABdhPJxLufwnOXy37cZiWyWJfbYB1vHp9t55UdLiNPCWj3YOOiYNs7H1qWVwplBjsckKTMcCAbHkDXvZ4TD6kqJWtDs= X-Received: by 2002:a05:651c:1248:: with SMTP id h8mr613628ljh.160.1618076908037; Sat, 10 Apr 2021 10:48:28 -0700 (PDT) MIME-Version: 1.0 References: <20210409122959.82264-1-songmuchun@bytedance.com> <20210409122959.82264-10-songmuchun@bytedance.com> In-Reply-To: From: Shakeel Butt Date: Sat, 10 Apr 2021 10:48:15 -0700 Message-ID: Subject: Re: [External] Re: [RFC PATCH v2 09/18] mm: vmscan: remove noinline_for_stack To: Muchun Song Cc: Johannes Weiner , Roman Gushchin , Michal Hocko , Andrew Morton , Vladimir Davydov , LKML , Linux MM , Xiongchun duan , fam.zheng@bytedance.com, Balbir Singh , Yang Shi , Alex Shi Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 9, 2021 at 9:34 PM Muchun Song wrote: > > On Sat, Apr 10, 2021 at 2:31 AM Johannes Weiner wrote: > > > > On Fri, Apr 09, 2021 at 08:29:50PM +0800, Muchun Song wrote: > > > The noinline_for_stack is introduced by commit 666356297ec4 ("vmscan: > > > set up pagevec as late as possible in shrink_inactive_list()"), its > > > purpose is to delay the allocation of pagevec as late as possible to > > > save stack memory. But the commit 2bcf88796381 ("mm: take pagevecs off > > > reclaim stack") replace pagevecs by lists of pages_to_free. So we do > > > not need noinline_for_stack, just remove it (let the compiler decide > > > whether to inline). > > > > > > Signed-off-by: Muchun Song > > > > Good catch. > > > > Acked-by: Johannes Weiner > > > > Since this patch is somewhat independent of the rest of the series, > > you may want to put it in the very beginning, or even submit it > > separately, to keep the main series as compact as possible. Reviewers > > can be more hesitant to get involved with larger series ;) > > OK. I will gather all the cleanup patches into a separate series. > Thanks for your suggestion. That would be best. For this patch: Reviewed-by: Shakeel Butt From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66E0CC433B4 for ; Sat, 10 Apr 2021 17:48:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D92A8611C1 for ; Sat, 10 Apr 2021 17:48:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D92A8611C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6E6508E0002; Sat, 10 Apr 2021 13:48:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6978D8E0001; Sat, 10 Apr 2021 13:48:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55E9B8E0002; Sat, 10 Apr 2021 13:48:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0180.hostedemail.com [216.40.44.180]) by kanga.kvack.org (Postfix) with ESMTP id 3A4C58E0001 for ; Sat, 10 Apr 2021 13:48:30 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 055236D67 for ; Sat, 10 Apr 2021 17:48:30 +0000 (UTC) X-FDA: 78017191980.22.37F8144 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf05.hostedemail.com (Postfix) with ESMTP id 2E46EE000115 for ; Sat, 10 Apr 2021 17:48:29 +0000 (UTC) Received: by mail-lj1-f177.google.com with SMTP id y1so10228721ljm.10 for ; Sat, 10 Apr 2021 10:48:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DFoH6NSNyfcllxZN9x7T5g5NvAfI0hR11J01wzi+Rak=; b=emMH1QS+ntGVOEoQCjkRSaiVYfOIXxsZAVWPA2MGa6XMik3AdWgQe0SryVA+QHUPzp XOvi4etlW95I/m9i34aOYC4SMQsb5KTxp6WCbSId/48q0S9g8FzTlEc8njKoIZdLihmE iZT6H5AZ/gyN0aVdSsYbUXFyrdNEprEAj0KT6RE/aoSZHVzhKSEVLzGirP9vQAb8HdQC OpyC4JlAqWTCaW+dnXwU2pXLMzLxZakFewNyqPnwe/9/yRqmzjzsXyL9Xw9IuHediXVg oiXZeX4mcb8DiaMAxUhWTxbFh2UCVWbuzwVhD+5Y+XC62vsTXf7VMEnW4uMb7CKr3Cvy IPTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DFoH6NSNyfcllxZN9x7T5g5NvAfI0hR11J01wzi+Rak=; b=diOwD6rtL0GPRrXb7Wy5CcsAiOwb2R8a6pj3/IkHqg4fDDXoUNYVl0vvpuR3DQmFIY wldJpEP1qzLxplCLDFWXepitp2guK7d7OhGuTBvXJ0dLymuUNve7zEdOPdsh/8dRCo7E NcTcoJrKX5jfXKsLg/1KIBU3I6aKfL7v4/7HUX51iuKl66Vg1hKRrOI8pHQCNhwKR+fx Wxu+4UR/N45j8Zk4Lqe8fiXH+5m/Cu7P6mocHfkVgZ/BKpbkXwX2jlK1NyT+IlDGTB/g qWXuMqo3GrdzEqmiYzus+cJRULnnqc3KTDHI/U3duMLur6EgbOKcQ4KXPemiNRhG+OHI t+eg== X-Gm-Message-State: AOAM5320jD9CbLR0a68G+e3NKUvQ6la1QshhKceuH5NUFMEuTHT+jAXl IpmNQBjKDR8+PddQjM0Nma/UvJlzCVTmLoeIxctDsg== X-Google-Smtp-Source: ABdhPJxLufwnOXy37cZiWyWJfbYB1vHp9t55UdLiNPCWj3YOOiYNs7H1qWVwplBjsckKTMcCAbHkDXvZ4TD6kqJWtDs= X-Received: by 2002:a05:651c:1248:: with SMTP id h8mr613628ljh.160.1618076908037; Sat, 10 Apr 2021 10:48:28 -0700 (PDT) MIME-Version: 1.0 References: <20210409122959.82264-1-songmuchun@bytedance.com> <20210409122959.82264-10-songmuchun@bytedance.com> In-Reply-To: From: Shakeel Butt Date: Sat, 10 Apr 2021 10:48:15 -0700 Message-ID: Subject: Re: [External] Re: [RFC PATCH v2 09/18] mm: vmscan: remove noinline_for_stack To: Muchun Song Cc: Johannes Weiner , Roman Gushchin , Michal Hocko , Andrew Morton , Vladimir Davydov , LKML , Linux MM , Xiongchun duan , fam.zheng@bytedance.com, Balbir Singh , Yang Shi , Alex Shi Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 2E46EE000115 X-Stat-Signature: jn7gqxrgihd3r74tj453ga9e44pnnutx X-Rspamd-Server: rspam02 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf05; identity=mailfrom; envelope-from=""; helo=mail-lj1-f177.google.com; client-ip=209.85.208.177 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618076909-384466 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 9, 2021 at 9:34 PM Muchun Song wrote: > > On Sat, Apr 10, 2021 at 2:31 AM Johannes Weiner wrote: > > > > On Fri, Apr 09, 2021 at 08:29:50PM +0800, Muchun Song wrote: > > > The noinline_for_stack is introduced by commit 666356297ec4 ("vmscan: > > > set up pagevec as late as possible in shrink_inactive_list()"), its > > > purpose is to delay the allocation of pagevec as late as possible to > > > save stack memory. But the commit 2bcf88796381 ("mm: take pagevecs off > > > reclaim stack") replace pagevecs by lists of pages_to_free. So we do > > > not need noinline_for_stack, just remove it (let the compiler decide > > > whether to inline). > > > > > > Signed-off-by: Muchun Song > > > > Good catch. > > > > Acked-by: Johannes Weiner > > > > Since this patch is somewhat independent of the rest of the series, > > you may want to put it in the very beginning, or even submit it > > separately, to keep the main series as compact as possible. Reviewers > > can be more hesitant to get involved with larger series ;) > > OK. I will gather all the cleanup patches into a separate series. > Thanks for your suggestion. That would be best. For this patch: Reviewed-by: Shakeel Butt